yanwah/cobblemon
1
0
Fork 0
forked from mirrors/cobblemon
Code Pull Requests Activity

#1945 Brewing Stand Shift Click Crash NeoForge 1.7.3 [1.21.1]

Browse Source
This commit is contained in:
Cyrus
2026-02-27 00:08:36 +00:00
committed by Polymeta
parent fae6bdb782
commit 92c8fc0afc
3 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1
View File
@@ -35,6 +35,7 @@
- Fix Pastured mons despawning and running away. - Fix Pastured mons despawning and running away.
- Fix Apricorn trees crashing when other mods bonemeal it - Fix Apricorn trees crashing when other mods bonemeal it
- [Various UFO Ride Improvements](https://gitlab.com/cable-mc/cobblemon/-/merge_requests/2156) - [Various UFO Ride Improvements](https://gitlab.com/cable-mc/cobblemon/-/merge_requests/2156)
- Fixed NeoForge brewing stand unexpectedly crashing users when shift clicking items within it's menu
### Developer ### Developer
changelogs/CHANGELOG-1.7.3.md
-1
View File
@@ -6,7 +6,6 @@
- Fixed players failing to join servers randomly. - Fixed players failing to join servers randomly.
- Fixed some Pokémon having no stamina for flying. - Fixed some Pokémon having no stamina for flying.
- Fixed `/pctake` not respecting the actual size of the PC. - Fixed `/pctake` not respecting the actual size of the PC.
### Developer ### Developer
- Poké Ball GUI textures now respect the ball's namespace, enabling proper texture loading for custom balls from other mods. - Poké Ball GUI textures now respect the ball's namespace, enabling proper texture loading for custom balls from other mods.
neoforge/src/main/java/com/cobblemon/mod/neoforge/mixin/NeoforgeBrewingStandMenuMixin.java
+3 -9
View File
@@ -8,28 +8,22 @@
package com.cobblemon.mod.neoforge.mixin; package com.cobblemon.mod.neoforge.mixin;
import com.cobblemon.mod.common.duck.RecipeAwareSlot;
import com.cobblemon.mod.common.item.crafting.brewingstand.BrewingStandRecipe; import com.cobblemon.mod.common.item.crafting.brewingstand.BrewingStandRecipe;
import com.llamalad7.mixinextras.injector.wrapoperation.Operation; import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation; import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
import com.llamalad7.mixinextras.sugar.Local; import com.llamalad7.mixinextras.sugar.Local;
import net.minecraft.world.Container;
import net.minecraft.world.entity.player.Inventory;
import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.player.Player;
import net.minecraft.world.inventory.BrewingStandMenu; import net.minecraft.world.inventory.BrewingStandMenu;
import net.minecraft.world.inventory.ContainerData;
import net.minecraft.world.inventory.Slot;
import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.alchemy.PotionBrewing; import net.minecraft.world.item.alchemy.PotionBrewing;
import org.jetbrains.annotations.NotNull;
import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At; import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
@Mixin(BrewingStandMenu.class) @Mixin(BrewingStandMenu.class)
public abstract class NeoforgeBrewingStandMenuMixin { public abstract class NeoforgeBrewingStandMenuMixin {
@WrapOperation(method = "quickMoveStack", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/inventory/BrewingStandMenu$PotionSlot;mayPlaceItem(Lnet/minecraft/world/item/alchemy/PotionBrewing;Lnet/minecraft/world/item/ItemStack;)Z")) @WrapOperation(method = "quickMoveStack", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/inventory/BrewingStandMenu$PotionSlot;mayPlaceItem(Lnet/minecraft/world/item/alchemy/PotionBrewing;Lnet/minecraft/world/item/ItemStack;)Z"))
private boolean cobblemon$isPotionBottle(PotionBrewing potionBrewing, ItemStack itemStack, Operation<Boolean> original, @Local(argsOnly = true) Player player) { private boolean cobblemon$isPotionBottle(PotionBrewing potionBrewing, ItemStack itemStack, Operation<Boolean> original, @Local(argsOnly = true) @NotNull Player player) {
return BrewingStandRecipe.Companion.isBottle(itemStack, player.level().getRecipeManager()) || original.call(itemStack); return BrewingStandRecipe.Companion.isBottle(itemStack, player.level().getRecipeManager()) || original.call(potionBrewing, itemStack);
} }
} }