Merge branch 'fix/particles-respecting-graphics-setting' into 'main'

fix: particle density should respect minecraft particle density settings

See merge request cable-mc/cobblemon!2446

CHANGELOG.md

@@ -157,6 +157,7 @@
 - Fixed certain Pokémon sounds sometimes being doubled when played at specific times in their animations
 - Fixed ball capture beam origin coming from behind the ball.
 - Fixed Safari Ball catch rate outside of battle
+- Fixed alpha eye (and other) particles not respecting client particle density setting in video options
 
 ### Developer
 - Evolution requirements can now set `pokedexIcon` and `pokedexTooltip` directly in their JSON to control how they're shown on the Pokédex's evolution tree, for example:

common/src/main/kotlin/com/cobblemon/mod/common/api/pokemon/aspect/AspectParticleMap.kt

@@ -15,6 +15,8 @@ import com.cobblemon.mod.common.block.entity.PokeSnackBlockEntity
 import com.cobblemon.mod.common.client.entity.PokemonClientDelegate
 import com.cobblemon.mod.common.client.render.MatrixWrapper
 import com.cobblemon.mod.common.util.cobblemonResource
+import net.minecraft.client.Minecraft
+import net.minecraft.client.ParticleStatus
 import net.minecraft.core.particles.BlockParticleOption
 import net.minecraft.core.particles.ParticleOptions
 import net.minecraft.core.particles.ParticleTypes
@@ -40,13 +42,25 @@ sealed class ParticleData {
         val chance: Double,
         val amount: Int,
         val locatorResolver: (Map<String, MatrixWrapper>) -> List<String>
-    ): ParticleData()
+    ): ParticleData() {
+        fun amount(): Int = when(Minecraft.getInstance().options.particles().get()) {
+            ParticleStatus.ALL -> amount
+            ParticleStatus.DECREASED -> amount / 2
+            ParticleStatus.MINIMAL -> amount / 4
+        }
+    }
 
     data class MinecraftParticle(
         val particle: ParticleOptions,
         val chance: Double,
         val amount: Int
-    ): ParticleData()
+    ): ParticleData() {
+        fun amount(): Int = when(Minecraft.getInstance().options.particles().get()) {
+            ParticleStatus.ALL -> amount
+            ParticleStatus.DECREASED -> amount / 2
+            ParticleStatus.MINIMAL -> amount / 4
+        }
+    }
 }
 
 /**

common/src/main/kotlin/com/cobblemon/mod/common/client/entity/PokemonClientDelegate.kt

@@ -475,7 +475,7 @@ class PokemonClientDelegate : PosableState(), PokemonSideDelegate {
                         val locators = particleData.locatorResolver(locatorStates).filter(::isLocatorVisible)
                         if (particleData.chance > random.nextDouble()) {
                             locators.forEach { locator ->
-                                repeat(particleData.amount) {
+                                repeat(particleData.amount()) {
                                     runtime.resolve("q.particle('${particleData.particle}', '$locator')".asExpressionLike())
                                 }
                             }
@@ -485,7 +485,7 @@ class PokemonClientDelegate : PosableState(), PokemonSideDelegate {
                     is ParticleData.MinecraftParticle -> {
                         if (particleData.chance > random.nextDouble()) {
                             val box = currentEntity.boundingBox
-                            repeat(particleData.amount) {
+                            repeat(particleData.amount()) {
                                 val x = box.minX + (box.maxX - box.minX) * random.nextDouble()
                                 val y = box.minY + (box.maxY - box.minY) * random.nextDouble()
                                 val z = box.minZ + (box.maxZ - box.minZ) * random.nextDouble()