Merge branch 'main' into implement_pokemon

CHANGELOG.md

@@ -1,5 +1,5 @@
 # Changelog
-## [1.8.0 (September Xth, 2026)](#1-8-0)
+## [1.x.x (MONTH Xth, 2026)](#1-x-x)
 
 ### Fixes
 - Fixed Ampharos' eyes not emitting particles
@@ -13,534 +13,28 @@
 ## [1.8.0 (MONTH Xth, 2026)](#1-8-0)
 
 ### Additions
-- Added Alpha Pokémon
-  - Alpha Pokémon are bigger, stronger, and more aggressive than regular Pokémon.
-  - They are also scarier.
-  - They always know a TM move and will adapt to be stronger than your party.
-  - Alphas will always lead herds and spawn in herds
-- Added alpha Pokémon attraction bait effect to Hopo Berries.
-- Added intrinsic scaling to all Pokémon (anywhere from 5% smaller to 5% bigger than normal). Some cases, such as shoulder mounting, will not scale so that the shoulder animations don't look silly.
-- Added scaling to "baby" Pokémon (10% smaller at level 1 → normally sized at level 10).
-- Added TMs.
-  - Added TM Machine. TMs are made from elemental type gems, and their recipes are unlocked by having Pokémon that know the move.
-  - Added config options for making TMs infinite-use and instant unlocking of all TM recipes.
-  - Added Type Gem blocks as well as crystal clusters and deepslate core blocks that are used for growing elemental type gems.
-- Added a new Starter Selection menu that looks way better.
-- Added a "Move Dex" to the Pokédex to help identify what moves a Pokémon can learn and what Pokémon can get a move.
-- Added the Habitat Block, a spawner block for servers and adventure maps that controls spawning in an area.
-- Added 49 new habitat structures. In these habitats you will find rarer Pokémon and sometimes different Pokémon will appear on different days.
-- Added a toast to notify players of how they can scroll through their party. Did you know you can hold R and scroll instead of using arrow keys? It's true!!!
-- Added a way to obtain Porygon by inserting an Upgrade or Dubious Disc into a data monitor.
-- Added Disk Rack for storing disks and being an audio sequencer for Noteblocks. What does that have to do with Pokémon? How about you mind your own business!
-- Party Overlay Exp Gained Animation will now display the amount of EXP the Pokémon gained.
-- Added missing crops to Botany Pots integration.
-- Added conditional seats for riding. Seats can be gated by Molang such as "is_alpha".
-- Added 10 new ruin structures.
-- Added a new shipwreck cove structure called the Magma Shipwreck Cove.
-- Added 7 new advancements
-- Pressing the inventory key now closes the Pokémon interact wheel GUI
-- Pokémon cries now play when clicking Pokémon in the summary screen.
-- Held item visibility can now be controlled by the `held_item_visible` command argument.
-- Added config option to disable Pokémon spawning on a per-world basis.
-- Added config options to award experience to fainted Pokémon for opponents they helped defeat (`awardExperienceToFaintedPokemon`) and to still award experience for defeated enemies even after battle loss/forfeit (`awardExperienceOnBattleLoss`)
-- Added /givetm command
-- Added advancement triggers for learning TMs: `cobblemon:has_learn_specific_tm` (per-TM), `cobblemon:has_learn_all_tm` (all TMs learned), and `cobblemon:tms_learned` (count-based), backed by a new `totalTMLearnedCount` on player advancement data.
-- Added `cobblemon:catch_alpha_pokemon` advancement trigger and `totalAlphaCaptureCount` stat for captured Alpha Pokémon.
 
 ### New rideable Pokémon
-- Crobat
-- Skarmory
-- Milotic
-- Archeops
-- Goodra 
-- Goodra (Hisuian Form)
-- Drampa
-- Duraludon
-- Archaludon
 
 ### Pokémon Added
-#### Generation 3
-- Wurmple
-- Silcoon
-- Beautifly
-- Cascoon
-- Dustox
-- Skitty
-- Delcatty
-- Seviper
-- Zangoose
-
-#### Generation 4
-- Cherubi
-- Cherrim
-- Stunky
-- Skuntank
-
-#### Generation 5
-- Audino
-- Pawniard
-- Bisharp
-
-#### Generation 6
-- Pancham (+ Cosmetic with Black Glasses)
-- Pangoro (+ Cosmetic with Black Glasses)
-
-#### Generation 7
-- Rockruff
-- Lycanroc
-
-#### Generation 8
-- Rolycoly
-- Carkol
-- Coalossal
-- Runerigus
-- Snom
-- Frosmoth
-- Indeedee
-- Duraludon
-- Applin
-- Flapple
-- Appletun
-
-#### Generation 9
-
-- Nymble
-- Lokix
-- Kingambit
-- Dipplin
-- Archaludon
-- Hydrapple
-
-#### Regional Forms
-- Sandshrew (Alolan Form)
-- Sandslash (Alolan Form)
-- Yamask (Galarian Form)
-- Avalugg (Hisuian Form)
 
 ### Model updates for the following Pokémon
 
-- Sandshrew
-- Sandslash
-- Nidoking
-- Zubat
-- Golbat
-- Crobat
-- Ditto
-- Porygon
-- Porygon2
-- Porygon-Z
-- Skarmory
-- Smoochum
-- Jynx
-- Popplio
-- Brionne
-- Primarina
-- Fletchling
-- Fletchinder
-- Talonflame
-- Sableye
-- Mawile
-- Goomy
-- Sliggoo
-- Goodra
-- Nacli
-- Naclstack
-- Garganacl
-- Bidoof
-- Cranidos
-- Chatot
-- Yamask
-- Cofagrigus
-- Tyranitar
-- Turtonator
-- Golett
-- Corsola
-- Arbok (New Patterns: Angry, Cartoon, Clown, Comedic, Crow, Grin, Ink, Modern, Rain, Scribble, Silence, Sloth, Suspicious, Will)
-- ... and Substitute
-
-#### Model changes to the regional bias resource pack:
-
-- Added Mime Jr. (Galar Bias)
-- Added Bergmite (Hisui Bias)
-- Changed models for every existing regional bias
-
 ### Animation updates for the following Pokémon
 
-- Kakuna
-- Grimer
-- Nidoran♀ (+ New shoulder mount)
-- Nidorina
-- Nidoran♂ (+ New shoulder mount)
-- Sandshrew
-- Diglett
-- Dugtrio
-- Graveler
-- Happiny
-- Chansey
-- Blissey
-- Poliwhirl
-- Poliwrath
-- Zubat
-- Vulpix
-- Drowzee
-- Hypno
-- Noctowl
-- Skarmory
-- Skitty
-- Flygon
-- Shellos
-- Riolu
-- Lucario
-- Purrloin
-- Liepard
-- Joltik
-- Galvantula
-- Nidoking
-- Fletchling
-- Fletchinder
-- Talonflame
-- Archeops
-- Drampa
-- Sewaddle
-- Swadloon
-- Leavanny
-- Goomy
-- Sliggoo
-- Goodra
-- Shedinja
-- Skwovet
-- Greedent
-- Bidoof
-- Cranidos
-- Chatot
-- Yamask
-- Cofagrigus
-- Luvdisc
-- Staryu
-- Starmie
-- Togetic
-- Rellor
-- Rabsca
-- Yungoos
-- Gumshoos
-- Cottonee
-- Whimsicott
-- Corsola
-
-#### Added sounds to the following moves
-
-- Absorb
-- Aurora Beam
-- Double Team
-- Draco Meteor
-- Fire Punch
-- Fire Spin
-- Flame Charge
-- Flame Wheel
-- Giga Drain
-- Ice Punch
-- Leech Life
-- Magical Leaf
-- Mega Drain
-- Minimize
-- Poison Gas
-- Rock Throw
-- Scary Face
-- Seed bomb
-- Smokescreen
-- String Shot
-- Tail Whip
-
 ### Changes
-- Stat increase and decrease particles have been changed, with the addition of alpha boost particles. 
-- Dragonite's mailbag cosmetic can now also be obtained with a chest in the cosmetic slot
-- Adjusted the walk speed for Croagunk and Aerodactyl.
-- Sharp Beak can now be crafted using bones and Flying Gems.
-- Metal Alloy can now be crafted using iron and Thunder Stones.
-- Ability Capsules can now be brewed from Medicinal Brew and Dragon Breath.
-- Using an Ability Capsule will now return an Empty Bottle.
-- Rooted Arch Ruins, Crumbling Arch Ruins, and all fossil structures have been improved so that they generate more naturally in terrain.
-- All ruin structures that did not generate with a gimmighoul/gilded chest before will now generate with one.
-- All ruin structures gilded chest loot tables have been updated to include a guaranteed TM not learned naturally by any Pokémon through their level-up moveset. Each ruin gets its own specific TM, so you can now go hunting ruins to complete your move dex!
-- The prehistoric_underwater_fissure & prehistoric_submerged_impact fossil structures now use the biome tag `#cobblemon:is_temperate_ocean`.
-- The lush shipwreck cove's phantom mob spawner has been replaced with breezes.
-- Gimmighoul towers now generate at ground-level rather than sinking one block into the ground.
-- Shipwreck coves now generate slightly more frequently.
-- Added equipment loot tables for shipwreck cove enemies.
-- Maps from abandoned fishing boats leading to shipwreck coves now will skip explored chunks, allowing the player to find more shipwreck coves easier.
-- All shipwreck coves' spawners have been adjusted to give compatible mobs enchanted iron or diamond armour and weapons while in its ominous state. The armour given to the mobs will also use the automaton trim. We upped the difficulty because it was too easy now that your Pokémon can fight for you.
-- One TM of the elemental hyper beams has been added as guaranteed loot to the main treasure chest in every shipwreck cove. (Magma Cove gets Blast Burn, Lush Cove gets Frenzy Plant, and Submerged Cove gets Hydro Cannon)
-- The following items can now be obtained by brushing the following Pokémon:
-  - Pink Wool - Wigglytuff
-  - White Wool - Swablu, Altaria
-  - Shed Shell - Ekans, Arbok, Dratini, Dragonair, Dunsparce, Treecko, Grovyle, Sceptile, Seviper, Scraggy, Scrafty, Helioptile, Heliolisk, Salandit, Salazzle, Sobble, Drizzile, Inteleon, Silicoblra, Sandaconda, Toxel, Toxtricity, Orthworm, Dudunsparce
-  - Phantom Membrane - Dreepy, Drakloak, Dragapult
-- The following items can now be obtained by evolving the following Pokémon into any of their evolutions:
-  - Turtle Scute - Squirtle, Wartortle, Turtwig, Grotle, Tirtouga, Chewtle
-  - Shed Shell - Metapod, Kakuna, Ekans, Paras, Venonat, Krabby, Scyther, Kabuto, Dratini, Dragonair, Ledyba, Spinarak, Yanma, Pineco, Dunsparce, GLigar, Pupitar, Treecko, Grovyle, Silcoon, Cascoon, Surskit, Nincada, Trapinch, Vibrava, Corphish, Anorith, Bagon, Shelgon, Kricketot, Burmy, Combee, Skorupi, Swadloon, Whirlipede, Dwebble, Scraggy, Karrablast, Joltik, Larvesta, Spewpa, Clauncher, Helioptile, Charjabug, Crabrawler, Cutiefly, Dewpider, Salandit, Wimpod, Poipole, Sobble, Drizzile, Dottler, Silicobra, Toxel, Sizzlipede, Snom, Tarountula, Nymble, Rellor
-- Saccharine Leaves now drop Tart, Sweet, or Syrupy Apples, depending on their honey coating stage, instead of vanilla Apples.
-- Fixed the height of the Tumblestone Bud items when held in hand, placed on head, viewed in a GUI, and placed in an Item Frame.
-- Refactored all advancements, removing several deemed unnecessary. Due to this cleanup, all previously obtained advancements will be reset besides the root (for picking a starter Pokémon). This sucks, and we're sorry. We had to do this eventually so better now than later.
-- Decrease the default pastured wander radius to 32 blocks.
-- Factor in the weight of Pokémon when calculating pushing forces between hitboxes.
-- Refactored berry trees to be less impactful on TPS (more performant)
-- Indexed party/PC stores by UUID so lookups no longer scan the whole store, reducing MSPT with many pastured Pokémon
-- Changed the bait effects of the following items: (Vanilla) Sweet & Glow Berries, Golden & Enchanted Golden Apples (Cobblemon) Custap, Eggant, Hopo & Micle Berries, Sweet Hearts
-- Wild Pokémon now reliably have at least one offensive move if they can have offensive moves at that level.
-- Data Monitor can accept Disks (TMs, Music Disks, Upgrade, Dubious Disk, etc.) to change what's being displayed on the screen
-- Rider positioning is now client-driven (Remove poseOffsets and offset per seat/pose) in favour of sending real-time passenger position.
-- Cleaned up seat data. Removed all now unused fields from seats in all species files. Also made locator seat names explicit in the species files (however, this doesn't break the legacy format)
-- Marks can now provide aspects.
-- Added new shiny and Alpha chance configs
-- Apricorns now make a new sound when harvested
-- Lowered the volume of harvesting berries
-- Added alternate versions of the basic PC Wallpapers based on the original design of Cobblemon's PC, before public release
-- Improved compatibility with various mods
-    - Farmer's Delight's cutting board can now be used to strip Apricorn and Saccharine's logs, or salvage their planks from various blocks. It can also separate their boats from chests
-    - Farmer's Delight's cutting board can be used to get two white dye from Pep-Up Flowers and two magenta dye from Medicinal Leeks
-    - Farmer's Delight's cutting board can separate Tumblestone Blocks back into Tumblestones
-    - Farmer's Delight's cutting board can salvage Type Gems from their Gem Blocks
-    - Farmer's Delight's Onions, Tomatoes, and Cabbages can be used to cook Open-Faced Sandwiches. Nature's Spirit's Olives also can be used
-    - Farmer's Delight's cutting board can be used on Hearty Grains to obtain rice and straw, similarly to Farmer's Delight's Rice Panicles
-    - Farmer's Delight's Apple Pies and Apple Ciders can now be made using Applin Apples, alongside the Vanilla counterpart
-    - Amendments allows for cooking Leek and Potato Stew in a Cauldron
-    - Any mods that utilise Moonlight's Soft Fluid system can store Leek and Potato Stew, Medicinal Brew, Antidote, Awakening, Burn Heal, Ice Heal, Paralyze Heal, Full Heal, Potion, Super Potion, Hyper Potion, Max Potion, Full Restore, Ability Capsules, Moomoo Milk, and Berry Juice in liquid form (such as Suplementaries' Jar or Goblet, or Cauldrons while using Amendments)
-    - Supplementaries' Hourglass can now use Bright Powder, Quick Powder, Metal Powder, Heal Powder, Silver Powder, and Remedy
-    - Berry Trees are now compatible with the Planter properly
-    - Saccharine Way Signs (added by Supplementaries automagically) now use a premade texture to prevent odd visual issues
-    - Supplementaries' Jar can now store various Cobblemon cookies, candies, and similar items
-    - Some of Supplementaries' items have been added to the `#cobblemon:held/container_held_items` item tag, including sacks, safes, and lunch baskets
-    - Experience Nuggets can be used in place of Sculk for making the EXP Candies if using Create
-    - Rage Candy Bar has a Create Mixing recipe
-    - All Cobblemon ores can now be crushed in Create's Crushing Wheels
-    - All Gem and Tumblestone Clusters can be crushed for automatic, low return, gems
-    - Hearty Grains can be milled like Farmer's Delight Rice Panicles if both Farmer's Delight and Create are installed
-    - Big Roots and Revival Herbs can be milled to their respective powders
-    - Pep-Up Flowers, Medicinal Leeks, and all 70 berries can be milled in Create's Millstone for additional dye drops
-    - Auspicious Armour and Upgrades can be Haunted using Create's crafting systems
-    - Applin Apples can be used to make Honeyed Apples in Create
-- Golden Apples can now be crafted using the Applin Apples
-- Prismarine Crystals and Amethyst Shards can now be used to craft Pokedexes
-- Updated Pokédex Screens item tag to support tagged variants of Redstone and Glowstone Dust
-- Sounds for interacting with various Cobblemon blocks now play from the centre of the block, rather than the corner
-- The `/pc` command no longer plays PC activation sounds
-- Pressing the Summary key while either the starter selection or summary screen are open now closes those screens.
-- Ice type Pokémon are now immune to Packed Snow.
-- Added cobweb block slowness immunity for spider Pokémon
 
 ### Fixes
-- Fixed Blitzle's base scale being `1` rather than the intended `0.8`
-- Fixed Magnezone's emissive layer for the shiny having the wrong name, thus displaying wrongly
-- Fixed Litleo not blinking
-- Fixed Omanyte and Omastar incorrectly using water animations on land.
-- Fixed Pokédex layout for genderless variations
-- Fixed odd stacking behaviour with the poke_bait item.
-- Fixed a compatibility issue with World Game Rules which caused some log spam in specific cases.
-- Fixed improper validation of Pokémon when performing a trade.
-- Fixed an issue where particle like beam can disappear when you don't see the beginning of the beam, or you look away
-- Fixed Bedrock particle materials (alpha/opaque/blend/add) sharing one render batch, which caused incorrect culling on mixed batches; each material now batches and draws with its own blend and cull state, and the alpha material renders as a true cutout
-- Fixed an occasional crash on retrieving revived fossils
-- Fixed brushing not working on Neoforge
-- Fixed braking not working for submarines (whoops).
-- Fixed strafing not having the same friction as forward movement (funny whoops).
-- Fixed submarine's surface-water animations not playing when supposed to.
-- Fixed submarine camera freaking out when looking up or down on the surface.
-- Fixed pastured mons despawning and running away.
-- Fixed Apricorn trees crashing when other mods bonemeal it
-- Fixed the issue that caused Hover Behaviour rides without a ground style to be rendered useless upon touching the ground on a server.
-- Removed the "inAir" penalty for block destruction speed when on a hover mount.
-- Fixed horizontal and vertical collisions with hover mounts so they no longer accumulate or retain momentum
-- Fixed NeoForge brewing stand unexpectedly crashing users when shift clicking items within its menu
-- Fixed NPCs switching Pokémon very often during battles
-- Fixed Campfire pot causing crashes under certain circumstances
-- Fixed Type Gems not being consumed upon use
-- Fixed Ancient Pokéball's to their respective modifiers
-- Fixed a Server warning when recalling Pokémon
-- Fixed sliding particles incorrectly handling block collision
-- Fixed Full Heal not curing status conditions in battle
-- Fixed a rare issue with battles locking up when you are forced to switch, with the switch menu appearing instantly.
-- Fixed the combined effects of Pledge moves having broken Showdown message handling and localisation
-- Fixed rare Pokémon being far too likely to spawn multiple times in a single spawn cycle. The dev told me that the exact bug is too complicated to explain.
-- Resolved the niche issue where Structures would spawn in an incorrect location, creating very funky world gen.
-- Fixed Galarian Ponyta missing its cry.
-- Fixed various log warnings caused by redundant files and sound events.
-- Traded Pokémon will now retain the original friendship level when traded back to its OT
-- Clusters now display correctly on maps
-- Fixed removing mulch from berry trees with a shovel not working.
-- Fixed collecting honey from Saccharine Leaf blocks deleting Honey Bottles when the inventory was full
-- Fixed Stripped Saccharine Wood recipe being missing
-- Fixed CancelableSoundInstance causing lag by attempting to create sounds every tick when out of range of hearing
-- Fixed Stat Reducing Aprijuice not being possible to apply on a max out Pokémon, and the possibility of going into negatives
-- Fixed Exploit where you could take out the bait or drop your Pokérod with bait to avoid consuming bait, now the bobber will just disappear if you do so
-- Fixed Apricorn and Saccharine boats incorrectly using chest boat models
-- Fixed wild and trainer battle AI refusing to select moves with the `adjacentAlly` target type, even when it's their only option
-- Fixed gilded chests being more accessible than intended
-- Fixed fished up Pokémon not being added as "seen" to the Pokedex
-- Fixed surprised Gimmighoul encounters not being added as "seen" to the Pokedex
-- Fixed a crash involving berry trees that have been world edited.
-- Fixed visual desync in multiplayer for players mounting Pokémon outside other players' loaded chunks
-- Fixed Pokémon entities leveled by rare candy not getting stronger as Minecraft entities unless recalled.
-- Fixed a freeze during game load that occurred when multiple mods tried to load Cobblemon API classes at the same time.
-- Fixed random tick crashes from berry trees
-- Lowered the volume of Blitzle and Zebstrika's cry
-- Regional Foods will now prioritise being eaten instead of used for healing Pokémon, shift clicking will use it as healing
-- Resolved Z-Fighting on Pokédex Models
-- Restored Ninjask's ability to do barrel rolls
-- Fixed Raichu (male) and Alolan Raichu (both genders) not displaying the correct Partner Cap when Pewter Crunchies are in the cosmetic slot.
-- Fixed a crash caused by adding enchanted items to the Resurrection Machine
-- Fixed a crash that could occur when starting a PvN battle with only fainted Pokémon.
-- Fixed the Remember Riding Camera config not being respected when dismounting and resolved the incompatibility with the Auto Third Person mod
-- Fixed Full Heal block not dropping Full Heals
-- Fixed status cure items not returning an empty bottle when used
-- Fixed Panpour consuming its held item when evolving with a Water Stone
-- Fixed Smoked Tail Curry returning a Wooden Bowl when consumed despite it not being included in the recipe
-- Fixed `/giveallpokemon` not respecting the min and max parameters
-- Fixed the choose starter toast not disappearing when capturing a Pokémon instead of opening the starter selection screen
-- Fixed an issue where certain Sinister Tea seasonings were only applying as instant effects and would not apply over time
-- Long config option labels now scroll instead of overflowing
-- Fixed some z-fighting and clipping on Dewott and Hisui Bias Dewott
-- Eggant Berries can now be composted properly on NeoForge
-- Composting chances are now the same on NeoForge as on Fabric
-- Fixed problem where furnaces which had smelted Revival Herbs into Heal Powder in older versions would glitch out on trying to get the experience out of the block
-- Fixed the Battle AI not recognizing Surging Strikes as a multistrike move
-- Fixed some z-fighting and clipping on Dewott
-- Fixed multiple Pokémon having their cries missing
-- Fixed Tentacool not using its swim animation when on water surface
-- Fixed Eevee using its left shoulder pose when in battle
-- The Magikarp and Gyarados Jump Pattern resourcepacks should now stop replacing shiny textures of addons targeting Magikarp or Gyarados.
-- Fixed Combee's pollinated texture overwriting the shiny and female textures
-- Fixed a coloring error with Dracovish's shiny
-- Fixed Togedemaru's back spikes z-fighting
-- Fixed Sliggoo (+ Hisuian) evolving in the Nether and End, where it can't rain
-- Corrected the scales, hitbox sizes , and eye heights for Ariados, Cetoddle, Durant, Galvantula, Klink, Lanturn, Lumineon, Mantine, Mantyke, Mudbray, Numel, Staravia, and Torkoal
-- Fixed Torkoal's walk speed not matching its animation. He will no longer move faster than Bunnelby and Buneary
-- Fixed Lanturn t-posing due to missing ground walk and sleep animations. 
-- Fixed Oshawott and Dewott using their sleep animation in unintended scenarios. 
-- Fixed Dudunsparce and Maushold always having the same form instead of having the 1 in 100 chance of being different.
-- Fixed bird mounts rapidly switching between their flying and gliding animations when flying at low speed
-- Fixed some battles being startable with fainted Pokémon in the initial sendout. 
-- Fixed random gender selection for forms with strict gender divides (such as Meowstic and Oinkologne) never choosing female (that's sexist).
-- Fixed the "Press R to battle" prompt not disappearing after you finish your first battle, at least until you relogged.
-- Fixed the composter block being listed as "composer" in the cosmetic items species feature
-- Fixed Castform's forms being tagged as introduced in generation 4 instead of 3
+- Fixed the `stat_compare` and `stat_equal` evolution requirements crashing the game when given `special_attack` or `special_defence`, and made them treat any non-permanent stat as a failed requirement instead of crashing.
+- Fixed NPCs getting their own TM progress file.
+- Fixed the TM Machine refusing move selections that the `unlockAllMoveDexMovesByDefault` config had made visible, leaving the move slot blank and the craft button unresponsive.
+- Fixed Rufflet, Braviary, and Hisuian Braviary flooding logs with errors about missing sound events.
 
 ### Developer
-- Added `PokeSnackSpawnerFactory` which allows influence registration on PokeSnack encounters
-- Added `FishingSpawnerFactory` which allows influence registration on fishing encounters
-- Added `BattleFleeAttemptEvent` fired from `PokemonBattle.checkFleeAttempt`, allowing developers to intercept and control flee attempts
-- Tweaked the spawning selector interface to take a bucket function rather than a bucket directly.
-- Added a new `cobblemon:height_range` processor type to allow developers to restrict structure-spawning ranges.
-- Separated all the functions of MoLangFunctions.kt into their own files.
-- Spawn buckets and their base weights are now provided by the spawner, with different base weights for world, fishing, snack, and habitat spawn buckets.
-- Removed "SpawnBucket" class in favour of just storing maps of bucket names to weights.
-- Fixed nicknames not being applied to Pokémon spawned from `spawn_pool_world` files.
-- Added support for `profilePokedexScale`, `profilePokedexTranslation`, `profileSummaryScale`, and `profileSummaryTranslation` in poser files for finer control over profile displays.
-- Fixed riding camera offsets defined on Pokémon forms not being applied
 
 ### Molang & Datapacks
-- Added `moveset_builders` datapack folder for different styles of movesets.
-- Added `party_pools` datapack folder for defining groups of Pokémon for complex NPC party definitions.
-- Added `party_compositions` datapack folder for arranging parties on NPCs that rely on party pools.
-- Added `composed_pool` NPC party provider type which combines a party pool with a party composition to create more complex NPC parties.
-- Added basic chatter NPC Behaviour
-- Added `q.item.is_enchanted()`
-- Added `q.item.has_enchantment(minecraft:sharpness, 3)`
-- Added `has_chosen_starter` & `get_starter_uuid` as available Molang functions
-- Added `has_tm_move_unlocked`, `unlock_tm_move`, & `lock_tm_move` as available Molang functions for Players
-- Added `marks`, `has_mark`, & `remove_marks` as available Molang functions for Pokémon
-- Added Data Component support for species drops, eg `"components": {"minecraft:custom_model_data": 123}`
-- Added the new `sortOrder` field to mark entries, (defaults to 0 if not specified) which controls the order in which marks are rendered on the HUD, with higher numbers being rendered on top of lower numbers
-- Added optional `order` field to starter categories. It will allow explicitly sorting categories in the starter selection screen
-- SpeciesAdditions append vs override now matches wiki documentation
-- Added `weighted_choice` as a new feature type. It requires setting weights for each choice and allows developers to simplify the process of assigning random aspect choice based on marble chance
-- Added `q.world.spawn_loot_table_items(loot_table_id, x, y, z)` which spawns the items from the loot table at the position. (Use type: "minecraft:chest" for the loot table.)
-- Added `q.pokemon.entity` to access the entity of Pokémon.
-- Flamethrower and Seismic Toss had their action effect JSON cleaned up
-- Ride sounds can now be set as exclusive to passengers
-- Ride sounds no longer play when submerged unless specified with a new setting
-- NPC Trainers can now call a `command` animation when issuing a command in battle.
-- Added a q.failed function to move action effects.
-- Herd spawned Pokémon have their levels controlled differently. The `levelRange` property now acts as a clamp instead of a filter, with a new `herdLevelRange` property to do the filter behaviour.
-- `q.sound` now accepts three parameters (sound event, volume and pitch) instead of just the sound event and pitch.
-- Added a new layer property that makes a layer scroll in a direction. "scrolling": {"speedU": 0.1, "speedV": 0.1}
 
 ### Particles
 
-#### New Move Animations
-- Blizzard
-- Disarming Voice
-- Draco Meteor
-- Dragon Breath
-- Dragon Rage
-- Drain Punch
-- Fairy Wind
-- Fire Fang
-- Gust
-- Horn Drill
-- Hydro Pump
-- Ice Fang
-- Leafage
-- Leaf Storm
-- Light Screen
-- Night Shade
-- Play Rough
-- Pyro Ball
-- Reflect
-- Rock Slide
-- Sonic Boom
-- Sucker Punch
-- Supersonic
-- Thunder Fang
-
-#### Tweaks and Fixes (Moves)
-
-- Confusion
-- Dragon Claw
-- Eruption
-- Fire Punch
-- Flame Burst
-- Flame Charge
-- Flamethrower
-- Frost Breath
-- Hypnosis
-- Ice Punch
-- Icy Wind
-- Mud Sport
-- Poison Fang
-- Protect
-- Psychic
-- Quick Attack
-- Rage Powder
-- Razor Leaf
-- Sand Attack
-- Scratch
-- Shadow Claw
-- Sing
-- Spore
-- String Shot
-- Tackle
-- Tail Whip
-- Thunder
-- Thunder Punch
-- Thunder Wave
-- Water Gun
-- Water Pulse
-- Water Sport
-
-#### Miscellaneous Particles
-
-+ Added Wild Might particles for Alpha Pokémon
-+ Updated stat increase and decrease particles
-
 ### Localization
-- Updated translations for:
-  - Japanese
-  - German
-  - Spanish
-  - Ecuadorian Spanish
-  - Portuguese
-  - Brazilian Portuguese
-  - Simplified Chinese
-  - Traditional Chinese
-  - Korean
-  - Russian
+- Updated translations for:

changelogs/CHANGELOG-1.8.0.md

@@ -0,0 +1,529 @@
+# Changelog
+## [1.8.0 - Make Your Move Update (September 6th, 2026)](#1-8-0)
+#### I think the red eyes mean they're friendly!
+
+### Additions
+- Added Alpha Pokémon
+    - Alpha Pokémon are bigger, stronger, and more aggressive than regular Pokémon.
+    - They are also scarier.
+    - They always know a TM move and will adapt to be stronger than your party.
+    - Alphas will always lead herds and spawn in herds.
+- Added alpha Pokémon attraction bait effect to Hopo Berries.
+- Added intrinsic scaling to all Pokémon (anywhere from 5% smaller to 5% bigger than normal). Some cases, such as shoulder mounting, will not scale so that the shoulder animations don't look silly.
+- Added scaling to "baby" Pokémon (10% smaller at level 1 → normally sized at level 10).
+- Added TMs.
+    - Added TM Machine. TMs are made from elemental type gems, and their recipes are unlocked by having Pokémon that know the move.
+    - Added config options for making TMs infinite-use and instant unlocking of all TM recipes.
+    - Added Type Gem blocks as well as crystal clusters and deepslate core blocks that are used for growing elemental type gems.
+- Added a new Starter Selection menu that looks way better.
+- Added a "Move Dex" to the Pokédex to help identify what moves a Pokémon can learn and what Pokémon can get a move.
+- Added the Habitat Block, a spawner block for servers and adventure maps that controls spawning in an area.
+- Added 49 new habitat structures. In these habitats you will find rarer Pokémon and sometimes different Pokémon will appear on different days.
+- Added a toast to notify players of how they can scroll through their party. Did you know you can hold R and scroll instead of using arrow keys? It's true!!!
+- Added a way to obtain Porygon by inserting an Upgrade or Dubious Disc into a data monitor.
+- Added Disk Rack for storing disks and being an audio sequencer for Noteblocks. What does that have to do with Pokémon? How about you mind your own business!
+- Added missing crops to Botany Pots integration.
+- Added conditional seats for riding. Seats can be gated by Molang such as "is_alpha".
+- Added 10 new ruin structures.
+- Added a new shipwreck cove structure called the Magma Shipwreck Cove.
+- Added 7 new advancements.
+- Pokémon cries now play when clicking Pokémon in the summary screen.
+- Held item visibility can now be controlled by the `held_item_visible` command argument.
+- Added config option to disable Pokémon spawning on a per-world basis.
+- Added config options to award experience to fainted Pokémon for opponents they helped defeat (`awardExperienceToFaintedPokemon`) and to still award experience for defeated enemies even after battle loss/forfeit (`awardExperienceOnBattleLoss`).
+- Added `/givetm` command.
+- Added advancement triggers for learning TMs: `cobblemon:has_learn_specific_tm` (per-TM), `cobblemon:has_learn_all_tm` (all TMs learned), and `cobblemon:tms_learned` (count-based), backed by a new `totalTMLearnedCount` on player advancement data.
+- Added `cobblemon:catch_alpha_pokemon` advancement trigger and `totalAlphaCaptureCount` stat for captured Alpha Pokémon.
+
+### New rideable Pokémon
+- Crobat
+- Skarmory
+- Milotic
+- Archeops
+- Goodra
+- Goodra (Hisuian Form)
+- Drampa
+- Duraludon
+- Archaludon
+
+### Pokémon Added
+#### Generation 3
+- Wurmple
+- Silcoon
+- Beautifly
+- Cascoon
+- Dustox
+- Skitty
+- Delcatty
+- Seviper
+- Zangoose
+
+#### Generation 4
+- Cherubi
+- Cherrim
+- Stunky
+- Skuntank
+
+#### Generation 5
+- Audino
+- Pawniard
+- Bisharp
+
+#### Generation 6
+- Pancham (+ Cosmetic with Black Glasses)
+- Pangoro (+ Cosmetic with Black Glasses)
+
+#### Generation 7
+- Rockruff
+- Lycanroc
+
+#### Generation 8
+- Rolycoly
+- Carkol
+- Coalossal
+- Runerigus
+- Snom
+- Frosmoth
+- Indeedee
+- Duraludon
+- Applin
+- Flapple
+- Appletun
+
+#### Generation 9
+
+- Nymble
+- Lokix
+- Kingambit
+- Dipplin
+- Archaludon
+- Hydrapple
+
+#### Regional Forms
+- Sandshrew (Alolan Form)
+- Sandslash (Alolan Form)
+- Yamask (Galarian Form)
+- Avalugg (Hisuian Form)
+
+### Model updates for the following Pokémon
+
+- Sandshrew
+- Sandslash
+- Nidoking
+- Zubat
+- Golbat
+- Crobat
+- Ditto
+- Porygon
+- Porygon2
+- Porygon-Z
+- Skarmory
+- Smoochum
+- Jynx
+- Popplio
+- Brionne
+- Primarina
+- Fletchling
+- Fletchinder
+- Talonflame
+- Sableye
+- Mawile
+- Goomy
+- Sliggoo
+- Goodra
+- Nacli
+- Naclstack
+- Garganacl
+- Bidoof
+- Cranidos
+- Chatot
+- Yamask
+- Cofagrigus
+- Tyranitar
+- Turtonator
+- Golett
+- Corsola
+- Arbok (New Patterns: Angry, Cartoon, Clown, Comedic, Crow, Grin, Ink, Modern, Rain, Scribble, Silence, Sloth, Suspicious, Will)
+- ... and Substitute
+
+#### Model changes to the regional bias resource pack:
+- Added Mime Jr. (Galar Bias)
+- Added Bergmite (Hisui Bias)
+- Changed models for every existing regional bias
+
+### Animation updates for the following Pokémon
+
+- Kakuna
+- Grimer
+- Nidoran♀ (+ New shoulder mount)
+- Nidorina
+- Nidoran♂ (+ New shoulder mount)
+- Sandshrew
+- Diglett
+- Dugtrio
+- Graveler
+- Happiny
+- Chansey
+- Blissey
+- Poliwhirl
+- Poliwrath
+- Zubat
+- Vulpix
+- Drowzee
+- Hypno
+- Noctowl
+- Skarmory
+- Skitty
+- Flygon
+- Shellos
+- Riolu
+- Lucario
+- Purrloin
+- Liepard
+- Joltik
+- Galvantula
+- Nidoking
+- Fletchling
+- Fletchinder
+- Talonflame
+- Archeops
+- Drampa
+- Sewaddle
+- Swadloon
+- Leavanny
+- Goomy
+- Sliggoo
+- Goodra
+- Shedinja
+- Skwovet
+- Greedent
+- Bidoof
+- Cranidos
+- Chatot
+- Yamask
+- Cofagrigus
+- Luvdisc
+- Staryu
+- Starmie
+- Togetic
+- Rellor
+- Rabsca
+- Yungoos
+- Gumshoos
+- Cottonee
+- Whimsicott
+- Corsola
+
+#### Added sounds to the following moves
+
+- Absorb
+- Aurora Beam
+- Double Team
+- Draco Meteor
+- Fire Punch
+- Fire Spin
+- Flame Charge
+- Flame Wheel
+- Giga Drain
+- Ice Punch
+- Leech Life
+- Magical Leaf
+- Mega Drain
+- Minimize
+- Poison Gas
+- Rock Throw
+- Scary Face
+- Seed bomb
+- Smokescreen
+- String Shot
+- Tail Whip
+
+### Changes
+- Removed the penalty for block destruction speed when on a hover mount, making them better for digging.
+- Golden Apples can now be crafted using the Applin Apples.
+- Prismarine Crystals and Amethyst Shards can now be used to craft Pokedexes.
+- Updated Pokédex Screens item tag to support tagged variants of Redstone and Glowstone Dust.
+- Sharp Beak can now be crafted using bones and Flying Gems.
+- Metal Alloy can now be crafted using iron and Thunder Stones.
+- Ability Capsules can now be brewed from Medicinal Brew and Dragon Breath.
+- Using an Ability Capsule will now return an Empty Bottle.
+- Decreased the default pastured wander radius to 32 blocks.
+- Added alternate versions of the basic PC Wallpapers based on the original design of Cobblemon's PC, before public release.
+- Rooted Arch Ruins, Crumbling Arch Ruins, and all fossil structures have been improved so that they generate more naturally in terrain.
+- Gimmighoul towers now generate at ground-level rather than sinking one block into the ground.
+- All ruin structures that did not generate with a gimmighoul/gilded chest before will now generate with one.
+- All ruin structures gilded chest loot tables have been updated to include a guaranteed TM not learned naturally by any Pokémon through their level-up moveset. Each ruin gets its own specific TM, so you can now go hunting ruins to complete your move dex!
+- The Prehistoric Underwater Fissure and Prehistoric Submerged Impact fossil structures now use the biome tag `#cobblemon:is_temperate_ocean`.
+- The lush shipwreck cove's phantom mob spawner has been replaced with breezes.
+- Shipwreck coves now generate slightly more frequently.
+- Added equipment loot tables for shipwreck cove enemies.
+- Maps from abandoned fishing boats leading to shipwreck coves now will skip explored chunks, allowing the player to find more shipwreck coves more easily.
+- All shipwreck coves' spawners have been adjusted to give compatible mobs enchanted iron or diamond armour and weapons while in its ominous state. The armour given to the mobs will also use the automaton trim. We upped the difficulty because it was too easy now that your Pokémon can fight for you.
+- One TM of the elemental hyper beams has been added as guaranteed loot to the main treasure chest in every shipwreck cove. (Magma Cove gets Blast Burn, Lush Cove gets Frenzy Plant, and Submerged Cove gets Hydro Cannon.)
+- The following items can now be obtained by brushing the following Pokémon:
+    - Pink Wool - Wigglytuff
+    - White Wool - Swablu, Altaria
+    - Shed Shell - Ekans, Arbok, Dratini, Dragonair, Dunsparce, Treecko, Grovyle, Sceptile, Seviper, Scraggy, Scrafty, Helioptile, Heliolisk, Salandit, Salazzle, Sobble, Drizzile, Inteleon, Silicoblra, Sandaconda, Toxel, Toxtricity, Orthworm, Dudunsparce
+    - Phantom Membrane - Dreepy, Drakloak, Dragapult
+- The following items can now be obtained by evolving the following Pokémon into any of their evolutions:
+    - Turtle Scute - Squirtle, Wartortle, Turtwig, Grotle, Tirtouga, Chewtle
+    - Shed Shell - Metapod, Kakuna, Ekans, Paras, Venonat, Krabby, Scyther, Kabuto, Dratini, Dragonair, Ledyba, Spinarak, Yanma, Pineco, Dunsparce, GLigar, Pupitar, Treecko, Grovyle, Silcoon, Cascoon, Surskit, Nincada, Trapinch, Vibrava, Corphish, Anorith, Bagon, Shelgon, Kricketot, Burmy, Combee, Skorupi, Swadloon, Whirlipede, Dwebble, Scraggy, Karrablast, Joltik, Larvesta, Spewpa, Clauncher, Helioptile, Charjabug, Crabrawler, Cutiefly, Dewpider, Salandit, Wimpod, Poipole, Sobble, Drizzile, Dottler, Silicobra, Toxel, Sizzlipede, Snom, Tarountula, Nymble, Rellor
+- Saccharine Leaves now drop Tart, Sweet, or Syrupy Apples, depending on their honey coating stage, instead of vanilla Apples.
+- Fixed the height of the Tumblestone Bud items when held in hand, placed on head, viewed in a GUI, and placed in an Item Frame.
+- Refactored all advancements, removing several deemed unnecessary. Due to this cleanup, all previously obtained advancements will be reset besides the root (for picking a starter Pokémon). This sucks, and we're sorry. We had to do this eventually so better now than later.
+- Forces between colliding hitboxes now factors in the weight of Pokémon.
+- Improved berry tree performance on singleplayer and servers.
+- Updated stat increase and decrease particle effects with the addition of alpha boost particles.
+- Improved the performance of pasture blocks on singleplayer and servers.
+- Changed the bait effects of the following items: (Vanilla) Sweet & Glow Berries, Golden & Enchanted Golden Apples (Cobblemon) Custap, Eggant, Hopo & Micle Berries, Sweet Hearts.
+- Wild Pokémon now reliably have at least one offensive move if they can have offensive moves at that level. No more free lunches with Pokémon that can't even hurt you.
+- Data Monitor can accept Disks (TMs, Music Disks, Upgrade, Dubious Disk, etc.) to change what's being displayed on the screen.
+- The party overlay's experience-gained animation now displays the amount of EXP the Pokémon gained.
+- Pressing the inventory key now closes the Pokémon interact wheel GUI.
+- Updated the sound for harvesting Apricorns.
+- Lowered the volume of harvesting berries.
+- Improved compatibility with various mods
+    - Farmer's Delight's cutting board can now be used to strip Apricorn and Saccharine's logs, or salvage their planks from various blocks. It can also separate their boats from chests.
+    - Farmer's Delight's cutting board can be used to get two white dye from Pep-Up Flowers and two magenta dye from Medicinal Leeks.
+    - Farmer's Delight's cutting board can separate Tumblestone Blocks back into Tumblestones.
+    - Farmer's Delight's cutting board can salvage Type Gems from their Gem Blocks.
+    - Farmer's Delight's Onions, Tomatoes, and Cabbages can be used to cook Open-Faced Sandwiches. Nature's Spirit's Olives also can be used.
+    - Farmer's Delight's cutting board can be used on Hearty Grains to obtain rice and straw, similarly to Farmer's Delight's Rice Panicles.
+    - Farmer's Delight's Apple Pies and Apple Ciders can now be made using Applin Apples, alongside the Vanilla counterpart.
+    - Amendments allows for cooking Leek and Potato Stew in a Cauldron.
+    - Any mods that utilise Moonlight's Soft Fluid system can store Leek and Potato Stew, Medicinal Brew, Antidote, Awakening, Burn Heal, Ice Heal, Paralyze Heal, Full Heal, Potion, Super Potion, Hyper Potion, Max Potion, Full Restore, Ability Capsules, Moomoo Milk, and Berry Juice in liquid form (such as Suplementaries' Jar or Goblet, or Cauldrons while using Amendments).
+    - Supplementaries' Hourglass can now use Bright Powder, Quick Powder, Metal Powder, Heal Powder, Silver Powder, and Remedy.
+    - Berry Trees are now compatible with the Planter properly
+    - Saccharine Way Signs (added by Supplementaries automagically) now use a premade texture to prevent odd visual issues.
+    - Supplementaries' Jar can now store various Cobblemon cookies, candies, and similar items.
+    - Some of Supplementaries' items have been added to the `#cobblemon:held/container_held_items` item tag, including sacks, safes, and lunch baskets.
+    - Experience Nuggets can be used in place of Sculk for making the EXP Candies if using Create.
+    - Rage Candy Bar has a Create Mixing recipe.
+    - All Cobblemon ores can now be crushed in Create's Crushing Wheels. All Gem and Tumblestone Clusters can be crushed for automatic, low return, gems.
+    - Hearty Grains can be milled like Farmer's Delight Rice Panicles if both Farmer's Delight and Create are installed.
+    - Big Roots and Revival Herbs can be milled to their respective powders.
+    - Pep-Up Flowers, Medicinal Leeks, and all 70 berries can be milled in Create's Millstone for additional dye drops.
+    - Auspicious Armour and Upgrades can be Haunted using Create's crafting systems.
+    - Applin Apples can be used to make Honeyed Apples in Create.
+- Sounds for interacting with various Cobblemon blocks now play from the centre of the block, rather than the corner. You probably didn't notice.
+- Dragonite's mailbag cosmetic can now also be obtained with a chest in the cosmetic slot.
+- Adjusted the walk speed for Croagunk and Aerodactyl.
+- The `/pc` command no longer plays PC activation sounds
+- Pressing the Summary key while either the starter selection or summary screen are open now closes those screens.
+- Ice type Pokémon are now immune to Packed Snow.
+- Added cobweb block slowness immunity for spider Pokémon
+
+### Fixes
+- Fixed rare Pokémon being far too likely to spawn multiple times in a single spawn cycle. The dev told me that the exact bug is too complicated to explain.
+- Fixed Omanyte and Omastar incorrectly using water animations on land.
+- Fixed Pokédex layout for genderless variations.
+- Fixed odd stacking behaviour with Poké Baits.
+- Fixed a compatibility issue with World Game Rules which caused some log spam in specific cases.
+- Fixed improper validation of Pokémon when performing a trade.
+- Fixed an issue where particles like beams can disappear when you don't see the beginning of the beam, or you look away.
+- Fixed Bedrock particle materials sometimes being incorrectly invisible from some sides.
+- Fixed an occasional crash on retrieving revived fossils.
+- Fixed brushing not working on Neoforge. Again.
+- Fixed braking not working for submarine-style mounts (whoops).
+- Fixed strafing not having the same friction as forward movement (funny whoops).
+- Fixed submarine-style mounts' surface-water animations not playing when supposed to.
+- Fixed submarine-style mounts' camera freaking out when looking up or down on the surface.
+- Fixed pastured Pokémon despawning and running away.
+- Fixed Apricorn trees crashing when other mods bonemeal them.
+- Fixed the issue that caused hover-style mounts without a ground style to be rendered useless upon touching the ground on a server.
+- Fixed horizontal and vertical collisions with hover-style mounts so they no longer accumulate or retain momentum.
+- Fixed NeoForge brewing stand unexpectedly crashing users when shift clicking items within its menu. Well, I suppose all crashes are unexpected. You know what I mean.
+- Fixed NPCs switching Pokémon very often during battles.
+- Fixed Campfire Pot causing crashes under certain circumstances.
+- Fixed Type Gems not being consumed upon use in battles.
+- Fixed several Ancient Pokéball's not using the correct capture multiplier.
+- Fixed a server warning that could occur when recalling Pokémon.
+- Fixed sliding particles incorrectly handling block collision.
+- Fixed Full Heal not curing status conditions in battle. Literally it's one job.
+- Fixed a rare issue with battles locking up when you are forced to switch, with the switch menu appearing instantly.
+- Fixed the combined effects of Pledge moves having broken Showdown message handling and localisation.
+- Fixed a very niche issue where structures would spawn in an incorrect location, creating very funky world gen.
+- Fixed Galarian Ponyta missing its cry.
+- Fixed various log warnings caused by redundant files and sound events.
+- Traded Pokémon will now retain the original friendship level when traded back to its OT.
+- Tumblestone Clusters now display correctly on maps.
+- Fixed removing mulch from berry trees with a shovel not working. That was meant to be a thing.
+- Fixed collecting honey from Saccharine Leaf blocks deleting Honey Bottles when the inventory was full.
+- Fixed Stripped Saccharine Wood recipe being... not there.
+- Fixed some performance issues with a kind of sound event causing lag by attempting to create sounds every tick when out of range of hearing.
+- Fixed stat-reducing Aprijuice not being possible to apply on a maxed out Pokémon. Also fixed the possibility of going into negatives.
+- Fixed exploit where you could take out the bait or drop your Pokérod with bait to avoid consuming bait, now the bobber will just disappear if you do so.
+- Fixed Apricorn and Saccharine boats incorrectly using chest boat models.
+- Fixed wild and trainer battle AI refusing to select moves with the `adjacentAlly` target type, even when it's their only option.
+- Fixed gilded chests being more accessible than intended.
+- Fixed fished up Pokémon not being added as "seen" to the Pokédex.
+- Fixed surprised Gimmighoul encounters not being added as "seen" to the Pokédex.
+- Fixed a crash involving berry trees that have been world edited.
+- Fixed visual desync in multiplayer for players mounting Pokémon outside other players' loaded chunks.
+- Fixed Pokémon entities leveled by rare candy not getting stronger as Minecraft entities unless recalled.
+- Fixed a freeze during game load that occurred when multiple mods tried to load Cobblemon API classes at the same time.
+- Lowered the volume of Blitzle and Zebstrika's cry (shut up!).
+- Regional Foods will now prioritise being eaten instead of used for healing Pokémon - shift clicking will use it as healing.
+- Resolved z-fighting (texture flickering) on Pokédex Models.
+- Restored Ninjask's ability to do barrel rolls.
+- Fixed Raichu (male) and Alolan Raichu (both genders) not displaying the correct Partner Cap when Pewter Crunchies are in the cosmetic slot.
+- Fixed a crash caused by adding enchanted items to the Resurrection Machine.
+- Fixed a crash that could occur when starting a PvN battle with only fainted Pokémon.
+- Fixed the Remember Riding Camera config not being respected when dismounting and resolved the incompatibility with the Auto Third Person mod.
+- Fixed Full Heal block not dropping Full Heals. Lmao.
+- Fixed status cure items not returning an empty bottle when used.
+- Fixed Panpour consuming its held item when evolving with a Water Stone.
+- Fixed Smoked Tail Curry returning a Wooden Bowl when consumed despite it not being included in the recipe. Free bowls!
+- Fixed `/giveallpokemon` not respecting the min and max arguments.
+- Fixed the choose starter toast not disappearing when capturing a Pokémon instead of opening the starter selection screen.
+- Fixed an issue where certain Sinister Tea seasonings were only applying as instant effects and would not apply over time.
+- Long config option labels now scroll instead of overflowing in the configuration menu.
+- Fixed some z-fighting and clipping on Dewott and Hisui-Bias Dewott.
+- Eggant Berries can now be composted properly on NeoForge.
+- Composting chances are now the same on NeoForge as on Fabric.
+- Fixed problem where furnaces which had smelted Revival Herbs into Heal Powder in older versions would glitch out on trying to get the experience out of the block.
+- Fixed the Battle AI not recognizing Surging Strikes as a multistrike move.
+- Fixed Tentacool not using its swim animation when on water surface.
+- Fixed Eevee using its left shoulder pose when in battle.
+- Fixed Magikarp and Gyarados Jump Pattern resourcepacks replacing shiny textures of addons targeting Magikarp or Gyarados.
+- Fixed Combee's pollinated texture overwriting the shiny and female textures.
+- Fixed a colour mistake with Dracovish's shiny.
+- Fixed Togedemaru's back spikes z-fighting.
+- Fixed Sliggoo (+ Hisuian) evolving in the Nether and End where it can't actually rain.
+- Corrected the scales, hitbox sizes, and eye heights for Ariados, Cetoddle, Durant, Galvantula, Klink, Lanturn, Lumineon, Mantine, Mantyke, Mudbray, Numel, Staravia, and Torkoal.
+- Fixed Torkoal's walk speed not matching its animation. He will no longer move faster than Bunnelby and Buneary. This tortoise would've won.
+- Fixed Lanturn T-posing due to missing ground walk and sleep animations.
+- Fixed Oshawott and Dewott using their sleep animation in unintended scenarios.
+- Fixed Dudunsparce and Maushold always having the same form instead of having the 1 in 100 chance of being different.
+- Fixed bird mounts rapidly switching between their flying and gliding animations when flying at low speed.
+- Fixed some battles being startable with fainted Pokémon in the initial sendout.
+- Fixed random gender selection for forms with strict gender divides (such as Meowstic and Oinkologne) never choosing female (that's sexist).
+- Fixed the "Press R to battle" prompt not disappearing after you finish your first battle, at least until you relogged.
+- Fixed the composter block being listed as "composer" in the cosmetic items species feature
+- Fixed Castform's forms being tagged as introduced in generation 4 instead of 3.
+- Fixed Blitzle's base scale being `1` rather than the intended `0.8`.
+- Fixed Magnezone's emissive layer for the shiny having the wrong name, thus displaying wrongly.
+- Fixed Litleo not blinking.
+
+### Developer
+- Added `PokeSnackSpawnerFactory` which allows influence registration on PokeSnack encounters.
+- Added `FishingSpawnerFactory` which allows influence registration on fishing encounters.
+- Added `BattleFleeAttemptEvent` fired from `PokemonBattle.checkFleeAttempt`, allowing developers to intercept and control flee attempts.
+- Tweaked the spawning selector interface to take a bucket function rather than a bucket directly.
+- Added a new `cobblemon:height_range` processor type to allow developers to restrict structure-spawning ranges.
+- Separated all the functions of MoLangFunctions.kt into their own files.
+- Spawn buckets and their base weights are now provided by the spawner, with different base weights for world, fishing, snack, and habitat spawn buckets.
+- Removed "SpawnBucket" class in favour of just storing maps of bucket names to weights.
+- Fixed nicknames not being applied to Pokémon spawned from `spawn_pool_world` files.
+- Added support for `profilePokedexScale`, `profilePokedexTranslation`, `profileSummaryScale`, and `profileSummaryTranslation` in poser files for finer control over profile displays.
+- Fixed riding camera offsets defined on Pokémon forms not being applied.
+- Marks can now provide aspects.
+
+### Molang & Datapacks
+- Added `moveset_builders` datapack folder for different styles of movesets.
+- Added `party_pools` datapack folder for defining groups of Pokémon for complex NPC party definitions.
+- Added `party_compositions` datapack folder for arranging parties on NPCs that rely on party pools.
+- Added `composed_pool` NPC party provider type which combines a party pool with a party composition to create more complex NPC parties.
+- Added basic chatter NPC Behaviour.
+- Added `q.item.is_enchanted()`.
+- Added `q.item.has_enchantment(minecraft:sharpness, 3)`.
+- Added `has_chosen_starter` and `get_starter_uuid` as available Molang functions.
+- Added `has_tm_move_unlocked`, `unlock_tm_move`, and `lock_tm_move` as available Molang functions for Players.
+- Added `marks`, `has_mark`, and `remove_marks` as available Molang functions for Pokémon.
+- Added Data Component support for species drops, eg `"components": {"minecraft:custom_model_data": 123}`
+- Added the new `sortOrder` field to mark entries, (defaults to 0 if not specified) which controls the order in which marks are rendered on the HUD, with higher numbers being rendered on top of lower numbers.
+- Added optional `order` field to starter categories. It will allow explicitly sorting categories in the starter selection screen.
+- SpeciesAdditions append vs override now matches the wiki documentation.
+- Added `weighted_choice` as a new feature type. It requires setting weights for each choice and allows developers to simplify the process of assigning random aspect choice based on marble chance.
+- Added `q.world.spawn_loot_table_items(loot_table_id, x, y, z)` which spawns the items from the loot table at the position. Use type: `minecraft:chest` for the loot table.
+- Added `q.pokemon.entity` to access the entity of Pokémon.
+- Flamethrower and Seismic Toss had their action effect JSON cleaned up.
+- Ride sounds can now be set as exclusive to passengers.
+- Ride sounds no longer play when submerged unless specified with a new setting.
+- NPC Trainers can now call a `command` animation when issuing a command in battle.
+- Added a q.failed function to move action effects.
+- Herd spawned Pokémon have their levels controlled differently. The `levelRange` property now acts as a pre-offset clamp instead of a filter, with a new `herdLevelRange` property to do the filter behaviour.
+- `q.sound` now accepts three parameters (sound event, volume, and pitch) instead of just the sound event and pitch.
+- Added a new layer property that makes a layer scroll in a direction. "scrolling": {"speedU": 0.1, "speedV": 0.1}
+- Cleaned up seat data. Removed all now unused fields from seats in all species files. Also made locator seat names explicit in the species files (however, this doesn't break the legacy format)
+
+### Particles
+
+#### New Move Animations
+- Blizzard
+- Disarming Voice
+- Draco Meteor
+- Dragon Breath
+- Dragon Rage
+- Drain Punch
+- Fairy Wind
+- Fire Fang
+- Gust
+- Horn Drill
+- Hydro Pump
+- Ice Fang
+- Leafage
+- Leaf Storm
+- Light Screen
+- Night Shade
+- Play Rough
+- Pyro Ball
+- Reflect
+- Rock Slide
+- Sonic Boom
+- Sucker Punch
+- Supersonic
+- Thunder Fang
+
+#### Tweaks and Fixes (Moves)
+
+- Confusion
+- Dragon Claw
+- Eruption
+- Fire Punch
+- Flame Burst
+- Flame Charge
+- Flamethrower
+- Frost Breath
+- Hypnosis
+- Ice Punch
+- Icy Wind
+- Mud Sport
+- Poison Fang
+- Protect
+- Psychic
+- Quick Attack
+- Rage Powder
+- Razor Leaf
+- Sand Attack
+- Scratch
+- Shadow Claw
+- Sing
+- Spore
+- String Shot
+- Tackle
+- Tail Whip
+- Thunder
+- Thunder Punch
+- Thunder Wave
+- Water Gun
+- Water Pulse
+- Water Sport
+
+#### Miscellaneous Particles
+
+- Added Wild Might particles for Alpha Pokémon.
+- Updated stat increase and decrease particles.
+
+### Localization
+- Updated translations for:
+    - Japanese
+    - German
+    - Spanish
+    - Ecuadorian Spanish
+    - Portuguese
+    - Brazilian Portuguese
+    - Simplified Chinese
+    - Traditional Chinese
+    - Korean
+    - Russian

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/MoLangFunctions.kt

@@ -83,12 +83,6 @@ import net.minecraft.world.level.Level
 import net.minecraft.world.level.biome.Biome
 import net.minecraft.world.level.block.Block
 import net.minecraft.world.level.dimension.DimensionType
-import net.minecraft.world.level.levelgen.Heightmap
-import net.minecraft.world.level.pathfinder.PathType
-import net.minecraft.world.level.storage.loot.LootParams
-import net.minecraft.world.level.storage.loot.parameters.LootContextParamSets
-import net.minecraft.world.level.storage.loot.parameters.LootContextParams
-import net.minecraft.world.phys.AABB
 import net.minecraft.world.phys.Vec3
 import java.util.function.Function
 
@@ -99,25 +93,31 @@ import java.util.function.Function
  * @since October 2nd, 2023
  */
 object MoLangFunctions {
-    fun ItemStack.asMoLangValue(registryAccess: RegistryAccess) = ObjectValue(this)
-        .addStandardFunctions()
-        .addFunctions(ItemStackMoLangFunctions.attach(Pair(this, registryAccess)))
+    fun ItemStack.asMoLangValue(registryAccess: RegistryAccess) =
+        ObjectValue(this)
+            .addStandardFunctions()
+            .addFunctions(ItemStackMoLangFunctions.attach(Pair(this, registryAccess)))
 
-    fun Holder<Biome>.asBiomeMoLangValue() = asMoLangValue(Registries.BIOME)
-        .addFunctions(BiomeMoLangFunctions.attach(this))
+    fun Holder<Biome>.asBiomeMoLangValue() =
+        asMoLangValue(Registries.BIOME)
+            .addFunctions(BiomeMoLangFunctions.attach(this))
 
-    fun Holder<Level>.asWorldMoLangValue() = asMoLangValue(Registries.DIMENSION)
-        .addFunctions(WorldMoLangFunctions.attach(this))
+    fun Holder<Level>.asWorldMoLangValue() =
+        asMoLangValue(Registries.DIMENSION)
+            .addFunctions(WorldMoLangFunctions.attach(this))
 
-    fun Holder<Block>.asBlockMoLangValue() = asMoLangValue(Registries.BLOCK)
-        .addFunctions(BlockMoLangFunctions.attach(this))
+    fun Holder<Block>.asBlockMoLangValue() =
+        asMoLangValue(Registries.BLOCK)
+            .addFunctions(BlockMoLangFunctions.attach(this))
 
-    fun MinecraftServer.asMoLangValue() = ObjectValue(this)
-        .addStandardFunctions()
-        .addFunctions(ServerMoLangFunctions.attach(this))
+    fun MinecraftServer.asMoLangValue() =
+        ObjectValue(this)
+            .addStandardFunctions()
+            .addFunctions(ServerMoLangFunctions.attach(this))
 
-    fun Holder<DimensionType>.asDimensionTypeMoLangValue() = asMoLangValue(Registries.DIMENSION_TYPE)
-        .addFunctions(DimensionTypeMoLangFunctions.attach(this))
+    fun Holder<DimensionType>.asDimensionTypeMoLangValue() =
+        asMoLangValue(Registries.DIMENSION_TYPE)
+            .addFunctions(DimensionTypeMoLangFunctions.attach(this))
 
     fun Player.asMoLangValue(): ObjectValue<Player> {
         if (this is ServerPlayer && uuid in Cobblemon.serverPlayerStructs) {
@@ -129,10 +129,11 @@ object MoLangFunctions {
             }
         }
 
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.effectiveName().string }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.effectiveName().string },
+            )
 
         value.addFunctions(EntityMoLangFunctions.attach(this))
         value.addFunctions(LivingEntityMoLangFunctions.attach(this))
@@ -153,57 +154,63 @@ object MoLangFunctions {
     }
 
     fun PartyStore.asMoLangValue(): ObjectValue<PartyStore> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(PokemonStoreMoLangFunctions.attach(this))
         value.addFunctions(PartyMoLangFunctions.attach(this))
         return value
     }
 
     fun DropEntry.asMoLangValue(): ObjectValue<DropEntry> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(DropEntryMoLangFunctions.attach(this))
         return value
     }
 
     fun PokemonProperties.asMoLangValue(): ObjectValue<PokemonProperties> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.asString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.asString() },
+            )
         value.addFunctions(PokemonPropertiesMoLangFunctions.attach(this))
         return value
     }
 
     fun Evolution.asMoLangValue(): ObjectValue<Evolution> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(EvolutionMoLangFunctions.attach(this))
         return value
     }
 
     fun PCStore.asMoLangValue(): ObjectValue<PCStore> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(PokemonStoreMoLangFunctions.attach(this))
         value.addFunctions(PCMoLangFunctions.attach(this))
         return value
     }
 
     fun NPCEntity.asMoLangValue(): ObjectValue<NPCEntity> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.name.string }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.name.string },
+            )
         value.addFunctions(EntityMoLangFunctions.attach(this))
         value.addFunctions(LivingEntityMoLangFunctions.attach(this))
         value.addFunctions(NPCMoLangFunctions.attach(this))
@@ -211,10 +218,11 @@ object MoLangFunctions {
     }
 
     fun PokemonEntity.asMoLangValue(): ObjectValue<PokemonEntity> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.pokemon.uuid.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.pokemon.uuid.toString() },
+            )
 
         value.addFunctions(EntityMoLangFunctions.attach(this))
         value.addFunctions(LivingEntityMoLangFunctions.attach(this))
@@ -225,36 +233,40 @@ object MoLangFunctions {
     }
 
     fun PokemonBattle.asMoLangValue(): ObjectValue<PokemonBattle> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.battleId.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.battleId.toString() },
+            )
         value.addFunctions(BattleMoLangFunctions.attach(this))
         return value
     }
 
     fun BattleActor.asMoLangValue(): ObjectValue<BattleActor> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(BattleActorMoLangFunctions.attach(this))
         return value
     }
 
     fun SpawnablePosition.asMoLangValue(): ObjectValue<SpawnablePosition> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.toString() }
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = { it.toString() },
+            )
         value.addFunctions(SpawnablePositionMoLangFunctions.attach(this))
         return value
     }
 
     fun Vec3.asMoLangValue(): ObjectValue<Vec3> {
-        val value = ObjectValue(
-            obj = this
-        )
+        val value =
+            ObjectValue(
+                obj = this,
+            )
         value.addFunction("x") { this.x }
         value.addFunction("y") { this.y }
         value.addFunction("z") { this.z }
@@ -265,45 +277,66 @@ object MoLangFunctions {
     /**
      * Different functions exist depending on the entity type, this tries to make the struct that's most specific to the type.
      */
-    fun Entity.asMostSpecificMoLangValue(): ObjectValue<out Entity> {
-        return when (this) {
-            is Player -> asMoLangValue()
-            is PokemonEntity -> struct
-            is NPCEntity -> struct
-            is ItemEntity -> ObjectValue(this).also { item ->
-                item.addStandardFunctions()
-                item.addFunctions(EntityMoLangFunctions.attach(this))
-                item.addFunctions(ItemStackMoLangFunctions.attach(Pair(this.item, this.registryAccess())))
+    fun Entity.asMostSpecificMoLangValue(): ObjectValue<out Entity> =
+        when (this) {
+            is Player -> {
+                asMoLangValue()
             }
 
-            else -> ObjectValue(this).also { objectValue ->
-                objectValue.addStandardFunctions()
-                objectValue.addFunctions(EntityMoLangFunctions.attach(this))
-                if (this is LivingEntity) {
-                    objectValue.addFunctions(LivingEntityMoLangFunctions.attach(this))
+            is PokemonEntity -> {
+                struct
+            }
+
+            is NPCEntity -> {
+                struct
+            }
+
+            is ItemEntity -> {
+                ObjectValue(this).also { item ->
+                    item.addStandardFunctions()
+                    item.addFunctions(EntityMoLangFunctions.attach(this))
+                    item.addFunctions(ItemStackMoLangFunctions.attach(Pair(this.item, this.registryAccess())))
+                }
+            }
+
+            else -> {
+                ObjectValue(this).also { objectValue ->
+                    objectValue.addStandardFunctions()
+                    objectValue.addFunctions(EntityMoLangFunctions.attach(this))
+                    if (this is LivingEntity) {
+                        objectValue.addFunctions(LivingEntityMoLangFunctions.attach(this))
+                    }
                 }
             }
         }
-    }
 
     fun <T> Holder<T>.asMoLangValue(key: ResourceKey<Registry<T>>): ObjectValue<Holder<T>> {
-        val value = ObjectValue(
-            obj = this,
-            stringify = { it.unwrapKey().get().location().toString() }
-        )
-        value.functions["is_in"] = Function put@{ params: MoParams ->
-            val tag = TagKey.create(key, ResourceLocation.parse(params.getString(0).replace("#", "")))
-            return@put DoubleValue(if (value.obj.`is`(tag)) 1.0 else 0.0)
-        }
-        value.functions["is_of"] = Function put@{ params: MoParams ->
-            val identifier = ResourceLocation.parse(params.getString(0))
-            return@put DoubleValue(if (value.obj.`is`(identifier)) 1.0 else 0.0)
-        }
+        val value =
+            ObjectValue(
+                obj = this,
+                stringify = {
+                    it
+                        .unwrapKey()
+                        .get()
+                        .location()
+                        .toString()
+                },
+            )
+        value.functions["is_in"] =
+            Function put@{ params: MoParams ->
+                val tag = TagKey.create(key, ResourceLocation.parse(params.getString(0).replace("#", "")))
+                return@put DoubleValue(if (value.obj.`is`(tag)) 1.0 else 0.0)
+            }
+        value.functions["is_of"] =
+            Function put@{ params: MoParams ->
+                val identifier = ResourceLocation.parse(params.getString(0))
+                return@put DoubleValue(if (value.obj.`is`(identifier)) 1.0 else 0.0)
+            }
         return value
     }
 
     fun QueryStruct.addStandardFunctions(): QueryStruct {
-        addFunctions(GeneralMoLangFunctions.holder)
+        addFunctions(GeneralMoLangFunctions.functions)
         return this
     }
 
@@ -370,23 +403,17 @@ object MoLangFunctions {
         return this
     }
 
-    fun moLangFunctionMap(
-        vararg functions: Pair<String, (MoParams) -> MoValue>
-    ): Map<String, (MoParams) -> MoValue> {
-        return functions.toMap()
-    }
+    fun moLangFunctionMap(vararg functions: Pair<String, (MoParams) -> MoValue>): Map<String, (MoParams) -> MoValue> = functions.toMap()
 
-    fun queryStructOf(
-        vararg functions: Pair<String, (MoParams) -> MoValue>
-    ): QueryStruct {
-        return QueryStruct(
+    fun queryStructOf(vararg functions: Pair<String, (MoParams) -> MoValue>): QueryStruct =
+        QueryStruct(
             hashMapOf<String, Function<MoParams, Any>>(
-                *functions.map { (name, func) ->
-                    name to Function<MoParams, Any> { params -> func(params) }
-                }.toTypedArray()
-            )
+                *functions
+                    .map { (name, func) ->
+                        name to Function<MoParams, Any> { params -> func(params) }
+                    }.toTypedArray(),
+            ),
         )
-    }
 
     fun MoLangRuntime.setup(): MoLangRuntime {
         environment.query.addStandardFunctions()
@@ -395,8 +422,14 @@ object MoLangFunctions {
 
     fun writeMoValueToNBT(value: MoValue): Tag? {
         return when (value) {
-            is DoubleValue -> DoubleTag.valueOf(value.value)
-            is StringValue -> StringTag.valueOf(value.value)
+            is DoubleValue -> {
+                DoubleTag.valueOf(value.value)
+            }
+
+            is StringValue -> {
+                StringTag.valueOf(value.value)
+            }
+
             is ArrayStruct -> {
                 val list = value.map.values
                 val nbtList = ListTag()
@@ -413,14 +446,22 @@ object MoLangFunctions {
                 nbt
             }
 
-            else -> null
+            else -> {
+                null
+            }
         }
     }
 
-    fun readMoValueFromNBT(nbt: Tag): MoValue {
-        return when (nbt) {
-            is DoubleTag -> DoubleValue(nbt.asDouble)
-            is StringTag -> StringValue(nbt.asString)
+    fun readMoValueFromNBT(nbt: Tag): MoValue =
+        when (nbt) {
+            is DoubleTag -> {
+                DoubleValue(nbt.asDouble)
+            }
+
+            is StringTag -> {
+                StringValue(nbt.asString)
+            }
+
             is ListTag -> {
                 val array = ArrayStruct(hashMapOf())
                 var index = 0
@@ -441,11 +482,12 @@ object MoLangFunctions {
                 variable
             }
 
-            else -> VariableStruct()
+            else -> {
+                VariableStruct()
+            }
         }
-    }
 }
 
 // TODO: this one is unused. Should we move it to [MoLangFunctions] object?
 fun Either<ResourceLocation, ExpressionLike>.runScript(runtime: MoLangRuntime) =
-    map({ CobblemonScripts.run(it, runtime) }, { it.resolve(runtime) })
+    map({ CobblemonScripts.run(it, runtime) }, { it.resolve(runtime) })

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/BattleActorMoLangFunctions.kt

@@ -17,30 +17,29 @@ import com.cobblemon.mod.common.battles.actor.PlayerBattleActor
 import com.cobblemon.mod.common.battles.actor.PokemonBattleActor
 import com.cobblemon.mod.common.entity.npc.NPCBattleActor
 
-
 object BattleActorMoLangFunctions : AbstractMoLangFunctionHolder<BattleActor>() {
     override fun BattleActor.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val actor = this
-        val map = mutableMapOf<String, (MoParams) -> Any>(
-            "is_npc" to { DoubleValue(actor.type == ActorType.NPC) },
-            "is_player" to { DoubleValue(actor.type == ActorType.PLAYER) },
-            "is_wild" to { DoubleValue(actor.type == ActorType.WILD) }
-        )
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["is_npc"] = { DoubleValue(actor.type == ActorType.NPC) }
+        functions["is_player"] = { DoubleValue(actor.type == ActorType.PLAYER) }
+        functions["is_wild"] = { DoubleValue(actor.type == ActorType.WILD) }
 
         when (actor) {
             is NPCBattleActor -> {
-                map["npc"] = { actor.entity.struct }
+                functions["npc"] = { actor.entity.struct }
             }
 
             is PlayerBattleActor -> {
-                map["player"] = { actor.entity?.asMoLangValue() ?: DoubleValue.ZERO }
+                functions["player"] = { actor.entity?.asMoLangValue() ?: DoubleValue.ZERO }
             }
 
             is PokemonBattleActor -> {
-                map["pokemon"] = { actor.entity?.asMoLangValue() ?: DoubleValue.ZERO }
+                functions["pokemon"] = { actor.entity?.asMoLangValue() ?: DoubleValue.ZERO }
             }
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/BattleMessageMoLangFunctions.kt

@@ -16,17 +16,19 @@ import com.cobblemon.mod.common.util.getStringOrNull
 object BattleMessageMoLangFunctions : AbstractMoLangFunctionHolder<BattleMessage>() {
     override fun BattleMessage.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val battleMessage = this
-        return mutableMapOf(
-            "has_argument_at" to { params ->
-                val index = params.getInt(0)
-                val value = params.getStringOrNull(1) ?: ""
-                DoubleValue(value == battleMessage.argumentAt(index))
-            },
-            "has_argument" to { params ->
-                val argumentName = params.getString(0)
-                val value = params.getStringOrNull(1) ?: ""
-                DoubleValue(value == battleMessage.optionalArgument(argumentName))
-            }
-        )
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["has_argument_at"] = { params ->
+            val index = params.getInt(0)
+            val value = params.getStringOrNull(1) ?: ""
+            DoubleValue(value == battleMessage.argumentAt(index))
+        }
+        functions["has_argument"] = { params ->
+            val argumentName = params.getString(0)
+            val value = params.getStringOrNull(1) ?: ""
+            DoubleValue(value == battleMessage.optionalArgument(argumentName))
+        }
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/BattleMoLangFunctions.kt

@@ -18,20 +18,22 @@ import java.util.*
 object BattleMoLangFunctions : AbstractMoLangFunctionHolder<PokemonBattle>() {
     override fun PokemonBattle.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val battle = this
-        return mutableMapOf(
-            "environment" to { battle.runtime.environment },
-            "battle_id" to { StringValue(battle.battleId.toString()) },
-            "battle_type" to { StringValue(battle.format.toString()) },
-            "is_pvn" to { DoubleValue(battle.isPvN) },
-            "is_pvp" to { DoubleValue(battle.isPvP) },
-            "is_pvw" to { DoubleValue(battle.isPvW) },
-            "stop" to { battle.stop() },
-            "actors" to { battle.actors.toList().asArrayValue { it.struct } },
-            "get_actor" to getActor@{ params ->
-                val uuid = UUID.fromString(params.getString(0))
-                val actor = battle.actors.find { it.uuid == uuid } ?: return@getActor DoubleValue.ZERO
-                actor.struct
-            }
-        )
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["environment"] = { battle.runtime.environment }
+        functions["battle_id"] = { StringValue(battle.battleId.toString()) }
+        functions["battle_type"] = { StringValue(battle.format.toString()) }
+        functions["is_pvn"] = { DoubleValue(battle.isPvN) }
+        functions["is_pvp"] = { DoubleValue(battle.isPvP) }
+        functions["is_pvw"] = { DoubleValue(battle.isPvW) }
+        functions["stop"] = { battle.stop() }
+        functions["actors"] = { battle.actors.toList().asArrayValue { it.struct } }
+        functions["get_actor"] = getActor@{ params ->
+            val uuid = UUID.fromString(params.getString(0))
+            val actor = battle.actors.find { it.uuid == uuid } ?: return@getActor DoubleValue.ZERO
+            actor.struct
+        }
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/BiomeMoLangFunctions.kt

@@ -12,8 +12,11 @@ import com.bedrockk.molang.runtime.MoParams
 import net.minecraft.core.Holder
 import net.minecraft.world.level.biome.Biome
 
-object BiomeMoLangFunctions: AbstractMoLangFunctionHolder<Holder<Biome>>() {
+object BiomeMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Biome>>() {
     override fun Holder<Biome>.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
-        return mutableMapOf()
+        val biome = this
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/BlockMoLangFunctions.kt

@@ -12,8 +12,11 @@ import com.bedrockk.molang.runtime.MoParams
 import net.minecraft.core.Holder
 import net.minecraft.world.level.block.Block
 
-object BlockMoLangFunctions: AbstractMoLangFunctionHolder<Holder<Block>>() {
+object BlockMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Block>>() {
     override fun Holder<Block>.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
-        return mutableMapOf()
+        val block = this
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/DimensionTypeMoLangFunctions.kt

@@ -14,6 +14,9 @@ import net.minecraft.world.level.dimension.DimensionType
 
 object DimensionTypeMoLangFunctions : AbstractMoLangFunctionHolder<Holder<DimensionType>>() {
     override fun Holder<DimensionType>.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
-        return mutableMapOf()
+        val dimension = this
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/DropEntryMoLangFunctions.kt

@@ -18,15 +18,16 @@ import com.cobblemon.mod.common.util.getOrNull
 object DropEntryMoLangFunctions : AbstractMoLangFunctionHolder<DropEntry>() {
     override fun DropEntry.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val drop = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["percentage"] = { DoubleValue(drop.percentage.toDouble()) }
-        map["quantity"] = { DoubleValue(drop.quantity.toDouble()) }
-        map["max_selectable_times"] = { DoubleValue(drop.maxSelectableTimes.toDouble()) }
-        map["can_drop"] = { params ->
+        functions["percentage"] = { DoubleValue(drop.percentage.toDouble()) }
+        functions["quantity"] = { DoubleValue(drop.quantity.toDouble()) }
+        functions["max_selectable_times"] = { DoubleValue(drop.maxSelectableTimes.toDouble()) }
+        functions["can_drop"] = { params ->
             val pokemon = params.getOrNull<ObjectValue<Pokemon>>(0)?.obj
             DoubleValue(if (drop.canDrop(pokemon)) 1.0 else 0.0)
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/EntityMoLangFunctions.kt

@@ -56,258 +56,300 @@ import kotlin.math.sqrt
 
 object EntityMoLangFunctions : AbstractMoLangFunctionHolder<Entity>() {
     override fun Entity.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
-        val thisEntity = this
-        val map = mutableMapOf<String, (MoParams) -> Any>(
-            "uuid" to { StringValue(thisEntity.uuid.toString()) },
-            "name" to { _ -> StringValue(thisEntity.effectiveName().string) },
-            "yaw" to { _ -> DoubleValue(thisEntity.yRot.toDouble()) },
-            "pitch" to { _ -> DoubleValue(thisEntity.xRot.toDouble()) },
-            "x" to { _ -> DoubleValue(thisEntity.x) },
-            "y" to { _ -> DoubleValue(thisEntity.y) },
-            "z" to { _ -> DoubleValue(thisEntity.z) },
-            "velocity_x" to { _ -> DoubleValue(thisEntity.deltaMovement.x) },
-            "velocity_y" to { _ -> DoubleValue(thisEntity.deltaMovement.y) },
-            "velocity_z" to { _ -> DoubleValue(thisEntity.deltaMovement.z) },
-            "width" to { DoubleValue(thisEntity.boundingBox.xsize) },
-            "height" to { DoubleValue(thisEntity.boundingBox.ysize) },
-            "this_size" to { DoubleValue(thisEntity.boundingBox.run { if (xsize > ysize) xsize else ysize }) },
-            "this_width" to { DoubleValue(thisEntity.boundingBox.xsize) },
-            "this_height" to { DoubleValue(thisEntity.boundingBox.ysize) },
-            "id_modulo" to { params -> DoubleValue(thisEntity.uuid.hashCode() % params.getDouble(0)) },
-            "horizontal_velocity" to { _ -> DoubleValue(thisEntity.deltaMovement.horizontalDistance()) },
-            "vertical_velocity" to { DoubleValue(thisEntity.deltaMovement.y) },
-            "is_on_ground" to { _ -> DoubleValue(thisEntity.onGround()) },
-            "world" to { _ -> thisEntity.level().worldRegistry.wrapAsHolder(thisEntity.level()).asWorldMoLangValue() },
-            "biome" to { _ -> thisEntity.level().getBiome(thisEntity.blockPosition()).asBiomeMoLangValue() },
-            "is_passenger" to { DoubleValue(thisEntity.isPassenger) },
-            "discard" to { thisEntity.discard() },
-            "is_sneaking" to { _ -> DoubleValue(thisEntity.isShiftKeyDown) },
-            "is_sprinting" to { _ -> DoubleValue(thisEntity.isSprinting) },
-            "is_in_water" to { _ -> DoubleValue(thisEntity.isUnderWater) },
-            "is_in_rain" to { _ -> DoubleValue(thisEntity.isInWaterOrRain && !thisEntity.isInWater) },
-            "is_touching_water_or_rain" to { _ -> DoubleValue(thisEntity.isInWaterRainOrBubble) },
-            "is_touching_water" to { _ -> DoubleValue(thisEntity.isInWater) },
-            "is_underwater" to { DoubleValue(thisEntity.getIsSubmerged()) },
-            "is_in_lava" to { _ -> DoubleValue(thisEntity.isInLava) },
-            "is_on_fire" to { _ -> DoubleValue(thisEntity.isOnFire) },
-            "is_invisible" to { _ -> DoubleValue(thisEntity.isInvisible) },
-            "is_riding" to { _ -> DoubleValue(thisEntity.isPassenger) },
-            "set_name" to { params ->
-                val name = params.getString(0)
-                thisEntity.customName = name.text()
-                DoubleValue.ONE
-            },
-            "damage" to { params ->
-                val amount = params.getDouble(0)
-                val source = DamageSource(
-                    thisEntity.level().registryAccess().registryOrThrow(Registries.DAMAGE_TYPE)
-                        .getHolder(DamageTypes.GENERIC).get()
+        val entity = this
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["uuid"] = { StringValue(entity.uuid.toString()) }
+        functions["name"] = { StringValue(entity.effectiveName().string) }
+        functions["yaw"] = { DoubleValue(entity.yRot.toDouble()) }
+        functions["pitch"] = { DoubleValue(entity.xRot.toDouble()) }
+        functions["x"] = { DoubleValue(entity.x) }
+        functions["y"] = { DoubleValue(entity.y) }
+        functions["z"] = { DoubleValue(entity.z) }
+        functions["velocity_x"] = { DoubleValue(entity.deltaMovement.x) }
+        functions["velocity_y"] = { DoubleValue(entity.deltaMovement.y) }
+        functions["velocity_z"] = { DoubleValue(entity.deltaMovement.z) }
+        functions["width"] = { DoubleValue(entity.boundingBox.xsize) }
+        functions["height"] = { DoubleValue(entity.boundingBox.ysize) }
+        functions["this_size"] = { DoubleValue(entity.boundingBox.run { if (xsize > ysize) xsize else ysize }) }
+        functions["this_width"] = { DoubleValue(entity.boundingBox.xsize) }
+        functions["this_height"] = { DoubleValue(entity.boundingBox.ysize) }
+        functions["id_modulo"] = { params -> DoubleValue(entity.uuid.hashCode() % params.getDouble(0)) }
+        functions["horizontal_velocity"] = { DoubleValue(entity.deltaMovement.horizontalDistance()) }
+        functions["vertical_velocity"] = { DoubleValue(entity.deltaMovement.y) }
+        functions["is_on_ground"] = { DoubleValue(entity.onGround()) }
+        functions["world"] = {
+            entity
+                .level()
+                .worldRegistry
+                .wrapAsHolder(entity.level())
+                .asWorldMoLangValue()
+        }
+        functions["biome"] = { entity.level().getBiome(entity.blockPosition()).asBiomeMoLangValue() }
+        functions["is_passenger"] = { DoubleValue(entity.isPassenger) }
+        functions["discard"] = { entity.discard() }
+        functions["is_sneaking"] = { DoubleValue(entity.isShiftKeyDown) }
+        functions["is_sprinting"] = { DoubleValue(entity.isSprinting) }
+        functions["is_in_water"] = { DoubleValue(entity.isUnderWater) }
+        functions["is_in_rain"] = { DoubleValue(entity.isInWaterOrRain && !entity.isInWater) }
+        functions["is_touching_water_or_rain"] = { DoubleValue(entity.isInWaterRainOrBubble) }
+        functions["is_touching_water"] = { DoubleValue(entity.isInWater) }
+        functions["is_underwater"] = { DoubleValue(entity.getIsSubmerged()) }
+        functions["is_in_lava"] = { DoubleValue(entity.isInLava) }
+        functions["is_on_fire"] = { DoubleValue(entity.isOnFire) }
+        functions["is_invisible"] = { DoubleValue(entity.isInvisible) }
+        functions["is_riding"] = { DoubleValue(entity.isPassenger) }
+        functions["set_name"] = { params ->
+            val name = params.getString(0)
+            entity.customName = name.text()
+            DoubleValue.ONE
+        }
+        functions["damage"] = { params ->
+            val amount = params.getDouble(0)
+            val source =
+                DamageSource(
+                    entity
+                        .level()
+                        .registryAccess()
+                        .registryOrThrow(Registries.DAMAGE_TYPE)
+                        .getHolder(DamageTypes.GENERIC)
+                        .get(),
                 )
-                thisEntity.hurt(source, amount.toFloat())
-            },
-            "distance_to_owner" to distanceToOwner@{
-                if (thisEntity !is TamableAnimal) {
-                    return@distanceToOwner DoubleValue.ZERO
-                }
-                val owner = thisEntity.owner ?: return@distanceToOwner DoubleValue.ZERO
-                DoubleValue(thisEntity.distanceTo(owner))
-            },
-            "owner" to owner@{
-                if (thisEntity !is TamableAnimal) return@owner DoubleValue.ZERO
-                val owner = thisEntity.owner
-                owner?.asMostSpecificMoLangValue() ?: DoubleValue.ZERO
-            },
-            "delta_movement" to {
-                listOf(thisEntity.deltaMovement.x, thisEntity.deltaMovement.y, thisEntity.deltaMovement.z)
-                    .asArrayValue(::DoubleValue)
-            },
-            "tags" to {
-                val tags = thisEntity.tags
-                val array = ArrayStruct(hashMapOf())
-                tags.forEachIndexed { index, tag -> array.setDirectly("$index", StringValue(tag)) }
-                array
-            },
-            "add_tag" to { params ->
-                val tag = params.getString(0)
-                thisEntity.addTag(tag)
-                DoubleValue.ONE
-            },
-            "remove_tag" to { params ->
-                val tag = params.getString(0)
-                thisEntity.removeTag(tag)
-                DoubleValue.ONE
-            },
-            "has_tag" to { params ->
-                val tag = params.getString(0)
-                DoubleValue(thisEntity.tags.contains(tag))
-            },
-            "distance_to_pos" to { params ->
-                val x = params.getDouble(0)
-                val y = params.getDouble(1)
-                val z = params.getDouble(2)
-                DoubleValue(sqrt(thisEntity.distanceToSqr(Vec3(x, y, z))))
-            },
-            "type" to { _ ->
-                thisEntity.registryAccess().registry(Registries.ENTITY_TYPE).get().getKey(thisEntity.type)?.toString()?.let {
+            entity.hurt(source, amount.toFloat())
+        }
+        functions["distance_to_owner"] = distanceToOwner@{
+            if (entity !is TamableAnimal) {
+                return@distanceToOwner DoubleValue.ZERO
+            }
+            val owner = entity.owner ?: return@distanceToOwner DoubleValue.ZERO
+            DoubleValue(entity.distanceTo(owner))
+        }
+        functions["owner"] = owner@{
+            if (entity !is TamableAnimal) return@owner DoubleValue.ZERO
+            val owner = entity.owner
+            owner?.asMostSpecificMoLangValue() ?: DoubleValue.ZERO
+        }
+        functions["delta_movement"] = {
+            listOf(entity.deltaMovement.x, entity.deltaMovement.y, entity.deltaMovement.z)
+                .asArrayValue(::DoubleValue)
+        }
+        functions["tags"] = {
+            val tags = entity.tags
+            val array = ArrayStruct(hashMapOf())
+            tags.forEachIndexed { index, tag -> array.setDirectly("$index", StringValue(tag)) }
+            array
+        }
+        functions["add_tag"] = { params ->
+            val tag = params.getString(0)
+            entity.addTag(tag)
+            DoubleValue.ONE
+        }
+        functions["remove_tag"] = { params ->
+            val tag = params.getString(0)
+            entity.removeTag(tag)
+            DoubleValue.ONE
+        }
+        functions["has_tag"] = { params ->
+            val tag = params.getString(0)
+            DoubleValue(entity.tags.contains(tag))
+        }
+        functions["distance_to_pos"] = { params ->
+            val x = params.getDouble(0)
+            val y = params.getDouble(1)
+            val z = params.getDouble(2)
+            DoubleValue(sqrt(entity.distanceToSqr(Vec3(x, y, z))))
+        }
+        functions["type"] = {
+            entity
+                .registryAccess()
+                .registry(Registries.ENTITY_TYPE)
+                .get()
+                .getKey(entity.type)
+                ?.toString()
+                ?.let {
                     StringValue(it)
                 } ?: DoubleValue.ZERO
-            },
-            "find_nearby_block" to findNearbyBlock@{ params ->
-                val input = params.getString(0)
-                val isTag = input.contains("#")
-                val type = input.replace("#", "").asIdentifierDefaultingNamespace(namespace = "minecraft")
-                val range = params.getDoubleOrNull(1) ?: 10
-                val blockPos = thisEntity.level().getBlockStatesWithPos(
-                    AABB.ofSize(
-                        thisEntity.position(),
-                        range.toDouble(),
-                        range.toDouble(),
-                        range.toDouble()
-                    )
-                )
-                    .filter { blockPosPair ->
+        }
+        functions["find_nearby_block"] = findNearbyBlock@{ params ->
+            val input = params.getString(0)
+            val isTag = input.contains("#")
+            val type = input.replace("#", "").asIdentifierDefaultingNamespace(namespace = "minecraft")
+            val range = params.getDoubleOrNull(1) ?: 10
+            val blockPos =
+                entity
+                    .level()
+                    .getBlockStatesWithPos(
+                        AABB.ofSize(
+                            entity.position(),
+                            range.toDouble(),
+                            range.toDouble(),
+                            range.toDouble(),
+                        ),
+                    ).filter { blockPosPair ->
                         blockPosPair.first.blockHolder.let {
-                            if (isTag) it.`is`(
-                                TagKey.create(
-                                    Registries.BLOCK,
-                                    type
+                            if (isTag) {
+                                it.`is`(
+                                    TagKey.create(
+                                        Registries.BLOCK,
+                                        type,
+                                    ),
                                 )
-                            ) else it.`is`(type)
+                            } else {
+                                it.`is`(type)
+                            }
                         }
-                    }
-                    .minByOrNull { it.second.distSqr(thisEntity.blockPosition()) }
+                    }.minByOrNull { it.second.distSqr(entity.blockPosition()) }
                     ?.second
-                if (blockPos != null) {
-                    return@findNearbyBlock ArrayStruct(
-                        mapOf(
-                            "0" to DoubleValue(blockPos.x),
-                            "1" to DoubleValue(blockPos.y),
-                            "2" to DoubleValue(blockPos.z)
-                        )
-                    )
-                }
-                return@findNearbyBlock DoubleValue.ZERO
-            },
-            "get_nearby_entities" to { params ->
-                val distance = params.getDouble(0)
-                val entities =
-                    thisEntity.level().getEntities(thisEntity, AABB.ofSize(thisEntity.position(), distance, distance, distance))
+            if (blockPos != null) {
+                return@findNearbyBlock ArrayStruct(
+                    mapOf(
+                        "0" to DoubleValue(blockPos.x),
+                        "1" to DoubleValue(blockPos.y),
+                        "2" to DoubleValue(blockPos.z),
+                    ),
+                )
+            }
+            return@findNearbyBlock DoubleValue.ZERO
+        }
+        functions["get_nearby_entities"] = { params ->
+            val distance = params.getDouble(0)
+            val entities =
+                entity
+                    .level()
+                    .getEntities(entity, AABB.ofSize(entity.position(), distance, distance, distance))
 
-                entities
-                    .filterIsInstance<Entity>()
-                    .map { it.asMostSpecificMoLangValue() }
-                    .asArrayValue()
-            },
-            "is_standing_on_blocks" to { params ->
-                val depth = params.getDouble(0).toInt()
-                val blockStrings: MutableSet<String> = mutableSetOf()
-                for (blockIndex in 1..<params.params.size) {
-                    blockStrings.add(params.getString(blockIndex))
-                }
+            entities
+                .filterIsInstance<Entity>()
+                .map { it.asMostSpecificMoLangValue() }
+                .asArrayValue()
+        }
+        functions["is_standing_on_blocks"] = { params ->
+            val depth = params.getDouble(0).toInt()
+            val blockStrings: MutableSet<String> = mutableSetOf()
+            for (blockIndex in 1..<params.params.size) {
+                blockStrings.add(params.getString(blockIndex))
+            }
 
-                if (thisEntity.isStandingOn(blockStrings, depth)) DoubleValue.ONE else DoubleValue.ZERO
-            },
+            if (entity.isStandingOn(blockStrings, depth)) DoubleValue.ONE else DoubleValue.ZERO
+        }
 
-            // q.entity.spawn_bedrock_particles(effect, locator, [player])
-            // sends to everyone nearby or just to the player if they're set.
-            // Locator is necessary even if unused on non-posables.
-            "spawn_bedrock_particles" to { params ->
-                val particle = params.getString(0).asResource()
-                val locator = params.getString(1)
-                val player = params.getOrNull<MoValue>(2)?.let {
+        // q.entity.spawn_bedrock_particles(effect, locator, [player])
+        // sends to everyone nearby or just to the player if they're set.
+        // Locator is necessary even if unused on non-posables.
+        functions["spawn_bedrock_particles"] = { params ->
+            val particle = params.getString(0).asResource()
+            val locator = params.getString(1)
+            val player =
+                params.getOrNull<MoValue>(2)?.let {
                     when (it) {
-                        is StringValue -> thisEntity.level().getPlayerByUUID(UUID.fromString(it.value))
+                        is StringValue -> entity.level().getPlayerByUUID(UUID.fromString(it.value))
                         is ObjectValue<*> -> it.obj
                         else -> null
                     }
                 } as? ServerPlayer
 
-                val packet = SpawnSnowstormEntityParticlePacket(particle, thisEntity.id, listOf(locator))
-                if (player == null) {
-                    packet.sendToPlayersAround(thisEntity.x, thisEntity.y, thisEntity.z, 64.0, thisEntity.level().dimension())
-                } else {
-                    packet.sendToPlayer(player)
-                }
-            },
-            "make_intangible" to { params ->
-                val intangible = params.getBooleanOrNull(0) ?: true
-                thisEntity.noPhysics = intangible
-                DoubleValue.ONE
+            val packet = SpawnSnowstormEntityParticlePacket(particle, entity.id, listOf(locator))
+            if (player == null) {
+                packet.sendToPlayersAround(
+                    entity.x,
+                    entity.y,
+                    entity.z,
+                    64.0,
+                    entity.level().dimension(),
+                )
+            } else {
+                packet.sendToPlayer(player)
             }
-        )
+        }
+        functions["make_intangible"] = { params ->
+            val intangible = params.getBooleanOrNull(0) ?: true
+            entity.noPhysics = intangible
+            DoubleValue.ONE
+        }
 
-
-        if (thisEntity is PosableEntity) {
-            map["play_animation"] = playAnimation@{ params ->
-                val animation = params.getString(0)
-                val packet = PlayPosableAnimationPacket(thisEntity.id, setOf(animation), emptyList())
-                val target = params.getStringOrNull(1)
-                if (target != null) {
-                    val targetPlayer = if (target.asUUID != null) {
-                        thisEntity.level().getPlayerByUUID(target.asUUID!!) as ServerPlayer
-                    } else if (thisEntity.level() is ServerLevel) {
-                        thisEntity.level().server!!.playerList.getPlayerByName(target)
+        when (entity) {
+            is PosableEntity -> {
+                functions["play_animation"] = playAnimation@{ params ->
+                    val animation = params.getString(0)
+                    val packet = PlayPosableAnimationPacket(entity.id, setOf(animation), emptyList())
+                    val target = params.getStringOrNull(1)
+                    if (target != null) {
+                        val targetPlayer =
+                            if (target.asUUID != null) {
+                                entity.level().getPlayerByUUID(target.asUUID!!) as ServerPlayer
+                            } else if (entity.level() is ServerLevel) {
+                                entity
+                                    .level()
+                                    .server!!
+                                    .playerList
+                                    .getPlayerByName(target)
+                            } else {
+                                null
+                            }
+                        if (targetPlayer != null) {
+                            packet.sendToPlayer(targetPlayer)
+                            return@playAnimation DoubleValue.ONE
+                        } else {
+                            return@playAnimation DoubleValue.ZERO
+                        }
                     } else {
-                        null
-                    }
-                    if (targetPlayer != null) {
-                        packet.sendToPlayer(targetPlayer)
+                        packet.sendToPlayersAround(
+                            entity.x,
+                            entity.y,
+                            entity.z,
+                            64.0,
+                            entity.level().dimension(),
+                        )
                         return@playAnimation DoubleValue.ONE
-                    } else {
-                        return@playAnimation DoubleValue.ZERO
                     }
-                } else {
-                    packet.sendToPlayersAround(thisEntity.x, thisEntity.y, thisEntity.z, 64.0, thisEntity.level().dimension())
-                    return@playAnimation DoubleValue.ONE
+                }
+
+                functions["face"] = { params ->
+                    ObjectValue(ReferenceDialogueFaceProvider(entity.id, params.getBooleanOrNull(0) != false))
                 }
             }
 
-            map["face"] = { params ->
-                ObjectValue(ReferenceDialogueFaceProvider(thisEntity.id, params.getBooleanOrNull(0) != false))
-
+            is Schedulable -> {
+                functions["run_molang_after"] = { params ->
+                    val expression = params.getString(0).asExpressionLike()
+                    val delayInSeconds = params.getDouble(1).toFloat()
+                    val runtime = MoLangRuntime()
+                    runtime.environment.cloneFrom(params.environment)
+                    entity.after(delayInSeconds) {
+                        runtime.resolve(expression)
+                    }
+                }
             }
-        }
 
-        if (thisEntity is Schedulable) {
-            map["run_molang_after"] = { params ->
-                val expression = params.getString(0).asExpressionLike()
-                val delayInSeconds = params.getDouble(1).toFloat()
-                val runtime = MoLangRuntime()
-                runtime.environment.cloneFrom(params.environment)
-                thisEntity.after(delayInSeconds) {
-                    runtime.resolve(expression)
+            is MoLangScriptingEntity -> {
+                functions["add_callback"] = { params ->
+                    val type = params.getString(0).asIdentifierDefaultingNamespace()
+                    val callback = params.getString(1).asIdentifierDefaultingNamespace()
+                    val allowDuplicates = params.getBooleanOrNull(2) ?: false
+                    entity.callbacks.addCallback(type, callback, allowDuplicates)
+                }
+                functions["remove_callback"] = { params ->
+                    val type = params.getString(0).asIdentifierDefaultingNamespace()
+                    val callback = params.getString(1).asIdentifierDefaultingNamespace()
+                    entity.callbacks.removeCallback(type, callback)
+                }
+                functions["has_callback"] = { params ->
+                    val type = params.getString(0).asIdentifierDefaultingNamespace()
+                    val callback = params.getString(1).asIdentifierDefaultingNamespace()
+                    DoubleValue(callback in (entity.callbacks[type] ?: emptySet()))
+                }
+                functions["clear_callbacks"] = { params ->
+                    val type = params.getStringOrNull(0)?.asIdentifierDefaultingNamespace()
+                    if (type != null) {
+                        entity.callbacks[type]?.clear()
+                    } else {
+                        entity.callbacks.clear()
+                    }
+                    DoubleValue.ONE
                 }
             }
         }
 
-        if (thisEntity is MoLangScriptingEntity) {
-            map["add_callback"] = { params ->
-                val type = params.getString(0).asIdentifierDefaultingNamespace()
-                val callback = params.getString(1).asIdentifierDefaultingNamespace()
-                val allowDuplicates = params.getBooleanOrNull(2) ?: false
-                thisEntity.callbacks.addCallback(type, callback, allowDuplicates)
-            }
-            map["remove_callback"] = { params ->
-                val type = params.getString(0).asIdentifierDefaultingNamespace()
-                val callback = params.getString(1).asIdentifierDefaultingNamespace()
-                thisEntity.callbacks.removeCallback(type, callback)
-            }
-            map["has_callback"] = { params ->
-                val type = params.getString(0).asIdentifierDefaultingNamespace()
-                val callback = params.getString(1).asIdentifierDefaultingNamespace()
-                DoubleValue(callback in (thisEntity.callbacks[type] ?: emptySet()))
-            }
-            map["clear_callbacks"] = { params ->
-                val type = params.getStringOrNull(0)?.asIdentifierDefaultingNamespace()
-                if (type != null) {
-                    thisEntity.callbacks[type]?.clear()
-                } else {
-                    thisEntity.callbacks.clear()
-                }
-                DoubleValue.ONE
-            }
-        }
-
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/EvolutionMoLangFunctions.kt

@@ -19,26 +19,26 @@ import com.cobblemon.mod.common.pokemon.evolution.variants.TradeEvolution
 object EvolutionMoLangFunctions : AbstractMoLangFunctionHolder<Evolution>() {
     override fun Evolution.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val evolution = this
-        val map = hashMapOf<String, (MoParams) -> Any>()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["result"] = { evolution.result.asMoLangValue() }
-        map["is_optional"] = { DoubleValue(evolution.optional) }
-        map["consumes_held_item"] = { DoubleValue(evolution.consumeHeldItem) }
+        functions["result"] = { evolution.result.asMoLangValue() }
+        functions["is_optional"] = { DoubleValue(evolution.optional) }
+        functions["consumes_held_item"] = { DoubleValue(evolution.consumeHeldItem) }
 
         when (evolution) {
             is LevelUpEvolution -> {
-                map["is_level_up"] = { DoubleValue.ONE }
+                functions["is_level_up"] = { DoubleValue.ONE }
             }
 
             is TradeEvolution -> {
-                map["is_trade"] = { DoubleValue.ONE }
+                functions["is_trade"] = { DoubleValue.ONE }
             }
 
             is ItemInteractionEvolution -> {
-                map["is_item"] = { DoubleValue.ONE }
+                functions["is_item"] = { DoubleValue.ONE }
             }
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/GeneralMoLangFunctions.kt

@@ -42,101 +42,99 @@ import net.minecraft.world.item.ItemStack
 import java.text.ParseException
 
 object GeneralMoLangFunctions {
-    val holder: HashMap<String, (MoParams) -> Any> = hashMapOf(
-        "print" to { params ->
+    val functions: MutableMap<String, (MoParams) -> Any> = mutableMapOf()
+
+    init {
+        functions["print"] = { params ->
             val message = params.get<MoValue>(0).asString()
             LOGGER.info(message)
-        },
-        "delete_variable" to deleteVar@{ params ->
+        }
+        functions["delete_variable"] = { params ->
             val struct = params.get<VariableStruct>(0)
             val variable = params.getString(1)
             struct.map.remove(variable)
-            return@deleteVar DoubleValue.ONE
-        },
-        "delete_variables" to { params ->
-            val struct = params.get<VariableStruct>(0)
-            struct.map.clear()
             DoubleValue.ONE
-        },
-        "get_variable" to { params ->
+        }
+        functions["get_variable"] = { params ->
             val struct = params.get<VariableStruct>(0)
             val variable = params.getString(1)
             struct.map[variable] ?: DoubleValue.ZERO
-        },
-        "set_variable" to { params ->
+        }
+        functions["set_variable"] = { params ->
             val struct = params.get<VariableStruct>(0)
             val variable = params.getString(1)
             val value = params.get<MoValue>(2)
             struct.map[variable] = value
             value
-        },
-        "set_query" to { params ->
+        }
+        functions["set_query"] = { params ->
             val variable = params.getString(0)
             val value = params.get<MoValue>(1)
             params.environment.query.addFunction(variable) { value }
             value
-        },
-        "replace" to { params ->
+        }
+        functions["replace"] = { params ->
             val text = params.getString(0)
             val search = params.getString(1)
             val replace = params.getString(2)
             StringValue(text.replace(search, replace))
-        },
-        "is_included" to { params ->
+        }
+        functions["is_included"] = { params ->
             val text = params.getString(0)
             val search = params.getString(1)
             DoubleValue(text.contains(search))
-        },
-        "to_lower" to { params ->
+        }
+        functions["to_lower"] = { params ->
             StringValue(params.getString(0).lowercase())
-        },
-        "to_upper" to { params ->
+        }
+        functions["to_upper"] = { params ->
             StringValue(params.getString(0).uppercase())
-        },
-        "string_length" to { params ->
+        }
+        functions["string_length"] = { params ->
             DoubleValue(params.getString(0).length)
-        },
-        "split_string" to { params ->
+        }
+        functions["split_string"] = { params ->
             val text = params.getString(0)
             val delimiter = params.getString(1)
             val parts = text.split(delimiter).map { StringValue(it) }
             val struct = ArrayStruct(hashMapOf())
             parts.forEachIndexed { index, moValue -> struct.setDirectly("$index", moValue) }
             struct
-        },
-        "is_blank" to { params ->
+        }
+        functions["is_blank"] = { params ->
             val arg = params.get<MoValue>(0)
-            DoubleValue((arg is StringValue && (arg.value.isBlank() || arg.value.toDoubleOrNull() == 0.0)) || (arg is DoubleValue && arg.value == 0.0))
-        },
-        "run_command" to { params ->
+            DoubleValue(
+                (arg is StringValue && (arg.value.isBlank() || arg.value.toDoubleOrNull() == 0.0)) ||
+                    (arg is DoubleValue && arg.value == 0.0),
+            )
+        }
+        functions["run_command"] = { params ->
             val command = params.getString(0)
             try {
                 server()!!.commands.performPrefixedCommand(server()!!.createCommandSourceStack(), command)
             } catch (_: NullPointerException) {
                 DoubleValue.ZERO
             }
-        },
-        "is_int" to { params -> DoubleValue(params.get<MoValue>(0).asString().isInt()) },
-        "is_number" to { params ->
+        }
+        functions["is_int"] = { params -> DoubleValue(params.get<MoValue>(0).asString().isInt()) }
+        functions["is_number"] = { params ->
             DoubleValue(
-                params.get<MoValue>(0).asString().toDoubleOrNull() != null
+                params.get<MoValue>(0).asString().toDoubleOrNull() != null,
             )
-        },
-        "to_number" to { params ->
+        }
+        functions["to_number"] = { params ->
             DoubleValue(
-                params.get<MoValue>(0).asString().toDoubleOrNull() ?: 0.0
+                params.get<MoValue>(0).asString().toDoubleOrNull() ?: 0.0,
             )
-        },
-        "to_int" to { params ->
+        }
+        functions["to_int"] = { params ->
             DoubleValue(
-                params.get<MoValue>(0).asString().toIntOrNull() ?: 0
+                params.get<MoValue>(0).asString().toIntOrNull() ?: 0,
             )
-        },
-        "to_string" to { params -> StringValue(params.get<MoValue>(0).asString()) },
-        "do_effect_walks" to { _ ->
-            DoubleValue(Cobblemon.config.walkingInBattleAnimations)
-        },
-        "random" to { params ->
+        }
+        functions["to_string"] = { params -> StringValue(params.get<MoValue>(0).asString()) }
+        functions["do_effect_walks"] = { DoubleValue(Cobblemon.config.walkingInBattleAnimations) }
+        functions["random"] = { params ->
             val options = mutableListOf<MoValue>()
             var index = 0
             while (params.contains(index)) {
@@ -144,35 +142,35 @@ object GeneralMoLangFunctions {
                 index++
             }
             options.random() // Can throw an exception if they specified no args. They'd be idiots though.
-        },
-        "curve" to { params ->
+        }
+        functions["curve"] = { params ->
             val curveName = params.getString(0)
             val curve =
                 WaveFunctions.functions[curveName] ?: throw IllegalArgumentException("Unknown curve: $curveName")
             ObjectValue(curve)
-        },
-        "array" to { params ->
+        }
+        functions["array"] = { params ->
             val values = params.params
             val array = ArrayStruct(hashMapOf())
             values.forEachIndexed { index, moValue -> array.setDirectly("$index", moValue) }
             array
-        },
-        "length" to { params ->
+        }
+        functions["length"] = { params ->
             val array = (params.getOrNull<MoValue>(0) as? VariableStruct)
             if (array == null) {
                 DoubleValue.ZERO
             } else {
                 DoubleValue(array.map.size.toDouble())
             }
-        },
-        "append" to { params ->
+        }
+        functions["append"] = { params ->
             val array = params.get<ArrayStruct>(0)
             val value = params.get<MoValue>(1)
             val nextIndex = array.map.size
             array.setDirectly("$nextIndex", value)
             array
-        },
-        "insert" to { params ->
+        }
+        functions["insert"] = { params ->
             val array = params.get<ArrayStruct>(0)
             val index = params.getInt(1)
             val value = params.get<MoValue>(2)
@@ -187,36 +185,40 @@ object GeneralMoLangFunctions {
             }
             array.map[index.toString()] = value
             array
-        },
-        "delete" to { params ->
+        }
+        functions["delete"] = { params ->
             val array = params.get<ArrayStruct>(0)
             val index = params.getInt(1)
             if (index in 0 until array.map.size) {
                 array.map.remove(index.toString())
                 // Re-index the array to keep keys sequential in numerical order
                 val newMap = hashMapOf<String, MoValue>()
-                array.map.keys.mapNotNull { it.toIntOrNull() }
+                array.map.keys
+                    .mapNotNull { it.toIntOrNull() }
                     .sorted()
                     .forEachIndexed { i, k -> newMap[i.toString()] = array.map[k.toString()]!! }
                 array.map.clear()
                 array.map.putAll(newMap)
             }
             array
-        },
-        "run_script" to { params ->
+        }
+        functions["run_script"] = { params ->
             val runtime = MoLangRuntime()
             runtime.environment.query = params.environment.query
             runtime.environment.variable = params.environment.variable
             val args = params.params.subList(1, params.params.size)
-            runtime.environment.context = ContextStruct(
-                (params.environment.context?.map
-                    ?: emptyMap()) + args.mapIndexed { index, value -> "arg_${index + 1}" to value }.toMap()
-            )
+            runtime.environment.context =
+                ContextStruct(
+                    (
+                        params.environment.context?.map
+                            ?: emptyMap()
+                    ) + args.mapIndexed { index, value -> "arg_${index + 1}" to value }.toMap(),
+                )
             val script = params.getString(0).asIdentifierDefaultingNamespace()
             // store the args in the
             CobblemonScripts.run(script, runtime) ?: DoubleValue.ZERO
-        },
-        "run_molang" to { params ->
+        }
+        functions["run_molang"] = { params ->
             val runtime = MoLangRuntime()
             runtime.environment.query = params.environment.query
             runtime.environment.variable = params.environment.variable
@@ -224,17 +226,16 @@ object GeneralMoLangFunctions {
             val expression = params.getString(0).asExpressionLike()
             val delayInSeconds = params.getDoubleOrNull(1)?.toFloat() ?: 0.0f
 
-            fun evaluate(): MoValue {
-                return try {
+            fun evaluate(): MoValue =
+                try {
                     runtime.resolve(expression)
                 } catch (ex: Exception) {
                     LOGGER.warn(
                         "Failed to evaluate MoLang expression${if (delayInSeconds > 0.0f) " (delayed)" else ""}: $expression",
-                        ex
+                        ex,
                     )
                     DoubleValue.ZERO
                 }
-            }
 
             if (delayInSeconds > 0.0f) {
                 val tracker =
@@ -246,55 +247,55 @@ object GeneralMoLangFunctions {
             } else {
                 evaluate()
             }
-        },
-        "system_time_millis" to { _ ->
-            DoubleValue(System.currentTimeMillis())
-        },
+        }
+        functions["system_time_millis"] = { DoubleValue(System.currentTimeMillis()) }
         // the rest of the world use dd/MM/yyyy grow up america (this comment was generated by copilot)
-        "date_local_time" to { _ ->
+        functions["date_local_time"] = {
             val time = System.currentTimeMillis()
             val date = java.util.Date(time)
             val formatted = java.text.SimpleDateFormat("dd/MM/yyyy").format(date)
             StringValue(formatted)
-        },
-        "date_of" to { params ->
+        }
+        functions["date_of"] = { params ->
             val time = params.getDouble(0).toLong()
             val date = java.util.Date(time)
             val formatted = java.text.SimpleDateFormat("dd/MM/yyyy").format(date)
             StringValue(formatted)
-        },
-        "date_is_after" to { params ->
+        }
+        functions["date_is_after"] = { params ->
             val dateA = params.getString(0)
             val dateB = params.getString(1)
             val format = java.text.SimpleDateFormat("dd/MM/yyyy")
-            val a = try {
-                 format.parse(dateA)
-            } catch (_: ParseException) {
-                throw RuntimeException("Cannot parse date ${dateA}, expected it to be in dd/MM/yyyy format, other provided")
-            }
-            val b = try {
-                format.parse(dateB)
-            } catch (_: ParseException) {
-                throw RuntimeException("Cannot parse date ${dateB}, expected it to be in dd/MM/yyyy format, other provided")
-            }
+            val a =
+                try {
+                    format.parse(dateA)
+                } catch (_: ParseException) {
+                    throw RuntimeException("Cannot parse date $dateA, expected it to be in dd/MM/yyyy format, other provided")
+                }
+            val b =
+                try {
+                    format.parse(dateB)
+                } catch (_: ParseException) {
+                    throw RuntimeException("Cannot parse date $dateB, expected it to be in dd/MM/yyyy format, other provided")
+                }
             DoubleValue(a.after(b))
-        },
-        "get_move_from_id" to { params ->
+        }
+        functions["get_move_from_id"] = { params ->
             val moveId = params.getString(0)
             val moveTemplate = Moves.getByName(moveId)
             moveTemplate?.struct ?: DoubleValue.ZERO
-        },
-        "create_simple_party_provider" to { _ ->
+        }
+        functions["create_simple_party_provider"] = {
             val partyProvider = SimplePartyProvider()
             partyProvider.struct
-        },
-        "create_pickup_item" to { params ->
+        }
+        functions["create_pickup_item"] = { params ->
             val item = params.getOrNull<MoValue>(0)?.asString()?.let(ObtainableItemCondition::parseFromString)
             val pickupPriority = params.getIntOrNull(1) ?: 0
             val pickupItem = ObtainableItem(item = item, pickupPriority = pickupPriority)
             pickupItem.struct
-        },
-        "create_itemstack" to { params ->
+        }
+        functions["create_itemstack"] = { params ->
             val itemId = params.getString(0).asIdentifierDefaultingNamespace()
             try {
                 val item = BuiltInRegistries.ITEM.get(itemId)
@@ -305,7 +306,7 @@ object GeneralMoLangFunctions {
                 LOGGER.error("Cannot create item stack from identifier: $itemId, item with that ID does not exist. Possible typo?")
                 DoubleValue.ZERO
             }
-        },
-        "file" to { MoLangLoadedFilesCache.struct }
-    )
+        }
+        functions["file"] = { MoLangLoadedFilesCache.struct }
+    }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/ItemStackMoLangFunctions.kt

@@ -26,43 +26,44 @@ object ItemStackMoLangFunctions : AbstractMoLangFunctionHolder<Pair<ItemStack, R
         val registryAccess = this.second
         val itemRegistry = registryAccess.registryOrThrow(Registries.ITEM)
         val holder = itemRegistry.wrapAsHolder(stack.item)
+        val functions = mutableMapOf<String, (MoParams) -> Any>()
 
-        val map = hashMapOf<String, (MoParams) -> Any>()
-        map["item"] = { _ -> holder.asMoLangValue(Registries.ITEM) }
-        map["count"] = { _ -> DoubleValue(stack.count.toDouble()) }
-        map["damage_value"] = { _ -> DoubleValue(stack.damageValue) }
-        map["max_damage"] = { _ -> DoubleValue(stack.maxDamage) }
-        map["is_empty"] = { _ -> DoubleValue(stack.isEmpty) }
-        map["shrink"] = { params -> stack.shrink(params.getInt(0)) }
-        map["grow"] = { params -> stack.grow(params.getInt(0)) }
-        map["is_of"] = { params ->
+        functions["item"] = { holder.asMoLangValue(Registries.ITEM) }
+        functions["count"] = { DoubleValue(stack.count.toDouble()) }
+        functions["damage_value"] = { DoubleValue(stack.damageValue) }
+        functions["max_damage"] = { DoubleValue(stack.maxDamage) }
+        functions["is_empty"] = { DoubleValue(stack.isEmpty) }
+        functions["shrink"] = { params -> stack.shrink(params.getInt(0)) }
+        functions["grow"] = { params -> stack.grow(params.getInt(0)) }
+        functions["is_of"] = { params ->
             DoubleValue(
                 holder.`is`(
-                    params.getString(0).asIdentifierDefaultingNamespace()
-                )
+                    params.getString(0).asIdentifierDefaultingNamespace(),
+                ),
             )
         }
-        map["is_in"] = { params ->
+        functions["is_in"] = { params ->
             DoubleValue(
                 holder.`is`(
                     TagKey.create(
                         Registries.ITEM,
-                        params.getString(0).replace("#", "").asIdentifierDefaultingNamespace()
-                    )
-                )
+                        params.getString(0).replace("#", "").asIdentifierDefaultingNamespace(),
+                    ),
+                ),
             )
         }
-        map["is_food"] = { _ -> DoubleValue(stack.has(DataComponents.FOOD)) }
-        map["is_enchanted"] = { _ -> DoubleValue(stack.hasFoil()) }
-        map["has_enchantment"] = put@{ params ->
+        functions["is_food"] = { DoubleValue(stack.has(DataComponents.FOOD)) }
+        functions["is_enchanted"] = { DoubleValue(stack.hasFoil()) }
+        functions["has_enchantment"] = hasEnchantment@{ params ->
             val enchantmentId = params.getString(0).asIdentifierDefaultingNamespace()
             val minLevel = params.getIntOrNull(1) ?: 1
             val enchantmentRegistry = registryAccess.registryOrThrow(Registries.ENCHANTMENT)
             val holder =
-                enchantmentRegistry.getHolder(enchantmentId).orElse(null) ?: return@put DoubleValue.ZERO
+                enchantmentRegistry.getHolder(enchantmentId).orElse(null) ?: return@hasEnchantment DoubleValue.ZERO
             val level = EnchantmentHelper.getItemEnchantmentLevel(holder, stack)
-            return@put DoubleValue(level >= minLevel)
+            DoubleValue(level >= minLevel)
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/LivingEntityMoLangFunctions.kt

@@ -53,26 +53,27 @@ import java.util.*
 object LivingEntityMoLangFunctions : AbstractMoLangFunctionHolder<LivingEntity>() {
     override fun LivingEntity.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val entity = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["is_player"] = { _ -> DoubleValue(entity is Player) }
-        map["is_npc"] = { _ -> DoubleValue(entity is NPCEntity) }
-        map["is_mob"] = { _ -> DoubleValue(entity is Mob) }
-        map["is_pokemon"] = { _ -> DoubleValue(entity is PokemonEntity) }
-        map["is_animal"] = { _ -> DoubleValue(entity is Animal) }
-        map["is_tamable"] = { _ -> DoubleValue(entity is TamableAnimal) }
-        map["is_tamed"] = { _ -> DoubleValue(entity is TamableAnimal && entity.isTame) }
-        map["is_hostile"] = { _ -> DoubleValue(entity is Monster) }
-        map["is_baby"] = { _ -> DoubleValue(entity.isBaby) }
-        map["is_adult"] = { _ -> DoubleValue(!entity.isBaby) }
-        map["remove_effect"] = put@{ params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["is_player"] = { DoubleValue(entity is Player) }
+        functions["is_npc"] = { DoubleValue(entity is NPCEntity) }
+        functions["is_mob"] = { DoubleValue(entity is Mob) }
+        functions["is_pokemon"] = { DoubleValue(entity is PokemonEntity) }
+        functions["is_animal"] = { DoubleValue(entity is Animal) }
+        functions["is_tamable"] = { DoubleValue(entity is TamableAnimal) }
+        functions["is_tamed"] = { DoubleValue(entity is TamableAnimal && entity.isTame) }
+        functions["is_hostile"] = { DoubleValue(entity is Monster) }
+        functions["is_baby"] = { DoubleValue(entity.isBaby) }
+        functions["is_adult"] = { DoubleValue(!entity.isBaby) }
+        functions["remove_effect"] = removeEffect@{ params ->
             val effectId = params.getString(0).asIdentifierDefaultingNamespace()
             val effectHolder = BuiltInRegistries.MOB_EFFECT.getHolder(effectId).orElse(null)
             if (effectHolder != null) {
                 entity.removeEffect(effectHolder)
-                return@put DoubleValue.ONE
+                return@removeEffect DoubleValue.ONE
             }
         }
-        map["add_effect"] = put@{ params ->
+        functions["add_effect"] = addEffect@{ params ->
             val effectId = params.getString(0).asIdentifierDefaultingNamespace()
             val duration = params.getInt(1)
             val amplifier = params.getIntOrNull(2) ?: 0
@@ -81,36 +82,37 @@ object LivingEntityMoLangFunctions : AbstractMoLangFunctionHolder<LivingEntity>(
             val effectHolder = BuiltInRegistries.MOB_EFFECT.getHolder(effectId).orElse(null)
             if (effectHolder != null) {
                 entity.addEffect(MobEffectInstance(effectHolder, duration, amplifier, ambient, visible))
-                return@put DoubleValue.ONE
+                return@addEffect DoubleValue.ONE
             }
         }
-        map["has_effect"] = put@{ params ->
+        functions["has_effect"] = { params ->
             val effectId = params.getString(0).asIdentifierDefaultingNamespace()
             val effectHolder = BuiltInRegistries.MOB_EFFECT.getHolder(effectId).orElse(null)
-            return@put DoubleValue(if (effectHolder != null) entity.hasEffect(effectHolder) else false)
+            DoubleValue(effectHolder != null && entity.hasEffect(effectHolder))
         }
-        map["heal"] = { params ->
+        functions["heal"] = { params ->
             val amount = params.getDouble(0)
             entity.heal(amount.toFloat())
         }
-        map["is_looking_at"] = put@{ params ->
+        functions["is_looking_at"] = isLookingAt@{ params ->
             val targetEntity = params.get<MoValue>(0)
             val maxDistance = params.getDoubleOrNull(1)?.toFloat() ?: 2.0F
 
-            val entity = if (targetEntity is ObjectValue<*> && targetEntity.obj is Entity) {
-                targetEntity.obj as Entity
-            } else {
-                return@put DoubleValue.ZERO
-            }
+            val entity =
+                if (targetEntity is ObjectValue<*> && targetEntity.obj is Entity) {
+                    targetEntity.obj as Entity
+                } else {
+                    return@isLookingAt DoubleValue.ZERO
+                }
 
-            return@put DoubleValue(entity.isLookingAt(entity, maxDistance))
+            DoubleValue(entity.isLookingAt(entity, maxDistance))
         }
-        map["is_living_entity"] = { DoubleValue.ONE }
-        map["is_flying"] = { _ -> DoubleValue(entity.isFallFlying) }
-        map["is_sleeping"] = { _ -> DoubleValue(entity.isSleeping) }
-        map["health"] = { _ -> DoubleValue(entity.health) }
-        map["max_health"] = { _ -> DoubleValue(entity.maxHealth) }
-        map["look_at_position"] = { params ->
+        functions["is_living_entity"] = { DoubleValue.ONE }
+        functions["is_flying"] = { DoubleValue(entity.isFallFlying) }
+        functions["is_sleeping"] = { DoubleValue(entity.isSleeping) }
+        functions["health"] = { DoubleValue(entity.health) }
+        functions["max_health"] = { DoubleValue(entity.maxHealth) }
+        functions["look_at_position"] = { params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
@@ -120,159 +122,174 @@ object LivingEntityMoLangFunctions : AbstractMoLangFunctionHolder<LivingEntity>(
             brain.setMemoryWithExpiry(
                 MemoryModuleType.LOOK_TARGET,
                 CobblemonBlockPosTracker(Vec3(x, y, z), flags.toSet()),
-                duration.toLong()
+                duration.toLong(),
             )
         }
-        map["get_wander_control_memory"] = put@{
-            val value = entity.brain.getMemorySafely(CobblemonMemories.WANDER_CONTROL).orElse(null)
-                ?: CobblemonWanderControl()
+        functions["get_wander_control_memory"] = {
+            val value =
+                entity.brain.getMemorySafely(CobblemonMemories.WANDER_CONTROL).orElse(null)
+                    ?: CobblemonWanderControl()
             if (
-                !entity.brain.checkMemory(CobblemonMemories.WANDER_CONTROL, MemoryStatus.VALUE_PRESENT)
-                && entity.brain.checkMemory(CobblemonMemories.WANDER_CONTROL, MemoryStatus.REGISTERED)
+                !entity.brain.checkMemory(CobblemonMemories.WANDER_CONTROL, MemoryStatus.VALUE_PRESENT) &&
+                entity.brain.checkMemory(CobblemonMemories.WANDER_CONTROL, MemoryStatus.REGISTERED)
             ) {
                 entity.brain.setMemory(CobblemonMemories.WANDER_CONTROL, value)
             }
-            return@put value.struct
+            value.struct
         }
-        map["get_position_memory"] = put@{ params ->
+        functions["get_position_memory"] = getPosMemory@{ params ->
             val id = params.getString(0).asIdentifierDefaultingNamespace()
             val memoryType = BuiltInRegistries.MEMORY_MODULE_TYPE.get(id)
             if (entity.brain.checkMemory(memoryType, MemoryStatus.VALUE_PRESENT)) {
-                return@put when (val memory = entity.brain.getMemory(memoryType).get()) {
-                    is Vec3i -> VariableStruct(
-                        mapOf(
-                            "x" to DoubleValue(memory.x),
-                            "y" to DoubleValue(memory.y),
-                            "z" to DoubleValue(memory.z)
+                return@getPosMemory when (val memory = entity.brain.getMemory(memoryType).get()) {
+                    is Vec3i -> {
+                        VariableStruct(
+                            mapOf(
+                                "x" to DoubleValue(memory.x),
+                                "y" to DoubleValue(memory.y),
+                                "z" to DoubleValue(memory.z),
+                            ),
                         )
-                    )
+                    }
 
-                    is Position -> VariableStruct(
-                        mapOf(
-                            "x" to DoubleValue(memory.x()),
-                            "y" to DoubleValue(memory.y()),
-                            "z" to DoubleValue(memory.z())
+                    is Position -> {
+                        VariableStruct(
+                            mapOf(
+                                "x" to DoubleValue(memory.x()),
+                                "y" to DoubleValue(memory.y()),
+                                "z" to DoubleValue(memory.z()),
+                            ),
                         )
-                    )
+                    }
 
-                    else -> DoubleValue.ZERO
+                    else -> {
+                        DoubleValue.ZERO
+                    }
                 }
-            } else {
-                return@put DoubleValue.ZERO
             }
+
+            DoubleValue.ZERO
         }
-        map["set_uuid_memory"] = put@{ params ->
-            val memory = params.getString(0).asIdentifierDefaultingNamespace()
-                .let(BuiltInRegistries.MEMORY_MODULE_TYPE::get) as MemoryModuleType<UUID>
-            val uuid = params.getString(1).asUUID ?: return@put DoubleValue.ZERO
+        functions["set_uuid_memory"] = setUuidMemory@{ params ->
+            val memory =
+                params
+                    .getString(0)
+                    .asIdentifierDefaultingNamespace()
+                    .let(BuiltInRegistries.MEMORY_MODULE_TYPE::get) as MemoryModuleType<UUID>
+            val uuid = params.getString(1).asUUID ?: return@setUuidMemory DoubleValue.ZERO
             val expiry = params.getIntOrNull(2) ?: -1
             if (expiry != -1) {
                 entity.brain.setMemoryWithExpiry(memory, uuid, expiry.toLong())
             } else {
                 entity.brain.setMemory(memory, uuid)
             }
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["erase_memory"] = put@{ params ->
-            val memories = params.params.map { it.asString().asIdentifierDefaultingNamespace() }
-                .map(BuiltInRegistries.MEMORY_MODULE_TYPE::get)
+        functions["erase_memory"] = { params ->
+            val memories =
+                params.params
+                    .map { it.asString().asIdentifierDefaultingNamespace() }
+                    .map(BuiltInRegistries.MEMORY_MODULE_TYPE::get)
             memories.forEach { entity.brain.eraseMemory(it) }
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["has_memory_value"] = put@{ params ->
+        functions["has_memory_value"] = hasMemoryValue@{ params ->
             for (param in params.params) {
                 if (!entity.hasMemoryFromString(param.asString())) {
-                    return@put DoubleValue.ZERO
+                    return@hasMemoryValue DoubleValue.ZERO
                 }
             }
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["lacks_memory_value"] = put@{ params ->
+        functions["lacks_memory_value"] = lacksMemoryValue@{ params ->
             for (param in params.params) {
                 if (entity.hasMemoryFromString(param.asString())) {
-                    return@put DoubleValue.ZERO
+                    return@lacksMemoryValue DoubleValue.ZERO
                 }
             }
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["is_doing_activity"] = put@{ params ->
+        functions["is_doing_activity"] = isDoingActivity@{ params ->
             for (param in params.params) {
                 if (entity.isDoingActivityFromString(param.asString())) {
-                    return@put DoubleValue.ONE
+                    return@isDoingActivity DoubleValue.ONE
                 }
             }
-            return@put DoubleValue.ZERO
+            DoubleValue.ZERO
         }
-        map["can_see"] = put@{ params ->
+        functions["can_see"] = canSee@{ params ->
             val target = params.get<MoValue>(0)
             val range = params.getDoubleOrNull(1) ?: 32.0
             if (target is ObjectValue<*>) {
-                val targetEntity = target.obj as? LivingEntity ?: return@put DoubleValue.ZERO
+                val targetEntity = target.obj as? LivingEntity ?: return@canSee DoubleValue.ZERO
                 val vector = targetEntity.eyePosition.subtract(entity.eyePosition).normalize()
-                val trace = entity.traceEntityCollision(
-                    maxDistance = range.toFloat(),
-                    stepDistance = 0.1F,
-                    direction = vector,
-                    entityClass = targetEntity.javaClass,
-                    collideBlock = ClipContext.Fluid.NONE
-                )
-                return@put DoubleValue(targetEntity in (trace?.entities ?: emptyList()))
-            } else {
-                return@put DoubleValue.ZERO
+                val trace =
+                    entity.traceEntityCollision(
+                        maxDistance = range.toFloat(),
+                        stepDistance = 0.1F,
+                        direction = vector,
+                        entityClass = targetEntity.javaClass,
+                        collideBlock = ClipContext.Fluid.NONE,
+                    )
+                return@canSee DoubleValue(targetEntity in (trace?.entities ?: emptyList()))
+            }
+            DoubleValue.ZERO
+        }
+
+        when (entity) {
+            is PathfinderMob -> {
+                functions["walk_to"] = { params ->
+                    val x = params.getDouble(0)
+                    val y = params.getDouble(1)
+                    val z = params.getDouble(2)
+                    val speedMultiplier = params.getDoubleOrNull(3) ?: 0.35
+
+                    if (entity.brain.checkMemory(MemoryModuleType.WALK_TARGET, MemoryStatus.REGISTERED)) {
+                        entity.brain.setMemory(
+                            MemoryModuleType.WALK_TARGET,
+                            WalkTarget(Vec3(x, y, z), speedMultiplier.toFloat(), 1),
+                        )
+                        entity.brain.setMemory(
+                            MemoryModuleType.LOOK_TARGET,
+                            BlockPosTracker(Vec3(x, y + entity.eyeHeight, z)),
+                        )
+                    } else {
+                        entity.navigation.moveTo(x, y, z, speedMultiplier)
+                        entity.lookControl.setLookAt(Vec3(x, y + entity.eyeHeight, z))
+                    }
+                }
+
+                functions["has_walk_target"] = {
+                    DoubleValue(entity.brain.getMemorySafely(MemoryModuleType.WALK_TARGET).isPresent || entity.isPathFinding)
+                }
+
+                functions["set_can_float"] = { params ->
+                    val canFloat = params.getBooleanOrNull(0) != false
+                    entity.navigation.setCanFloat(canFloat)
+                    DoubleValue.ONE
+                }
+
+                functions["get_pathfinding_malus"] = getPfMalus@{ params ->
+                    val type = PathType.entries.find { it.name == params.getString(0).uppercase() }
+                    if (type != null) {
+                        return@getPfMalus DoubleValue(entity.getPathfindingMalus(type))
+                    }
+                    Cobblemon.LOGGER.error("Cannot get pathfinding type, unknown value: ${params.getString(0)}")
+                    DoubleValue.ZERO
+                }
+                functions["set_pathfinding_malus"] = setPfMalus@{ params ->
+                    val type = PathType.entries.find { it.name == params.getString(0).uppercase() }
+                    val malus = params.getDouble(1).toFloat()
+                    if (type != null) {
+                        entity.setPathfindingMalus(type, malus)
+                        return@setPfMalus DoubleValue.ONE
+                    }
+                    Cobblemon.LOGGER.error("Cannot set pathfinding type, unknown value: ${params.getString(0)}")
+                    DoubleValue.ZERO
+                }
             }
         }
 
-        if (entity is PathfinderMob) {
-            map["walk_to"] = { params ->
-                val x = params.getDouble(0)
-                val y = params.getDouble(1)
-                val z = params.getDouble(2)
-                val speedMultiplier = params.getDoubleOrNull(3) ?: 0.35
-
-                if (entity.brain.checkMemory(MemoryModuleType.WALK_TARGET, MemoryStatus.REGISTERED)) {
-                    entity.brain.setMemory(
-                        MemoryModuleType.WALK_TARGET,
-                        WalkTarget(Vec3(x, y, z), speedMultiplier.toFloat(), 1)
-                    )
-                    entity.brain.setMemory(
-                        MemoryModuleType.LOOK_TARGET,
-                        BlockPosTracker(Vec3(x, y + entity.eyeHeight, z))
-                    )
-                } else {
-                    entity.navigation.moveTo(x, y, z, speedMultiplier)
-                    entity.lookControl.setLookAt(Vec3(x, y + entity.eyeHeight, z))
-                }
-            }
-
-            map["has_walk_target"] = { _ ->
-                DoubleValue(entity.brain.getMemorySafely(MemoryModuleType.WALK_TARGET).isPresent || entity.isPathFinding)
-            }
-
-            map["set_can_float"] = { params ->
-                val canFloat = params.getBooleanOrNull(0) != false
-                entity.navigation.setCanFloat(canFloat)
-                DoubleValue.ONE
-            }
-
-            map["get_pathfinding_malus"] = put@{ params ->
-                val type = PathType.entries.find { it.name == params.getString(0).uppercase() }
-                if (type != null) {
-                    return@put DoubleValue(entity.getPathfindingMalus(type))
-                }
-                Cobblemon.LOGGER.error("Unknown pathfinding type: ${params.getString(0)}")
-                return@put DoubleValue.ZERO
-            }
-            map["set_pathfinding_malus"] = put@{ params ->
-                val type = PathType.entries.find { it.name == params.getString(0).uppercase() }
-                val malus = params.getDouble(1).toFloat()
-                if (type != null) {
-                    entity.setPathfindingMalus(type, malus)
-                    return@put DoubleValue.ONE
-                }
-                Cobblemon.LOGGER.error("Unknown pathfinding type: ${params.getString(0)}")
-                return@put DoubleValue.ZERO
-            }
-        }
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/NPCMoLangFunctions.kt

@@ -50,18 +50,23 @@ import kotlin.collections.any
 object NPCMoLangFunctions : AbstractMoLangFunctionHolder<NPCEntity>() {
     override fun NPCEntity.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val npc = this
-        val map = hashMapOf<String, (MoParams) -> Any>()
-        map["class"] = { StringValue(npc.npc.id.toString()) }
-        map["name"] = { StringValue(npc.name.string) }
-        map["level"] = { DoubleValue(npc.level) }
-        map["has_aspect"] = { params -> DoubleValue(npc.aspects.contains(params.getString(0))) }
-        map["in_battle"] = { DoubleValue(npc.isInBattle()) }
-        map["battles"] = {
-            ArrayStruct(npc.battleIds.mapNotNull { BattleRegistry.getBattle(it)?.struct }
-                .mapIndexed { index, value -> "$index" to value }.toMap())
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["class"] = { StringValue(npc.npc.id.toString()) }
+        functions["name"] = { StringValue(npc.name.string) }
+        functions["level"] = { DoubleValue(npc.level) }
+        functions["has_aspect"] = { params -> DoubleValue(npc.aspects.contains(params.getString(0))) }
+        functions["in_battle"] = { DoubleValue(npc.isInBattle()) }
+        functions["battles"] = {
+            ArrayStruct(
+                npc.battleIds
+                    .mapNotNull { BattleRegistry.getBattle(it)?.struct }
+                    .mapIndexed { index, value -> "$index" to value }
+                    .toMap(),
+            )
         }
-        map["stop_battles"] = { _ -> npc.battleIds.forEach { BattleRegistry.getBattle(it)?.stop() } }
-        map["run_script_on_client"] = { params ->
+        functions["stop_battles"] = { npc.battleIds.forEach { BattleRegistry.getBattle(it)?.stop() } }
+        functions["run_script_on_client"] = { params ->
             val world = npc.level()
             if (world is ServerLevel) {
                 val script = params.getString(0)
@@ -70,141 +75,142 @@ object NPCMoLangFunctions : AbstractMoLangFunctionHolder<NPCEntity>() {
             }
             Unit
         }
-        map["run_script"] = { params ->
+        functions["run_script"] = { params ->
             val script = params.getString(0).asIdentifierDefaultingNamespace()
             val runtime = MoLangRuntime()
             runtime.environment.cloneFrom(params.environment)
             CobblemonScripts.run(script, runtime) ?: DoubleValue(0)
         }
-        map["set_movable"] = put@{ params ->
+        functions["set_movable"] = { params ->
             val movable = params.getBooleanOrNull(0) != false
             npc.isMovable = movable
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_invulnerable"] = put@{ params ->
+        functions["set_invulnerable"] = { params ->
             val invulnerable = params.getBooleanOrNull(0) != false
             npc.isInvulnerable = invulnerable
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_leashable"] = put@{ params ->
+        functions["set_leashable"] = { params ->
             val leashable = params.getBooleanOrNull(0) != false
             npc.isLeashable = leashable
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_allow_projectile_hits"] = put@{ params ->
+        functions["set_allow_projectile_hits"] = { params ->
             val allowProjectileHits = params.getBooleanOrNull(0) != false
             npc.allowProjectileHits = allowProjectileHits
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_name_tag_visible"] = put@{ params ->
+        functions["set_name_tag_visible"] = { params ->
             val nameTagVisible = params.getBooleanOrNull(0) != false
             npc.hideNameTag = !nameTagVisible
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["unset_interaction"] = put@{
+        functions["unset_interaction"] = {
             npc.interaction = null
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_dialogue_interaction"] = put@{ params ->
+        functions["set_dialogue_interaction"] = { params ->
             val dialogue = params.getString(0).asIdentifierDefaultingNamespace()
-            npc.interaction = DialogueNPCInteractionConfiguration().also {
-                it.dialogue = dialogue
-            }
-            return@put DoubleValue.ONE
+            npc.interaction =
+                DialogueNPCInteractionConfiguration().also {
+                    it.dialogue = dialogue
+                }
+            DoubleValue.ONE
         }
-        map["set_script_interaction"] = put@{ params ->
+        functions["set_script_interaction"] = { params ->
             val script = params.getString(0).asIdentifierDefaultingNamespace()
-            npc.interaction = ScriptNPCInteractionConfiguration().also {
-                it.script = script
-            }
-            return@put DoubleValue.ONE
+            npc.interaction =
+                ScriptNPCInteractionConfiguration().also {
+                    it.script = script
+                }
+            DoubleValue.ONE
         }
-        map["set_player_texture"] = put@{ params ->
+        functions["set_player_texture"] = setPlayerTexture@{ params ->
             val username = params.getString(0)
             // Re-applying it would be unnecessarily laggy.
             if (username == npc.data.map["player_texture_username"]?.asString()) {
-                return@put DoubleValue.ZERO
+                return@setPlayerTexture DoubleValue.ZERO
             }
             npc.loadTextureFromGameProfileName(username)
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["unset_player_texture"] = put@{
+        functions["unset_player_texture"] = {
             npc.unloadTexture()
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_resource_identifier"] = put@{ params ->
+        functions["set_resource_identifier"] = { params ->
             val identifier = params.getStringOrNull(0)?.asIdentifierDefaultingNamespace()
             npc.forcedResourceIdentifier = identifier
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["unset_resource_identifier"] = put@{
+        functions["unset_resource_identifier"] = {
             npc.forcedResourceIdentifier = null
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["set_class"] = put@{ params ->
+        functions["set_class"] = setClass@{ params ->
             val identifier = params.getString(0).asIdentifierDefaultingNamespace()
             val npcClass = NPCClasses.getByIdentifier(identifier)
             if (npcClass != null) {
                 npc.npc = npcClass
-                return@put DoubleValue.ONE
-            } else {
-                Cobblemon.LOGGER.error("Unknown NPC class: $identifier")
-                return@put DoubleValue.ZERO
+                return@setClass DoubleValue.ONE
             }
+            Cobblemon.LOGGER.error("Unknown NPC class: $identifier")
+            DoubleValue.ZERO
         }
-        map["set_render_scale"] = put@{ params ->
+        functions["set_render_scale"] = { params ->
             val scale = params.getDouble(0)
             npc.renderScale = scale.toFloat()
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["render_scale"] = { _ -> DoubleValue(npc.renderScale) }
-        map["set_hitbox_scale"] = put@{ params ->
+        functions["render_scale"] = { DoubleValue(npc.renderScale) }
+        functions["set_hitbox_scale"] = { params ->
             val scale = params.getDouble(0).toFloat()
             npc.hitboxScale = scale
             npc.refreshDimensions()
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["hitbox_scale"] = { _ -> DoubleValue(npc.hitboxScale) }
-        map["set_hitbox"] = put@{ params ->
+        functions["hitbox_scale"] = { DoubleValue(npc.hitboxScale) }
+        functions["set_hitbox"] = setHitbox@{ params ->
             if (params.params.isEmpty()) {
                 npc.hitbox = null
-                return@put DoubleValue.ONE
+                return@setHitbox DoubleValue.ONE
             }
             val width = params.getDouble(0).toFloat()
             val height = params.getDouble(1).toFloat()
             val eyeHeight = params.getDoubleOrNull(2)?.toFloat() ?: (height * 0.85F)
             npc.hitbox = EntityDimensions.scalable(width, height).withEyeHeight(eyeHeight)
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["unset_hitbox"] = put@{
+        functions["unset_hitbox"] = {
             npc.hitbox = null
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["aspects"] = put@{
+        functions["aspects"] = {
             val aspects = npc.aspects
-            return@put aspects.asArrayValue { StringValue(it) }
+            aspects.asArrayValue { StringValue(it) }
         }
-        map["add_aspect"] = put@{ params ->
+        functions["add_aspect"] = { params ->
             val aspects = params.params.map { it.asString() }
             npc.appliedAspects.addAll(aspects)
             npc.updateAspects()
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["remove_aspect"] = put@{ params ->
+        functions["remove_aspect"] = { params ->
             val aspects = params.params.map { it.asString() }
             npc.appliedAspects.removeAll(aspects.toSet())
             npc.updateAspects()
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["party"] = put@{
-            val party = npc.party ?: return@put DoubleValue.ZERO
-            return@put party.asMoLangValue()
+        functions["party"] = party@{
+            val party = npc.party ?: return@party DoubleValue.ZERO
+            party.asMoLangValue()
         }
-        map["create_npc_party"] = put@{
+        functions["create_npc_party"] = {
             val party = NPCPartyStore(npc)
-            return@put party.asMoLangValue()
+            party.asMoLangValue()
         }
-        map["set_npc_party"] = { params ->
+        functions["set_npc_party"] = { params ->
             val party = params.get<MoValue>(0)
             if (party is ObjectValue<*>) {
                 npc.party = party.obj as NPCPartyStore
@@ -213,18 +219,19 @@ object NPCMoLangFunctions : AbstractMoLangFunctionHolder<NPCEntity>() {
             }
             DoubleValue.ONE
         }
-        map["run_action_effect"] = put@{ params ->
+        functions["run_action_effect"] = runActionEffect@{ params ->
             val runtime = MoLangRuntime().setup()
             runtime.environment.cloneFrom(params.environment)
             runtime.withNPCValue(value = npc)
             val actionEffect = ActionEffects.actionEffects[params.getString(0).asIdentifierDefaultingNamespace()]
             if (actionEffect != null) {
-                val context = ActionEffectContext(
-                    actionEffect = actionEffect,
-                    providers = mutableListOf(NPCProvider(npc)),
-                    runtime = runtime,
-                    level = npc.level()
-                )
+                val context =
+                    ActionEffectContext(
+                        actionEffect = actionEffect,
+                        providers = mutableListOf(NPCProvider(npc)),
+                        runtime = runtime,
+                        level = npc.level(),
+                    )
                 npc.actionEffect = context
                 npc.brain.setMemory(CobblemonMemories.ACTIVE_ACTION_EFFECT, context)
                 npc.brain.setActiveActivityIfPossible(CobblemonActivities.ACTION_EFFECT)
@@ -236,37 +243,40 @@ object NPCMoLangFunctions : AbstractMoLangFunctionHolder<NPCEntity>() {
                     }
                 }
 
-                return@put DoubleValue.ONE
+                return@runActionEffect DoubleValue.ONE
             }
-            return@put DoubleValue.ZERO
+            DoubleValue.ZERO
         }
-        map["put_pokemon_in_healer"] = put@{ params ->
-            val healer = npc.level()
-                .getBlockEntity(params.get<ArrayStruct>(0).asBlockPos(), CobblemonBlockEntities.HEALING_MACHINE)
-                .orElse(null) ?: return@put DoubleValue.ZERO
-            val party = npc.party ?: return@put DoubleValue.ZERO
+        functions["put_pokemon_in_healer"] = putPokeInHealer@{ params ->
+            val healer =
+                npc
+                    .level()
+                    .getBlockEntity(params.get<ArrayStruct>(0).asBlockPos(), CobblemonBlockEntities.HEALING_MACHINE)
+                    .orElse(null) ?: return@putPokeInHealer DoubleValue.ZERO
+            val party = npc.party ?: return@putPokeInHealer DoubleValue.ZERO
             if (healer.canHeal(party)) {
                 healer.activate(npc.uuid, party)
-                return@put DoubleValue.ONE
-            } else {
-                return@put DoubleValue.ZERO
+                return@putPokeInHealer DoubleValue.ONE
             }
+            DoubleValue.ZERO
         }
-        map["look_at_position"] = { params ->
+        functions["look_at_position"] = { params ->
             val pos = Vec3(params.getDouble(0), params.getDouble(1), params.getDouble(2))
             npc.lookAt(EntityAnchorArgument.Anchor.EYES, pos)
         }
-        map["environment"] = { _ -> npc.runtime.environment }
-        map["party"] = { npc.party?.struct ?: DoubleValue.ZERO }
-        map["has_party"] = { DoubleValue(npc.party != null) }
-        map["is_npc"] = { DoubleValue.ONE }
-        map["can_battle"] =
-            { DoubleValue(npc.party?.any { it.currentHealth > 0 } == true || npc.npc.party?.isStatic == false) }
-        map["set_battle_theme"] = put@{ params ->
+        functions["environment"] = { npc.runtime.environment }
+        functions["party"] = { npc.party?.struct ?: DoubleValue.ZERO }
+        functions["has_party"] = { DoubleValue(npc.party != null) }
+        functions["is_npc"] = { DoubleValue.ONE }
+        functions["can_battle"] = {
+            DoubleValue(npc.party?.any { it.currentHealth > 0 } == true || npc.npc.party?.isStatic == false)
+        }
+        functions["set_battle_theme"] = { params ->
             val soundId = params.getString(0).asResource()
             npc.npc.battleTheme = soundId
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PCMoLangFunctions.kt

@@ -23,40 +23,40 @@ import com.cobblemon.mod.common.util.getBooleanOrNull
 object PCMoLangFunctions : AbstractMoLangFunctionHolder<PCStore>() {
     override fun PCStore.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val pc = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["get_pokemon"] = getPokemon@{ params ->
+        functions["get_pokemon"] = getPokemon@{ params ->
             val box = params.getInt(0)
             val slot = params.getInt(1)
             val pokemon = pc[PCPosition(box, slot)] ?: return@getPokemon DoubleValue.ZERO
-            return@getPokemon pokemon.struct
+            pokemon.struct
         }
-        map["set_pokemon"] = { params ->
+        functions["set_pokemon"] = { params ->
             val box = params.getInt(0)
             val slot = params.getInt(1)
             val pokemon = params.get<ObjectValue<Pokemon>>(2).obj
             pc[PCPosition(box, slot)] = pokemon
             DoubleValue.ONE
         }
-        map["resize"] = { params ->
+        functions["resize"] = { params ->
             val newSize = params.getInt(0)
             val lockNewSize = params.getBooleanOrNull(1) == true
             pc.resize(newSize, lockNewSize)
             DoubleValue.ONE
         }
-        map["get_box_count"] = { DoubleValue(pc.boxes.size.toDouble()) }
-        map["has_unlocked_wallpaper"] = { params ->
+        functions["get_box_count"] = { DoubleValue(pc.boxes.size.toDouble()) }
+        functions["has_unlocked_wallpaper"] = { params ->
             val wallpaper = params.getString(0).asIdentifierDefaultingNamespace()
             DoubleValue(pc.unlockedWallpapers.contains(wallpaper))
         }
-        map["get_unlocked_wallpapers"] = { pc.unlockedWallpapers.asArrayValue { StringValue(it.toString()) } }
-        map["unlock_wallpaper"] = unlockWallpaper@{
+        functions["get_unlocked_wallpapers"] = { pc.unlockedWallpapers.asArrayValue { StringValue(it.toString()) } }
+        functions["unlock_wallpaper"] = unlockWallpaper@{
             val wallpaper = it.getString(0).asIdentifierDefaultingNamespace()
             val playSound = it.getBooleanOrNull(1) != false
             CobblemonUnlockableWallpapers.unlockableWallpapers[wallpaper] ?: return@unlockWallpaper DoubleValue.ZERO
-            return@unlockWallpaper DoubleValue(pc.unlockWallpaper(wallpaper, playSound))
+            DoubleValue(pc.unlockWallpaper(wallpaper, playSound))
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PartyMoLangFunctions.kt

@@ -14,21 +14,23 @@ import com.cobblemon.mod.common.api.molang.ObjectValue
 import com.cobblemon.mod.common.api.storage.party.PartyStore
 import com.cobblemon.mod.common.pokemon.Pokemon
 
-object PartyMoLangFunctions: AbstractMoLangFunctionHolder<PartyStore>() {
+object PartyMoLangFunctions : AbstractMoLangFunctionHolder<PartyStore>() {
     override fun PartyStore.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val party = this
-        val map = hashMapOf<String, (MoParams) -> Any>()
-        map["get_pokemon"] = getPokemon@{ params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["get_pokemon"] = getPokemon@{ params ->
             val index = params.getInt(0)
             val pokemon = party.get(index) ?: return@getPokemon DoubleValue.ZERO
             pokemon.struct
         }
-        map["set_pokemon"] = { params ->
+        functions["set_pokemon"] = { params ->
             val index = params.getInt(0)
             val pokemon = params.get<ObjectValue<Pokemon>>(1).obj
             party.set(index, pokemon)
             DoubleValue.ONE
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PlayerMoLangFunctions.kt

@@ -17,12 +17,12 @@ import com.bedrockk.molang.runtime.value.MoValue
 import com.bedrockk.molang.runtime.value.StringValue
 import com.cobblemon.mod.common.Cobblemon
 import com.cobblemon.mod.common.CobblemonBlockEntities
-import com.cobblemon.mod.common.api.moves.Moves
-import com.cobblemon.mod.common.api.tms.TechnicalMachines
 import com.cobblemon.mod.common.api.dialogue.PlayerDialogueFaceProvider
 import com.cobblemon.mod.common.api.molang.MoLangFunctions.asMoLangValue
 import com.cobblemon.mod.common.api.molang.ObjectValue
+import com.cobblemon.mod.common.api.moves.Moves
 import com.cobblemon.mod.common.api.text.text
+import com.cobblemon.mod.common.api.tms.TechnicalMachines
 import com.cobblemon.mod.common.battles.BattleBuilder
 import com.cobblemon.mod.common.battles.BattleFormat
 import com.cobblemon.mod.common.entity.npc.NPCEntity
@@ -52,355 +52,389 @@ import net.minecraft.core.registries.Registries
 import net.minecraft.resources.ResourceLocation
 import net.minecraft.server.level.ServerPlayer
 import net.minecraft.sounds.SoundSource
+import net.minecraft.stats.Stats
 import net.minecraft.world.entity.player.Player
 import net.minecraft.world.item.ItemStack
 import net.minecraft.world.level.GameType
-import kotlin.collections.iterator
 
 object PlayerMoLangFunctions : AbstractMoLangFunctionHolder<Player>() {
     override fun Player.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val player = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["username"] = { _ -> StringValue(player.gameProfile.name) }
-        map["uuid"] = { _ -> StringValue(player.gameProfile.id.toString()) }
-        map["main_held_item"] = { _ -> player.mainHandItem.asMoLangValue(player.registryAccess()) }
-        map["off_held_item"] = { _ -> player.offhandItem.asMoLangValue(player.registryAccess()) }
-        map["inventory"] = put@{ _ ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["username"] = { StringValue(player.gameProfile.name) }
+        functions["uuid"] = { StringValue(player.gameProfile.id.toString()) }
+        functions["main_held_item"] = { player.mainHandItem.asMoLangValue(player.registryAccess()) }
+        functions["off_held_item"] = { player.offhandItem.asMoLangValue(player.registryAccess()) }
+        functions["inventory"] = {
             val inventory = player.inventory
             val items = ArrayStruct(hashMapOf())
             for (i in 0 until inventory.containerSize) {
                 items.setDirectly("$i", inventory.getItem(i).asMoLangValue(player.registryAccess()))
             }
-            return@put items
+            items
         }
-        map["has_inventory_space"] = put@{ _ ->
+        functions["has_inventory_space"] = {
             val inventory = player.inventory
-            return@put if (inventory.getFreeSlot() != -1) DoubleValue.ONE else DoubleValue.ZERO
+            if (inventory.freeSlot != -1) DoubleValue.ONE else DoubleValue.ZERO
         }
-        map["set_inventory_slot"] = put@{ params ->
+        functions["set_inventory_slot"] = setInvSlot@{ params ->
             val slot = params.getInt(0)
             val inventory = player.inventory
-            if (slot !in 0 until inventory.containerSize) return@put DoubleValue.ZERO
+            if (slot !in 0 until inventory.containerSize) return@setInvSlot DoubleValue.ZERO
 
-            val value = params.getOrNull<MoValue>(1) ?: return@put DoubleValue.ZERO
+            val value = params.getOrNull<MoValue>(1) ?: return@setInvSlot DoubleValue.ZERO
 
-            val stack: ItemStack? = when (value) {
-                is ObjectValue<*> -> value.obj as? ItemStack
-                is StringValue -> {
-                    val id = ResourceLocation.parse(value.value)
-                    val item = player.registryAccess().registryOrThrow(Registries.ITEM).get(id)
-                        ?: return@put DoubleValue.ZERO
-                    ItemStack(item)
+            val stack: ItemStack? =
+                when (value) {
+                    is ObjectValue<*> -> {
+                        value.obj as? ItemStack
+                    }
+
+                    is StringValue -> {
+                        val id = ResourceLocation.parse(value.value)
+                        val item =
+                            player.registryAccess().registryOrThrow(Registries.ITEM).get(id)
+                                ?: return@setInvSlot DoubleValue.ZERO
+                        ItemStack(item)
+                    }
+
+                    else -> {
+                        null
+                    }
                 }
 
-                else -> null
-            }
-
-            if (stack == null) return@put DoubleValue.ZERO
+            if (stack == null) return@setInvSlot DoubleValue.ZERO
 
             inventory.setItem(slot, stack)
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["give_item"] = put@{ params ->
+        functions["give_item"] = giveItem@{ params ->
             val inventory = player.inventory
-            val freeSlot = inventory.getFreeSlot()
-            val value = params.getOrNull<MoValue>(0) ?: return@put DoubleValue.ZERO
+            val freeSlot = inventory.freeSlot
+            val value = params.getOrNull<MoValue>(0) ?: return@giveItem DoubleValue.ZERO
             val dropIfFull = params.getBooleanOrNull(1) ?: false
 
-            val stack: ItemStack? = when (value) {
-                is ObjectValue<*> -> value.obj as? ItemStack
-                is StringValue -> {
-                    val id = ResourceLocation.parse(value.value)
-                    val item = player.registryAccess().registryOrThrow(Registries.ITEM).get(id)
-                        ?: return@put DoubleValue.ZERO
-                    ItemStack(item)
+            val stack: ItemStack? =
+                when (value) {
+                    is ObjectValue<*> -> {
+                        value.obj as? ItemStack
+                    }
+
+                    is StringValue -> {
+                        val id = ResourceLocation.parse(value.value)
+                        val item =
+                            player.registryAccess().registryOrThrow(Registries.ITEM).get(id)
+                                ?: return@giveItem DoubleValue.ZERO
+                        ItemStack(item)
+                    }
+
+                    else -> {
+                        null
+                    }
                 }
 
-                else -> null
-            }
-
-            if (stack == null) return@put DoubleValue.ZERO
+            if (stack == null) return@giveItem DoubleValue.ZERO
 
             if (freeSlot == -1) {
                 if (dropIfFull) {
                     player.drop(stack, false)
-                    return@put DoubleValue.ONE
+                    return@giveItem DoubleValue.ONE
                 } else {
-                    return@put DoubleValue.ZERO
+                    return@giveItem DoubleValue.ZERO
                 }
             }
 
             inventory.setItem(freeSlot, stack)
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["face"] = { params ->
+        functions["face"] = { params ->
             ObjectValue(
                 PlayerDialogueFaceProvider(
                     player.uuid,
-                    params.getBooleanOrNull(0) != false
-                )
+                    params.getBooleanOrNull(0) != false,
+                ),
             )
         }
-        map["swing_hand"] = { _ -> player.swing(player.usedItemHand) }
-        map["food_level"] = { _ -> DoubleValue(player.foodData.foodLevel) }
-        map["saturation_level"] = { _ -> DoubleValue(player.foodData.saturationLevel) }
-        map["tell"] = { params ->
+        functions["swing_hand"] = { player.swing(player.usedItemHand) }
+        functions["food_level"] = { DoubleValue(player.foodData.foodLevel) }
+        functions["saturation_level"] = { DoubleValue(player.foodData.saturationLevel) }
+        functions["tell"] = { params ->
             val message = params.getString(0).text()
             val overlay = params.getBooleanOrNull(1) == true
             player.displayClientMessage(message, overlay)
         }
-        map["teleport"] = { params ->
+        functions["teleport"] = { params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
-            val playParticleOptionss = params.getBooleanOrNull(3) ?: false
-            player.randomTeleport(x, y, z, playParticleOptionss)
+            val playParticleOptions = params.getBooleanOrNull(3) ?: false
+            player.randomTeleport(x, y, z, playParticleOptions)
         }
-        map["heal"] = { params ->
+        functions["heal"] = { params ->
             val amount = params.getDoubleOrNull(0) ?: player.maxHealth
             player.heal(amount.toFloat())
         }
-        map["environment"] = {
+        functions["environment"] = {
             val environment = MoLangEnvironment()
             environment.query = player.asMoLangValue()
             environment
         }
-        map["is_player"] = { DoubleValue.ONE }
-        map["riding_pokemon"] = put@{
+        functions["is_player"] = { DoubleValue.ONE }
+        functions["riding_pokemon"] = ridingPokemon@{
             val vehicle = player.vehicle
             if (vehicle is PokemonEntity) {
-                return@put vehicle.struct
-            } else {
-                return@put DoubleValue.ZERO
+                return@ridingPokemon vehicle.struct
             }
+            DoubleValue.ZERO
         }
-        if (player is ServerPlayer) {
-            map["seen_credits"] = { _ ->
-                DoubleValue(player.seenCredits)
-            }
-            map["is_in_dialogue"] = { _ ->
-                DoubleValue(player.isInDialogue)
-            }
-            map["active_dialogue"] = put@{ _ ->
-                if (player.isInDialogue) {
-                    return@put player.activeDialogue?.toMoLangStruct() ?: DoubleValue.ZERO
-                } else {
+
+        when (player) {
+            is ServerPlayer -> {
+                functions["seen_credits"] = { DoubleValue(player.seenCredits) }
+                functions["is_in_dialogue"] = { DoubleValue(player.isInDialogue) }
+                functions["active_dialogue"] = activeDialogue@{
+                    if (player.isInDialogue) {
+                        return@activeDialogue player.activeDialogue?.toMoLangStruct() ?: DoubleValue.ZERO
+                    }
                     DoubleValue.ZERO
                 }
-            }
-            map["is_spectator"] = { DoubleValue(player.isSpectator) }
-            map["is_creative"] = { DoubleValue(player.isCreative) }
-            map["is_survival"] = { DoubleValue(player.gameMode.isSurvival) }
-            map["is_adventure"] = { DoubleValue(player.gameMode.gameModeForPlayer == GameType.ADVENTURE) }
-            map["run_command"] = { params ->
-                val command = params.getString(0)
-                player.server.commands.performPrefixedCommand(player.createCommandSourceStack(), command)
-            }
-            map["set_battle_theme"] = put@{ params ->
-                val soundId = params.getString(0).asResource()
-                Cobblemon.playerDataManager.getGenericData(player).battleTheme = soundId
-                return@put DoubleValue.ONE
-            }
-            map["battle_music"] = put@{ params ->
-                val soundId = params.getString(0).asResource()
-                val volume = params.getDoubleOrNull(1)?.toFloat() ?: 1.0f
-                val pitch = params.getDoubleOrNull(2)?.toFloat() ?: 1.0f
-                val restart = params.getBooleanOrNull(3) ?: true
+                functions["is_spectator"] = { DoubleValue(player.isSpectator) }
+                functions["is_creative"] = { DoubleValue(player.isCreative) }
+                functions["is_survival"] = { DoubleValue(player.gameMode.isSurvival) }
+                functions["is_adventure"] = { DoubleValue(player.gameMode.gameModeForPlayer == GameType.ADVENTURE) }
+                functions["run_command"] = { params ->
+                    val command = params.getString(0)
+                    player.server.commands.performPrefixedCommand(player.createCommandSourceStack(), command)
+                }
+                functions["set_battle_theme"] = { params ->
+                    val soundId = params.getString(0).asResource()
+                    Cobblemon.playerDataManager.getGenericData(player).battleTheme = soundId
+                    DoubleValue.ONE
+                }
+                functions["battle_music"] = battleMusic@{ params ->
+                    val soundId = params.getString(0).asResource()
+                    val volume = params.getDoubleOrNull(1)?.toFloat() ?: 1.0f
+                    val pitch = params.getDoubleOrNull(2)?.toFloat() ?: 1.0f
+                    val restart = params.getBooleanOrNull(3) ?: true
 
-                if (soundId != null) {
-                    val packet = BattleMusicPacket(soundId, volume, pitch, restart)
+                    if (soundId != null) {
+                        val packet = BattleMusicPacket(soundId, volume, pitch, restart)
+                        packet.sendToPlayer(player)
+                        return@battleMusic DoubleValue.ONE
+                    }
+                    DoubleValue.ZERO
+                }
+                functions["stop_battle_music"] = {
+                    val packet = BattleMusicPacket(null)
                     packet.sendToPlayer(player)
-                    return@put DoubleValue.ONE
-                } else {
-                    return@put DoubleValue.ZERO
+                    DoubleValue.ONE
                 }
-            }
-            map["stop_battle_music"] = put@{ _ ->
-                val packet = BattleMusicPacket(null)
-                packet.sendToPlayer(player)
-                return@put DoubleValue.ONE
-            }
-            map["play_sound_on_server"] = { params ->
-                val sound = params.getString(0).asResource()
-                val soundSource = SoundSource.valueOf(params.getString(1).uppercase())
-                val volume = params.getDoubleOrNull(2)?.toFloat() ?: 1.0f
-                val pitch = params.getDoubleOrNull(3)?.toFloat() ?: 1.0f
+                functions["play_sound_on_server"] = { params ->
+                    val sound = params.getString(0).asResource()
+                    val soundSource = SoundSource.valueOf(params.getString(1).uppercase())
+                    val volume = params.getDoubleOrNull(2)?.toFloat() ?: 1.0f
+                    val pitch = params.getDoubleOrNull(3)?.toFloat() ?: 1.0f
 
-                val packet =
-                    UnvalidatedPlaySoundS2CPacket(sound, soundSource, player.x, player.y, player.z, volume, pitch)
-                packet.sendToPlayer(player)
-            }
-            map["is_party_at_full_health"] = { _ ->
-                DoubleValue(player.party().none(Pokemon::canBeHealed))
-            }
-            map["can_heal_at_healer"] = put@{ params ->
-                val pos = params.get<ArrayStruct>(0).asBlockPos()
-                val healer = player.level().getBlockEntity(pos, CobblemonBlockEntities.HEALING_MACHINE).orElse(null)
-                    ?: return@put DoubleValue.ZERO
-                val party = player.party()
-                return@put DoubleValue(healer.canHeal(party))
-            }
-            map["put_pokemon_in_healer"] = put@{ params ->
-                val healer = player.level()
-                    .getBlockEntity(params.get<ArrayStruct>(0).asBlockPos(), CobblemonBlockEntities.HEALING_MACHINE)
-                    .orElse(null) ?: return@put DoubleValue.ZERO
-                val party = player.party()
-                if (healer.canHeal(party)) {
-                    healer.activate(player.uuid, party)
-                    return@put DoubleValue.ONE
-                } else {
-                    return@put DoubleValue.ZERO
+                    val packet =
+                        UnvalidatedPlaySoundS2CPacket(
+                            sound,
+                            soundSource,
+                            player.x,
+                            player.y,
+                            player.z,
+                            volume,
+                            pitch,
+                        )
+
+                    packet.sendToPlayer(player)
                 }
-            }
-            map["party"] = { player.party().struct }
-            map["pc"] = { player.pc().struct }
-            map["has_permission"] = { params ->
-                DoubleValue(
-                    Cobblemon.permissionValidator.hasPermission(
-                        player,
-                        params.getString(0),
-                        params.getIntOrNull(1) ?: 4
+                functions["is_party_at_full_health"] = { DoubleValue(player.party().none(Pokemon::canBeHealed)) }
+                functions["can_heal_at_healer"] = canHealAtHealer@{ params ->
+                    val pos = params.get<ArrayStruct>(0).asBlockPos()
+                    val healer =
+                        player.level().getBlockEntity(pos, CobblemonBlockEntities.HEALING_MACHINE).orElse(null)
+                            ?: return@canHealAtHealer DoubleValue.ZERO
+                    val party = player.party()
+                    DoubleValue(healer.canHeal(party))
+                }
+                functions["put_pokemon_in_healer"] = putPokemonAtHealer@{ params ->
+                    val healer =
+                        player
+                            .level()
+                            .getBlockEntity(
+                                params.get<ArrayStruct>(0).asBlockPos(),
+                                CobblemonBlockEntities.HEALING_MACHINE,
+                            ).orElse(null) ?: return@putPokemonAtHealer DoubleValue.ZERO
+                    val party = player.party()
+                    if (healer.canHeal(party)) {
+                        healer.activate(player.uuid, party)
+                        return@putPokemonAtHealer DoubleValue.ONE
+                    }
+                    DoubleValue.ZERO
+                }
+                functions["party"] = { player.party().struct }
+                functions["pc"] = { player.pc().struct }
+                functions["has_permission"] = { params ->
+                    DoubleValue(
+                        Cobblemon.permissionValidator.hasPermission(
+                            player,
+                            params.getString(0),
+                            params.getIntOrNull(1) ?: 4,
+                        ),
                     )
-                )
-            }
-            map["data"] = { params -> Cobblemon.molangData.load(player.uuid, params.getStringOrNull(0)) }
-            map["save_data"] = { params -> Cobblemon.molangData.save(player.uuid, params.getStringOrNull(0)) }
-            map["in_battle"] = { DoubleValue(player.isInBattle()) }
-            map["battle"] = { player.getBattleState()?.first?.struct ?: DoubleValue.ZERO }
-            map["get_npc_data"] = put@{ params ->
-                val npcId = ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
-                    ?: params.getString(0)
-                val data = Cobblemon.molangData.load(player.uuid, params.getStringOrNull(1))
-                if (data.map.containsKey(npcId)) {
-                    return@put data.map[npcId]!!
-                } else {
+                }
+                functions["data"] = { params -> Cobblemon.molangData.load(player.uuid, params.getStringOrNull(0)) }
+                functions["save_data"] = { params -> Cobblemon.molangData.save(player.uuid, params.getStringOrNull(0)) }
+                functions["in_battle"] = { DoubleValue(player.isInBattle()) }
+                functions["battle"] = { player.getBattleState()?.first?.struct ?: DoubleValue.ZERO }
+                functions["get_npc_data"] = getNpcData@{ params ->
+                    val npcId =
+                        ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
+                            ?: params.getString(0)
+                    val data = Cobblemon.molangData.load(player.uuid, params.getStringOrNull(1))
+                    if (data.map.containsKey(npcId)) {
+                        return@getNpcData data.map[npcId]!!
+                    }
+
                     val vars = VariableStruct()
                     data.map[npcId] = vars
-                    return@put vars
+                    vars
                 }
-            }
-            map["get_npc_variable"] = put@{ params ->
-                val npcId = ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
-                    ?: params.getString(0)
-                val variable = params.getString(1)
-                val data = Cobblemon.molangData.load(player.uuid, params.getStringOrNull(2))
-                if (data.map.containsKey(npcId)) {
-                    return@put (data.map[npcId] as VariableStruct).map[variable] ?: DoubleValue.ZERO
-                } else {
-                    return@put DoubleValue.ZERO
-                }
-            }
-            map["set_npc_variable"] = put@{ params ->
-                val npcId = ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
-                    ?: params.getString(0)
-                val variable = params.getString(1)
-                val value = params.get<MoValue>(2)
-                val saveAfterwards = params.getBooleanOrNull(3) != false
-                val path = params.getStringOrNull(4)
-                val data = Cobblemon.molangData.load(player.uuid, path)
-                val npcData = data.map.getOrPut(npcId) { VariableStruct() } as VariableStruct
-                npcData.map[variable] = value
-                if (saveAfterwards) {
-                    Cobblemon.molangData.save(player.uuid, path)
-                }
-                return@put DoubleValue.ONE
-            }
-            map["pokedex"] = { player.pokedex().struct }
-            map["has_advancement"] = put@{ params ->
-                val requiredAdvancement = ResourceLocation.parse(params.getString(0))
-                for (entry in player.advancements.progress) {
-                    if (entry.key.id == requiredAdvancement && entry.value.isDone) {
-                        return@put DoubleValue.ONE
+                functions["get_npc_variable"] = getNpcVariable@{ params ->
+                    val npcId =
+                        ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
+                            ?: params.getString(0)
+                    val variable = params.getString(1)
+                    val data = Cobblemon.molangData.load(player.uuid, params.getStringOrNull(2))
+                    if (data.map.containsKey(npcId)) {
+                        return@getNpcVariable (data.map[npcId] as VariableStruct).map[variable] ?: DoubleValue.ZERO
                     }
+                    DoubleValue.ZERO
                 }
-                return@put DoubleValue.ZERO
-            }
-            map["has_tm_move_unlocked"] = put@{ params ->
-                val move = Moves.getByName(params.getString(0)) ?: return@put DoubleValue.ZERO
-                val tm = TechnicalMachines.moveToTM[move] ?: return@put DoubleValue.ZERO
-                DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 1.0 else 0.0)
-            }
-            map["unlock_tm_move"] = put@{ params ->
-                val move = Moves.getByName(params.getString(0)) ?: return@put DoubleValue.ZERO
-                val tm = TechnicalMachines.moveToTM[move] ?: return@put DoubleValue.ZERO
-                player.tmList().syncTMFromMove(move)
-                DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 1.0 else 0.0)
-            }
-            map["lock_tm_move"] = put@{ params ->
-                val move = Moves.getByName(params.getString(0)) ?: return@put DoubleValue.ZERO
-                val tm = TechnicalMachines.moveToTM[move] ?: return@put DoubleValue.ZERO
-                player.tmList().syncTMLockFromMove(move)
-                DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 0.0 else 1.0)
-            }
-            map["start_battle"] = put@{ params ->
-                val opponentValue = params.get<MoValue>(0)
-                val opponent = if (opponentValue is ObjectValue<*>) {
-                    opponentValue.obj as ServerPlayer
-                } else {
-                    val paramString = opponentValue.asString()
-                    val playerUUID = paramString.asUUID
-                    if (playerUUID != null) {
-                        server()?.playerList?.getPlayer(playerUUID) ?: return@put DoubleValue.ZERO
-                    } else {
-                        server()?.playerList?.getPlayerByName(paramString) ?: return@put DoubleValue.ZERO
+                functions["set_npc_variable"] = { params ->
+                    val npcId =
+                        ((params.get<MoValue>(0) as? ObjectValue<*>)?.obj as? NPCEntity)?.stringUUID
+                            ?: params.getString(0)
+                    val variable = params.getString(1)
+                    val value = params.get<MoValue>(2)
+                    val saveAfterwards = params.getBooleanOrNull(3) != false
+                    val path = params.getStringOrNull(4)
+                    val data = Cobblemon.molangData.load(player.uuid, path)
+                    val npcData = data.map.getOrPut(npcId) { VariableStruct() } as VariableStruct
+                    npcData.map[variable] = value
+                    if (saveAfterwards) {
+                        Cobblemon.molangData.save(player.uuid, path)
                     }
+                    DoubleValue.ONE
                 }
-                val format = params.getStringOrNull(1)
-                    ?.let(BattleFormat::fromFormatIdentifier)
-                    ?: BattleFormat.GEN_9_SINGLES
+                functions["pokedex"] = { player.pokedex().struct }
+                functions["has_advancement"] = hasAdvancement@{ params ->
+                    val requiredAdvancement = ResourceLocation.parse(params.getString(0))
+                    player.advancements.progress.forEach { (holder, progress) ->
+                        if (holder.id == requiredAdvancement && progress.isDone) {
+                            return@hasAdvancement DoubleValue.ONE
+                        }
+                    }
+                    DoubleValue.ZERO
+                }
+                functions["has_tm_move_unlocked"] = hasTmMoveUnlocked@{ params ->
+                    val move = Moves.getByName(params.getString(0)) ?: return@hasTmMoveUnlocked DoubleValue.ZERO
+                    val tm = TechnicalMachines.moveToTM[move] ?: return@hasTmMoveUnlocked DoubleValue.ZERO
+                    DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 1.0 else 0.0)
+                }
+                functions["unlock_tm_move"] = unlockTmMove@{ params ->
+                    val move = Moves.getByName(params.getString(0)) ?: return@unlockTmMove DoubleValue.ZERO
+                    val tm = TechnicalMachines.moveToTM[move] ?: return@unlockTmMove DoubleValue.ZERO
+                    player.tmList().syncTMFromMove(move)
+                    DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 1.0 else 0.0)
+                }
+                functions["lock_tm_move"] = lockTmMove@{ params ->
+                    val move = Moves.getByName(params.getString(0)) ?: return@lockTmMove DoubleValue.ZERO
+                    val tm = TechnicalMachines.moveToTM[move] ?: return@lockTmMove DoubleValue.ZERO
+                    player.tmList().syncTMLockFromMove(move)
+                    DoubleValue(if (player.tmList().learnedTMs.contains(tm.id)) 0.0 else 1.0)
+                }
+                functions["start_battle"] = startBattle@{ params ->
+                    val opponentValue = params.get<MoValue>(0)
+                    val opponent =
+                        if (opponentValue is ObjectValue<*>) {
+                            opponentValue.obj as ServerPlayer
+                        } else {
+                            val paramString = opponentValue.asString()
+                            val playerUUID = paramString.asUUID
+                            if (playerUUID != null) {
+                                server()?.playerList?.getPlayer(playerUUID) ?: return@startBattle DoubleValue.ZERO
+                            } else {
+                                server()?.playerList?.getPlayerByName(paramString)
+                                    ?: return@startBattle DoubleValue.ZERO
+                            }
+                        }
+                    val format =
+                        params
+                            .getStringOrNull(1)
+                            ?.let(BattleFormat::fromFormatIdentifier)
+                            ?: BattleFormat.GEN_9_SINGLES
 
-                val setLevel = params.getIntOrNull(2) ?: -1
-                format.adjustLevel = setLevel
+                    val setLevel = params.getIntOrNull(2) ?: -1
+                    format.adjustLevel = setLevel
 
-                val rules = params.getStringOrNull(5)
-                    ?.split(",")
-                    ?.toSet()
-                    ?: emptySet()
+                    val rules =
+                        params
+                            .getStringOrNull(5)
+                            ?.split(",")
+                            ?.toSet()
+                            ?: emptySet()
 
-                val modifiedBattleFormat = BattleFormat.setBattleRules(
-                    battleFormat = format,
-                    rules = rules
-                )
+                    val modifiedBattleFormat =
+                        BattleFormat.setBattleRules(
+                            battleFormat = format,
+                            rules = rules,
+                        )
 
-                val cloneParties = (setLevel != -1) || (params.getBooleanOrNull(3) ?: false)
-                val healFirst = params.getBooleanOrNull(4) ?: false
+                    val cloneParties = (setLevel != -1) || (params.getBooleanOrNull(3) ?: false)
+                    val healFirst = params.getBooleanOrNull(4) ?: false
 
-                val battleStartResult = BattleBuilder.pvp1v1(
-                    player1 = player,
-                    player2 = opponent,
-                    battleFormat = modifiedBattleFormat,
-                    cloneParties = cloneParties,
-                    healFirst = healFirst
-                )
-                var returnValue: MoValue = DoubleValue.ZERO
-                battleStartResult.ifSuccessful { returnValue = it.struct }
-                return@put returnValue
+                    val battleStartResult =
+                        BattleBuilder.pvp1v1(
+                            player1 = player,
+                            player2 = opponent,
+                            battleFormat = modifiedBattleFormat,
+                            cloneParties = cloneParties,
+                            healFirst = healFirst,
+                        )
+                    var returnValue: MoValue = DoubleValue.ZERO
+                    battleStartResult.ifSuccessful { returnValue = it.struct }
+                    returnValue
+                }
+                functions["get_custom_stat"] = getCustomStat@{ params ->
+                    val statName = params.getString(0)
+
+                    val resourceLocation = ResourceLocation.tryParse(statName) ?: return@getCustomStat DoubleValue.ZERO
+                    val statResourceLocation =
+                        BuiltInRegistries.CUSTOM_STAT.get(resourceLocation) ?: return@getCustomStat DoubleValue.ZERO
+
+                    val exists = Stats.CUSTOM.contains(statResourceLocation)
+                    if (!exists) return@getCustomStat DoubleValue.ZERO
+
+                    val stat = Stats.CUSTOM.get(statResourceLocation)
+                    val value = player.stats.getValue(stat)
+
+                    DoubleValue(value)
+                }
+                functions["get_starter_uuid"] = {
+                    Cobblemon.playerDataManager.getGenericData(player).starterUUID?.let {
+                        StringValue(
+                            it.toString(),
+                        )
+                    } ?: DoubleValue.ZERO
+                }
+                functions["has_chosen_starter"] = {
+                    DoubleValue(Cobblemon.playerDataManager.getGenericData(player).starterSelected)
+                }
             }
-            map["get_custom_stat"] = put@{ params ->
-                val statName = params.getString(0)
-
-                val resourceLocation = ResourceLocation.tryParse(statName) ?: return@put DoubleValue.ZERO
-                val statResourceLocation =
-                    BuiltInRegistries.CUSTOM_STAT.get(resourceLocation) ?: return@put DoubleValue.ZERO
-
-                val exists = net.minecraft.stats.Stats.CUSTOM.contains(statResourceLocation)
-                if (!exists) return@put DoubleValue.ZERO
-
-                val stat = net.minecraft.stats.Stats.CUSTOM.get(statResourceLocation)
-                val value = player.stats.getValue(stat)
-
-                DoubleValue(value)
-            }
-            map["get_starter_uuid"] = { _ ->
-                Cobblemon.playerDataManager.getGenericData(player).starterUUID?.let {
-                    StringValue(
-                        it.toString()
-                    )
-                } ?: DoubleValue.ZERO
-            }
-            map["has_chosen_starter"] = { _ -> DoubleValue(Cobblemon.playerDataManager.getGenericData(player).starterSelected) }
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PokedexMoLangFunctions.kt

@@ -27,57 +27,69 @@ import com.cobblemon.mod.common.util.getStringOrNull
 object PokedexMoLangFunctions : AbstractMoLangFunctionHolder<AbstractPokedexManager>() {
     override fun AbstractPokedexManager.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val pokedex = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["get_species_record"] = { params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["get_species_record"] = { params ->
             val speciesId = params.getString(0).asIdentifierDefaultingNamespace()
             pokedex.speciesRecords[speciesId]?.struct ?: QueryStruct(hashMapOf())
         }
 
-        map["has_seen"] = put@{ params ->
+        functions["has_seen"] = hasSeen@{ params ->
             val speciesId = params.getString(0).asIdentifierDefaultingNamespace()
-            val formName = params.getStringOrNull(1)
+            val formName =
+                params.getStringOrNull(1)
+                    ?: return@hasSeen DoubleValue(
+                        pokedex.getHighestKnowledgeForSpecies(speciesId).ordinal >= PokedexEntryProgress.SEEN.ordinal,
+                    )
 
-            if (formName == null) {
-                return@put DoubleValue(pokedex.getHighestKnowledgeForSpecies(speciesId).ordinal >= PokedexEntryProgress.SEEN.ordinal)
-            } else {
-                return@put DoubleValue(
-                    (pokedex.getSpeciesRecord(speciesId)?.getFormRecord(formName)?.knowledge?.ordinal
-                        ?: 0) >= PokedexEntryProgress.SEEN.ordinal
-                )
-            }
+            DoubleValue(
+                (
+                    pokedex
+                        .getSpeciesRecord(speciesId)
+                        ?.getFormRecord(formName)
+                        ?.knowledge
+                        ?.ordinal
+                        ?: 0
+                ) >= PokedexEntryProgress.SEEN.ordinal,
+            )
         }
 
-        map["has_caught"] = put@{ params ->
+        functions["has_caught"] = hasCaught@{ params ->
             val speciesId = params.getString(0).asIdentifierDefaultingNamespace()
-            val formName = params.getStringOrNull(1)
-            if (formName == null) {
-                return@put DoubleValue(pokedex.getHighestKnowledgeForSpecies(speciesId) == PokedexEntryProgress.OWNED)
-            } else {
-                return@put DoubleValue(
-                    pokedex.getSpeciesRecord(speciesId)
-                        ?.getFormRecord(formName)?.knowledge == PokedexEntryProgress.OWNED
+            val formName =
+                params.getStringOrNull(1) ?: return@hasCaught DoubleValue(
+                    pokedex.getHighestKnowledgeForSpecies(
+                        speciesId,
+                    ) == PokedexEntryProgress.OWNED,
                 )
-            }
+            DoubleValue(
+                pokedex
+                    .getSpeciesRecord(speciesId)
+                    ?.getFormRecord(formName)
+                    ?.knowledge == PokedexEntryProgress.OWNED,
+            )
         }
-        map["caught_count"] = { DoubleValue(pokedex.getGlobalCalculatedValue(CaughtCount)) }
-        map["seen_count"] = { DoubleValue(pokedex.getGlobalCalculatedValue(SeenCount)) }
-        map["caught_percent"] = { DoubleValue(pokedex.getGlobalCalculatedValue(CaughtPercent)) }
-        map["seen_percent"] = { DoubleValue(pokedex.getGlobalCalculatedValue(SeenPercent)) }
+        functions["caught_count"] = { DoubleValue(pokedex.getGlobalCalculatedValue(CaughtCount)) }
+        functions["seen_count"] = { DoubleValue(pokedex.getGlobalCalculatedValue(SeenCount)) }
+        functions["caught_percent"] = { DoubleValue(pokedex.getGlobalCalculatedValue(CaughtPercent)) }
+        functions["seen_percent"] = { DoubleValue(pokedex.getGlobalCalculatedValue(SeenPercent)) }
 
-        if (pokedex is PokedexManager) {
-            map["player_id"] = { StringValue(pokedex.uuid.toString()) }
-            map["see"] = put@{ params ->
-                val pokemon = params.get<ObjectValue<Pokemon>>(0).obj
-                pokedex.encounter(pokemon)
-                return@put DoubleValue.ONE
-            }
-            map["catch"] = put@{ params ->
-                val pokemon = params.get<ObjectValue<Pokemon>>(0).obj
-                pokedex.obtain(pokemon)
-                return@put DoubleValue.ONE
+        when (pokedex) {
+            is PokedexManager -> {
+                functions["player_id"] = { StringValue(pokedex.uuid.toString()) }
+                functions["see"] = { params ->
+                    val pokemon = params.get<ObjectValue<Pokemon>>(0).obj
+                    pokedex.encounter(pokemon)
+                    DoubleValue.ONE
+                }
+                functions["catch"] = { params ->
+                    val pokemon = params.get<ObjectValue<Pokemon>>(0).obj
+                    pokedex.obtain(pokemon)
+                    DoubleValue.ONE
+                }
             }
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PokemonEntityMoLangFunctions.kt

@@ -32,100 +32,113 @@ import com.cobblemon.mod.common.util.withQueryValue
 object PokemonEntityMoLangFunctions : AbstractMoLangFunctionHolder<PokemonEntity>() {
     override fun PokemonEntity.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val pokemonEntity = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["is_busy"] = { DoubleValue(pokemonEntity.isBusy) }
-        map["in_battle"] = { DoubleValue(pokemonEntity.isBattling) }
-        map["is_moving"] = { DoubleValue((pokemonEntity.moveControl as? PokemonMoveControl)?.hasWanted() == true) }
-        map["is_flying"] = { DoubleValue(pokemonEntity.getBehaviourFlag(PokemonBehaviourFlag.FLYING)) }
-        map["get_riding_state"] = { params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["is_busy"] = { DoubleValue(pokemonEntity.isBusy) }
+        functions["in_battle"] = { DoubleValue(pokemonEntity.isBattling) }
+        functions["is_moving"] =
+            { DoubleValue((pokemonEntity.moveControl as? PokemonMoveControl)?.hasWanted() == true) }
+        functions["is_flying"] = { DoubleValue(pokemonEntity.getBehaviourFlag(PokemonBehaviourFlag.FLYING)) }
+        functions["get_riding_state"] = { params ->
             val name = params.getStringOrNull(0)
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions[name]?.apply(MoParams.EMPTY) as? MoValue ?: moValue
             }
         }
-        map["is_gliding"] = {
+        functions["is_gliding"] = {
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions["gliding"]?.apply(MoParams.EMPTY) as? MoValue
                     ?: DoubleValue.ZERO
             }
         }
-        map["is_sprinting"] = {
+        functions["is_sprinting"] = {
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions["sprinting"]?.apply(MoParams.EMPTY) as? MoValue
                     ?: DoubleValue.ZERO
             }
         }
-        map["is_drifting"] = {
+        functions["is_drifting"] = {
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions["drifting"]?.apply(MoParams.EMPTY) as? MoValue
                     ?: DoubleValue.ZERO
             }
         }
-        map["is_powered_drifting"] = {
+        functions["is_powered_drifting"] = {
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions["powered_drifting"]?.apply(MoParams.EMPTY) as? MoValue
                     ?: DoubleValue.ZERO
             }
         }
-        map["in_air"] = {
+        functions["in_air"] = {
             pokemonEntity.ifRidingAvailableSupply(DoubleValue.ZERO) { behaviour, settings, state ->
                 val moValue = behaviour.asMoLangValue(settings, state, pokemonEntity)
                 return@ifRidingAvailableSupply moValue.functions["in_air"]?.apply(MoParams.EMPTY) as? MoValue
                     ?: DoubleValue.ZERO
             }
         }
-        map["is_wild"] = { DoubleValue(pokemonEntity.ownerUUID == null) }
-        map["is_in_party"] = { DoubleValue(pokemonEntity.pokemon.storeCoordinates.get()?.store is PartyStore) }
-        map["is_ridden"] = { DoubleValue(pokemonEntity.hasControllingPassenger()) }
-        map["has_aspect"] = { DoubleValue(it.getString(0) in pokemonEntity.aspects) }
-        map["is_pokemon"] = { DoubleValue.ONE }
-        map["is_holding_item"] = {
-            DoubleValue(!pokemonEntity.entityData.get(PokemonEntity.SHOWN_HELD_ITEM).let {
-                it.isEmpty || it.`is`(CobblemonItemTags.WEARABLE_HAT_ITEMS) || it.`is`(CobblemonItemTags.WEARABLE_FACE_ITEMS)
-            })
+        functions["is_wild"] = { DoubleValue(pokemonEntity.ownerUUID == null) }
+        functions["is_in_party"] = {
+            DoubleValue(
+                pokemonEntity.pokemon.storeCoordinates
+                    .get()
+                    ?.store is PartyStore,
+            )
         }
-        map["riding_style"] = {
-            StringValue(pokemonEntity.ifRidingAvailableSupply("") { behaviour, settings, state ->
-                behaviour.getRidingStyle(settings, state).name
-            })
+        functions["is_ridden"] = { DoubleValue(pokemonEntity.hasControllingPassenger()) }
+        functions["has_aspect"] = { DoubleValue(it.getString(0) in pokemonEntity.aspects) }
+        functions["is_pokemon"] = { DoubleValue.ONE }
+        functions["is_holding_item"] = {
+            DoubleValue(
+                !pokemonEntity.entityData.get(PokemonEntity.SHOWN_HELD_ITEM).let {
+                    it.isEmpty || it.`is`(CobblemonItemTags.WEARABLE_HAT_ITEMS) || it.`is`(CobblemonItemTags.WEARABLE_FACE_ITEMS)
+                },
+            )
         }
-        map["is_wearing_hat"] = {
+        functions["riding_style"] = {
+            StringValue(
+                pokemonEntity.ifRidingAvailableSupply("") { behaviour, settings, state ->
+                    behaviour.getRidingStyle(settings, state).name
+                },
+            )
+        }
+        functions["is_wearing_hat"] = {
             DoubleValue(
                 pokemonEntity.entityData
                     .get(PokemonEntity.SHOWN_HELD_ITEM)
-                    .`is`(CobblemonItemTags.WEARABLE_HAT_ITEMS)
+                    .`is`(CobblemonItemTags.WEARABLE_HAT_ITEMS),
             )
         }
-        map["is_wearing_face"] = {
+        functions["is_wearing_face"] = {
             DoubleValue(
                 pokemonEntity.entityData
                     .get(PokemonEntity.SHOWN_HELD_ITEM)
-                    .`is`(CobblemonItemTags.WEARABLE_FACE_ITEMS)
+                    .`is`(CobblemonItemTags.WEARABLE_FACE_ITEMS),
             )
         }
-        map["is_pastured"] = {
+        functions["is_pastured"] = {
             DoubleValue((pokemonEntity.tethering != null))
         }
-        map["pasture_conflict_enabled"] = {
+        functions["pasture_conflict_enabled"] = {
             DoubleValue(pokemonEntity.getBehaviourFlag(PokemonBehaviourFlag.PASTURE_CONFLICT))
         }
-        map["run_action_effect"] = runActionEffect@{ params ->
+        functions["run_action_effect"] = runActionEffect@{ params ->
             val runtime = MoLangRuntime().setup()
             runtime.environment.cloneFrom(params.environment)
             runtime.withQueryValue("entity", pokemonEntity.struct)
             val actionEffect = ActionEffects.actionEffects[params.getString(0).asIdentifierDefaultingNamespace()]
             if (actionEffect != null) {
-                val context = ActionEffectContext(
-                    actionEffect = actionEffect,
-                    providers = mutableListOf(TargetsProvider(pokemonEntity)),
-                    runtime = runtime,
-                    level = pokemonEntity.level()
-                )
+                val context =
+                    ActionEffectContext(
+                        actionEffect = actionEffect,
+                        providers = mutableListOf(TargetsProvider(pokemonEntity)),
+                        runtime = runtime,
+                        level = pokemonEntity.level(),
+                    )
                 // This was taken from NPC run_action_effect but this variable isn't used, so I just commented it out.
                 // pokemonEntity.actionEffect = context
                 pokemonEntity.brain.setMemory(CobblemonMemories.ACTIVE_ACTION_EFFECT, context)
@@ -135,14 +148,16 @@ object PokemonEntityMoLangFunctions : AbstractMoLangFunctionHolder<PokemonEntity
                         pokemonEntity.brain.getMemory(CobblemonMemories.ACTIVE_ACTION_EFFECT).orElse(null)
                     if (pokemonActionEffect == context && pokemonEntity.brain.isActive(CobblemonActivities.ACTION_EFFECT)) {
                         pokemonEntity.brain.eraseMemory(CobblemonMemories.ACTIVE_ACTION_EFFECT)
-                        //pokemonEntity.actionEffect = null
+                        // pokemonEntity.actionEffect = null
                     }
                 }
 
                 return@runActionEffect DoubleValue.ONE
             }
-            return@runActionEffect DoubleValue.ZERO
+
+            DoubleValue.ZERO
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PokemonMoLangFunctions.kt

@@ -33,218 +33,214 @@ import com.cobblemon.mod.common.util.getDoubleOrNull
 import com.cobblemon.mod.common.util.getIntOrNull
 import com.cobblemon.mod.common.util.server
 import com.cobblemon.mod.common.util.toProperties
-import kotlin.random.Random
 import net.minecraft.resources.ResourceLocation
+import kotlin.random.Random
 
 object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
     override fun Pokemon.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val pokemon = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["id"] = { StringValue(pokemon.uuid.toString()) }
-        map["nickname"] = { StringValue(pokemon.nickname.toString()) }
-        map["level"] = { DoubleValue(pokemon.level.toDouble()) }
-        map["max_hp"] = { DoubleValue(pokemon.maxHealth.toDouble()) }
-        map["current_hp"] = { DoubleValue(pokemon.currentHealth.toDouble()) }
-        map["friendship"] = { DoubleValue(pokemon.friendship.toDouble()) }
-        map["max_fullness"] = { DoubleValue(pokemon.getMaxFullness().toDouble()) }
-        map["fullness"] = { DoubleValue(pokemon.currentFullness.toDouble()) }
-        map["lose_fullness"] = { params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["id"] = { StringValue(pokemon.uuid.toString()) }
+        functions["nickname"] = { StringValue(pokemon.nickname.toString()) }
+        functions["level"] = { DoubleValue(pokemon.level.toDouble()) }
+        functions["max_hp"] = { DoubleValue(pokemon.maxHealth.toDouble()) }
+        functions["current_hp"] = { DoubleValue(pokemon.currentHealth.toDouble()) }
+        functions["friendship"] = { DoubleValue(pokemon.friendship.toDouble()) }
+        functions["max_fullness"] = { DoubleValue(pokemon.getMaxFullness().toDouble()) }
+        functions["fullness"] = { DoubleValue(pokemon.currentFullness.toDouble()) }
+        functions["lose_fullness"] = { params ->
             val amount = params.getDouble(0)
             pokemon.loseFullness(amount.toInt())
         }
-        map["feed_pokemon"] = { params ->
+        functions["feed_pokemon"] = { params ->
             val amount = params.getDouble(0)
             val playSound = params.getBooleanOrNull(1) ?: true
             pokemon.feedPokemon(amount.toInt(), playSound)
         }
-        map["behaviour"] = { pokemon.form.behaviour.struct }
-        map["behavior"] = { pokemon.form.behaviour.struct } // Inferior
-        map["pokeball"] = { StringValue(pokemon.caughtBall.toString()) }
-        map["ability"] = { StringValue(pokemon.ability.name) }
-        map["has_learned"] = put@{ params ->
+        functions["behaviour"] = { pokemon.form.behaviour.struct }
+        functions["behavior"] = { pokemon.form.behaviour.struct } // Inferior
+        functions["pokeball"] = { StringValue(pokemon.caughtBall.toString()) }
+        functions["ability"] = { StringValue(pokemon.ability.name) }
+        functions["has_learned"] = hasLearned@{ params ->
             val moveName = params.getString(0)
             val move = pokemon.allAccessibleMoves.find { it.name == moveName }
-            if (move != null) {
-                return@put DoubleValue.ONE
-            } else {
-                return@put DoubleValue.ZERO
-            }
+            if (move != null) return@hasLearned DoubleValue.ONE
+            DoubleValue.ZERO
         }
-        map["moveset"] = {
+        functions["moveset"] = {
             val struct = QueryStruct(hashMapOf())
             for ((index, move) in pokemon.moveSet.withIndex()) {
                 struct.addFunction(index.toString()) { move.struct }
             }
             struct
         }
-        map["evs"] = {
+        functions["evs"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in Stats.PERMANENT) {
                 struct.addFunction(stat.showdownId) { DoubleValue(pokemon.evs.getOrDefault(stat).toDouble()) }
             }
             struct
         }
-        map["ivs"] = {
+        functions["ivs"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in Stats.PERMANENT) {
                 struct.addFunction(stat.showdownId) { DoubleValue(pokemon.ivs.getOrDefault(stat).toDouble()) }
             }
             struct
         }
-        map["hyper_trained_ivs"] = {
+        functions["hyper_trained_ivs"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in Stats.PERMANENT) {
                 struct.addFunction(stat.showdownId) { DoubleValue(pokemon.ivs.hyperTrainedIVs[stat] ?: -1.0) }
             }
             struct
         }
-        map["ride_boosts"] = {
+        functions["ride_boosts"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in RidingStat.entries) {
                 struct.addFunction(stat.name.lowercase()) { DoubleValue(pokemon.getRideBoost(stat)) }
             }
             struct
         }
-        map["natdex_number"] = {
+        functions["natdex_number"] = {
             DoubleValue(pokemon.species.nationalPokedexNumber.toDouble())
         }
-        map["types"] = {
-            pokemon.form.types.map { it.showdownId }.asArrayValue(::StringValue)
+        functions["types"] = {
+            pokemon.form.types
+                .map { it.showdownId }
+                .asArrayValue(::StringValue)
         }
-        map["gender_ratio"] = {
+        functions["gender_ratio"] = {
             DoubleValue(pokemon.form.maleRatio.toDouble())
         }
-        map["ev_yield"] = {
+        functions["ev_yield"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in Stats.PERMANENT) {
                 struct.addFunction(stat.showdownId) { DoubleValue(pokemon.form.evYield[stat]?.toDouble()) }
             }
             struct
         }
-        map["base_stats"] = {
+        functions["base_stats"] = {
             val struct = QueryStruct(hashMapOf())
             for (stat in Stats.PERMANENT) {
                 struct.addFunction(stat.showdownId) { DoubleValue(pokemon.form.baseStats[stat]?.toDouble()) }
             }
             struct
         }
-        map["catch_rate"] = {
+        functions["catch_rate"] = {
             DoubleValue(pokemon.form.catchRate.toDouble())
         }
-        map["base_experience_yield"] = {
+        functions["base_experience_yield"] = {
             DoubleValue(pokemon.form.baseExperienceYield.toDouble())
         }
-        map["drops"] = {
+        functions["drops"] = {
             val struct = QueryStruct(hashMapOf())
-            for ((index, drop) in pokemon.form.drops.entries.withIndex()) {
+            for ((index, drop) in pokemon.form.drops.entries
+                .withIndex()) {
                 struct.addFunction(index.toString()) { drop }
             }
             struct
         }
-        map["tm_learnset"] = {
+        functions["tm_learnset"] = {
             val struct = QueryStruct(hashMapOf())
-            for ((index, move) in pokemon.form.moves.tmMoves.withIndex()) {
+            for ((index, move) in pokemon.form.moves.tmMoves
+                .withIndex()) {
                 struct.addFunction(index.toString()) { move.struct }
             }
             struct
         }
-        map["egg_learnset"] = {
+        functions["egg_learnset"] = {
             val struct = QueryStruct(hashMapOf())
-            for ((index, move) in pokemon.form.moves.eggMoves.withIndex()) {
+            for ((index, move) in pokemon.form.moves.eggMoves
+                .withIndex()) {
                 struct.addFunction(index.toString()) { move.struct }
             }
             struct
         }
-        map["tutor_learnset"] = {
+        functions["tutor_learnset"] = {
             val struct = QueryStruct(hashMapOf())
-            for ((index, move) in pokemon.form.moves.tutorMoves.withIndex()) {
+            for ((index, move) in pokemon.form.moves.tutorMoves
+                .withIndex()) {
                 struct.addFunction(index.toString()) { move.struct }
             }
             struct
         }
-        map["level_learnset"] = {
+        functions["level_learnset"] = {
             val struct = QueryStruct(hashMapOf())
             for ((index, move) in pokemon.form.moves.levelUpMoves) {
                 struct.addFunction(index.toString()) { move }
             }
             struct
         }
-        map["ability_pool"] = {
+        functions["ability_pool"] = {
             val struct = QueryStruct(hashMapOf())
             for ((index, ability) in pokemon.form.abilities.withIndex()) {
                 struct.addFunction(index.toString()) { StringValue(ability.toString()) }
             }
             struct
         }
-        map["egg_groups"] = {
+        functions["egg_groups"] = {
             val struct = QueryStruct(hashMapOf())
             for ((index, group) in pokemon.form.eggGroups.withIndex()) {
                 struct.addFunction(index.toString()) { StringValue(group.toString()) }
             }
             struct
         }
-        map["egg_cycles"] = {
+        functions["egg_cycles"] = {
             DoubleValue(pokemon.species.eggCycles.toDouble())
         }
-        map["labels"] = {
+        functions["labels"] = {
             val struct = QueryStruct(hashMapOf())
             for ((index, label) in pokemon.form.labels.withIndex()) {
                 struct.addFunction(index.toString()) { StringValue(label) }
             }
             struct
         }
-        map["aspects"] = {
+        functions["aspects"] = {
             val aspects = pokemon.aspects
             aspects.asArrayValue { StringValue(it) }
         }
-        map["form_aspects"] = {
+        functions["form_aspects"] = {
             val aspects = pokemon.form.aspects
             aspects.asArrayValue { StringValue(it) }
         }
-        map["form_name"] = {
+        functions["form_name"] = {
             StringValue(pokemon.form.name)
         }
         // Yes, this is the lazy call for a single hardcoded pre-evolution.
         // Lol. Lmao, even.
         // TO-DO: Subscribe to [PokemonSpecies.observable].
-        // Gito: surely this is just a typo, right? not touching the function name just in case
-        map["prevolution"] = preEvolution@{
-            val preEvolution = pokemon.species.preEvolution ?: return@preEvolution DoubleValue.ZERO
-            return@preEvolution preEvolution
-        }
-        map["nature"] = { StringValue(pokemon.nature.toString()) }
-        map["is_wild"] = { DoubleValue(pokemon.entity?.let { it.ownerUUID == null } == true) }
-        map["is_shiny"] = { DoubleValue(pokemon.shiny) }
-        map["is_in_party"] = { DoubleValue(pokemon.storeCoordinates.get()?.store is PartyStore) }
-        map["species"] = { pokemon.species.struct }
-        map["form"] = { StringValue(pokemon.form.name) }
-        map["weight"] = { DoubleValue(pokemon.species.weight.toDouble()) }
-        map["matches"] = { params -> DoubleValue(params.getString(0).toProperties().matches(pokemon)) }
-        map["apply"] = { params ->
+        functions["pre_evolution"] = { pokemon.species.preEvolution ?: DoubleValue.ZERO }
+        functions["nature"] = { StringValue(pokemon.nature.toString()) }
+        functions["is_wild"] = { DoubleValue(pokemon.entity?.let { it.ownerUUID == null } == true) }
+        functions["is_shiny"] = { DoubleValue(pokemon.shiny) }
+        functions["is_in_party"] = { DoubleValue(pokemon.storeCoordinates.get()?.store is PartyStore) }
+        functions["species"] = { pokemon.species.struct }
+        functions["form"] = { StringValue(pokemon.form.name) }
+        functions["weight"] = { DoubleValue(pokemon.species.weight.toDouble()) }
+        functions["matches"] = { params -> DoubleValue(params.getString(0).toProperties().matches(pokemon)) }
+        functions["apply"] = { params ->
             params.getString(0).toProperties().apply(pokemon)
             DoubleValue.ONE
         }
-        map["owner"] = { pokemon.getOwnerPlayer()?.asMoLangValue() ?: DoubleValue.ZERO }
-        map["held_item"] = { pokemon.heldItem().asMoLangValue(server()!!.registryAccess()) }
-        map["remove_held_item"] = { _ ->
-            pokemon.removeHeldItem()
-        }
-        map["add_aspects"] = { params ->
+        functions["owner"] = { pokemon.getOwnerPlayer()?.asMoLangValue() ?: DoubleValue.ZERO }
+        functions["held_item"] = { pokemon.heldItem().asMoLangValue(server()!!.registryAccess()) }
+        functions["remove_held_item"] = { pokemon.removeHeldItem() }
+        functions["add_aspects"] = { params ->
             for (aspect in params.params) pokemon.forcedAspects += aspect.asString()
             pokemon.updateAspects()
         }
-        map["remove_aspects"] = { params ->
+        functions["remove_aspects"] = { params ->
             for (aspect in params.params) pokemon.forcedAspects -= aspect.asString()
             pokemon.updateAspects()
         }
-        map["cosmetic_item"] = {
+        functions["cosmetic_item"] = {
             pokemon.cosmeticItem().asMoLangValue(server()!!.registryAccess())
         }
-        map["remove_cosmetic_item"] = { _ ->
-            pokemon.removeCosmeticItem()
-        }
-        map["marks"] = { _ -> pokemon.marks.asArrayValue { StringValue(it.identifier.toString()) } }
-        map["has_mark"] = { params ->
+        functions["remove_cosmetic_item"] = { pokemon.removeCosmeticItem() }
+        functions["marks"] = { pokemon.marks.asArrayValue { StringValue(it.identifier.toString()) } }
+        functions["has_mark"] = { params ->
             var hasMark = false
             val identifier = params.getString(0).asIdentifierDefaultingNamespace()
             val mark = Marks.getByIdentifier(identifier)
@@ -254,7 +250,7 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
 
             DoubleValue(hasMark)
         }
-        map["remove_marks"] = { params ->
+        functions["remove_marks"] = { params ->
             var removedMark = false
             for (param in params.params) {
                 val identifier = param.asString().asIdentifierDefaultingNamespace()
@@ -267,7 +263,7 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
 
             DoubleValue(removedMark)
         }
-        map["add_marks"] = { params ->
+        functions["add_marks"] = { params ->
             var appliedMark = false
             for (param in params.params) {
                 val identifier = param.asString().asIdentifierDefaultingNamespace()
@@ -280,7 +276,7 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
 
             DoubleValue(appliedMark)
         }
-        map["add_marks_with_chance"] = { params ->
+        functions["add_marks_with_chance"] = { params ->
             var appliedMark = false
             for (param in params.params) {
                 val identifier = param.asString().asIdentifierDefaultingNamespace()
@@ -298,17 +294,15 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
 
             DoubleValue(appliedMark)
         }
-        map["add_potential_marks"] = { params ->
+        functions["add_potential_marks"] = { params ->
             for (param in params.params) {
                 val identifier = param.asString().asIdentifierDefaultingNamespace()
                 val mark = Marks.getByIdentifier(identifier)
                 if (mark != null) pokemon.addPotentialMark(mark)
             }
         }
-        map["apply_potential_marks"] = put@{
-            return@put DoubleValue(pokemon.applyPotentialMarks())
-        }
-        map["hyper_train_iv"] = hyperTrainIv@{ params ->
+        functions["apply_potential_marks"] = { DoubleValue(pokemon.applyPotentialMarks()) }
+        functions["hyper_train_iv"] = hyperTrainIv@{ params ->
             val statId = params.getString(0)
             val stat = Stats.getStat(statId)
             val value = params.getIntOrNull(1) ?: IVs.MAX_VALUE
@@ -321,12 +315,12 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
                 return@hyperTrainIv DoubleValue.ZERO
             }
         }
-        map["add_exp"] = { params ->
+        functions["add_exp"] = { params ->
             val exp = params.getDouble(0).toInt()
             pokemon.addExperience(SidemodExperienceSource("molang"), exp)
             DoubleValue.ONE
         }
-        map["set_iv"] = setIv@{ params ->
+        functions["set_iv"] = setIv@{ params ->
             val statId = params.getString(0)
             val stat = Stats.getStat(statId)
             val value = params.getIntOrNull(1)?.coerceIn(0, IVs.MAX_VALUE) ?: IVs.MAX_VALUE
@@ -338,7 +332,7 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
                 return@setIv DoubleValue.ZERO
             }
         }
-        map["set_ev"] = setEv@{ params ->
+        functions["set_ev"] = setEv@{ params ->
             val statId = params.getString(0)
             val stat = Stats.getStat(statId)
             val value = (params.getIntOrNull(1) ?: 0).coerceIn(0, 255)
@@ -350,49 +344,54 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
                 return@setEv DoubleValue.ZERO
             }
         }
-        map["set_ride_boost"] = setRideBoost@{ params ->
+        functions["set_ride_boost"] = setRideBoost@{ params ->
             val statName = params.getString(0).uppercase()
-            val stat = RidingStat.entries.find { it.name.equals(statName, ignoreCase = true) }
-                ?: return@setRideBoost DoubleValue.ZERO
+            val stat =
+                RidingStat.entries.find { it.name.equals(statName, ignoreCase = true) }
+                    ?: return@setRideBoost DoubleValue.ZERO
             val value = params.getDoubleOrNull(1)?.toFloat() ?: return@setRideBoost DoubleValue.ZERO
 
             pokemon.setRideBoost(stat, value)
-            return@setRideBoost DoubleValue.ONE
+            DoubleValue.ONE
         }
-        map["add_ride_boost"] = addRideBoost@{ params ->
+        functions["add_ride_boost"] = addRideBoost@{ params ->
             val statName = params.getString(0).uppercase()
-            val stat = RidingStat.entries.find { it.name.equals(statName, ignoreCase = true) }
-                ?: return@addRideBoost DoubleValue.ZERO
+            val stat =
+                RidingStat.entries.find { it.name.equals(statName, ignoreCase = true) }
+                    ?: return@addRideBoost DoubleValue.ZERO
             val value = params.getDoubleOrNull(1)?.toFloat() ?: return@addRideBoost DoubleValue.ZERO
 
-            return@addRideBoost DoubleValue(if (pokemon.addRideBoost(stat, value)) 1.0 else 0.0)
+            DoubleValue(if (pokemon.addRideBoost(stat, value)) 1.0 else 0.0)
         }
-        map["initialize_moveset"] = put@{ params ->
+        functions["initialize_moveset"] = initializeMoveset@{ params ->
             val param = params.get<MoValue>(0) ?: StringValue(pokemon.form.defaultWildMovesetBuilder.toString())
             if (param is DoubleValue) {
                 pokemon.initializeMoveset(param == DoubleValue.ONE)
             } else {
                 val movesetBuilderId = ResourceLocation.parse(param.asString())
-                val movesetBuilder = CobblemonMovesetBuilders.movesetBuilders[movesetBuilderId]
-                    ?: run {
-                        Cobblemon.LOGGER.error("Tried initializing moveset from moveset builder ${param.asString()} but it does not exist.")
-                        return@put DoubleValue.ZERO
-                    }
+                val movesetBuilder =
+                    CobblemonMovesetBuilders.movesetBuilders[movesetBuilderId]
+                        ?: run {
+                            Cobblemon.LOGGER.error(
+                                "Tried initializing moveset from moveset builder ${param.asString()} but it does not exist.",
+                            )
+                            return@initializeMoveset DoubleValue.ZERO
+                        }
                 pokemon.initializeMovesetFrom(movesetBuilder)
             }
             DoubleValue.ONE
         }
-        map["validate_moveset"] = { params ->
+        functions["validate_moveset"] = { params ->
             val includeLegacy = params.getBooleanOrNull(0) ?: true
             pokemon.validateMoveset(includeLegacy)
             DoubleValue.ONE
         }
-        map["teach_learnable_moves"] = { params ->
+        functions["teach_learnable_moves"] = { params ->
             val includeLegacy = params.getBooleanOrNull(0) ?: true
             pokemon.teachLearnableMoves(includeLegacy)
             DoubleValue.ONE
         }
-        map["teach_move"] = teachMove@{ params ->
+        functions["teach_move"] = teachMove@{ params ->
             val moveName = params.getString(0)
             val moveTemplate = Moves.getByName(moveName) ?: return@teachMove DoubleValue.ZERO
             val bypass = params.getBooleanOrNull(1) ?: false
@@ -402,8 +401,9 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
                 return@teachMove DoubleValue.ZERO
             }
 
-            val alreadyKnows = pokemon.moveSet.getMoves().any { it.template == moveTemplate } ||
-                pokemon.benchedMoves.any { it.moveTemplate == moveTemplate }
+            val alreadyKnows =
+                pokemon.moveSet.getMoves().any { it.template == moveTemplate } ||
+                    pokemon.benchedMoves.any { it.moveTemplate == moveTemplate }
             if (alreadyKnows) {
                 return@teachMove DoubleValue.ZERO
             }
@@ -416,42 +416,43 @@ object PokemonMoLangFunctions : AbstractMoLangFunctionHolder<Pokemon>() {
 
             DoubleValue.ONE
         }
-        map["can_learn_move"] = canLearnMove@{ params ->
+        functions["can_learn_move"] = canLearnMove@{ params ->
             val moveName = params.getString(0)
             val moveTemplate = Moves.getByName(moveName) ?: return@canLearnMove DoubleValue.ZERO
             val includeLegacy = params.getBooleanOrNull(1) ?: true
 
-            val canLearn = if (includeLegacy) {
-                LearnsetQuery.ANY.canLearn(moveTemplate, pokemon.form.moves)
-            } else {
-                LearnsetQuery.LEGAL.canLearn(moveTemplate, pokemon.form.moves)
-            }
-            return@canLearnMove DoubleValue(if (canLearn) 1.0 else 0.0)
+            val canLearn =
+                if (includeLegacy) {
+                    LearnsetQuery.ANY.canLearn(moveTemplate, pokemon.form.moves)
+                } else {
+                    LearnsetQuery.LEGAL.canLearn(moveTemplate, pokemon.form.moves)
+                }
+
+            DoubleValue(if (canLearn) 1.0 else 0.0)
         }
-        map["unlearn_move"] = unlearnMove@{ params ->
+        functions["unlearn_move"] = unlearnMove@{ params ->
             val moveName = params.getString(0)
             val moveTemplate = Moves.getByName(moveName)
             if (moveTemplate != null) {
                 pokemon.unlearnMove(moveTemplate)
                 return@unlearnMove DoubleValue.ONE
-            } else {
-                return@unlearnMove DoubleValue.ZERO
             }
+
+            DoubleValue.ZERO
         }
-        map["can_evolve"] = { _ ->
-            DoubleValue(pokemon.evolutions.any())
-        }
-        map["force_evolve"] = forceEvolve@{ params ->
+        functions["can_evolve"] = { DoubleValue(pokemon.evolutions.any()) }
+        functions["force_evolve"] = forceEvolve@{ params ->
             val idx = params.getInt(0)
-            val evolution = if (idx >= 0) pokemon.evolutions.elementAtOrNull(idx) else return@forceEvolve DoubleValue.ZERO
+            val evolution =
+                if (idx >= 0) pokemon.evolutions.elementAtOrNull(idx) else return@forceEvolve DoubleValue.ZERO
             evolution?.forceEvolve(pokemon)
             StringValue(evolution.toString())
         }
 
-        map["entity"] = { pokemon.entity?.asMoLangValue() ?: DoubleValue.ZERO }
-        map["is_alpha"] = { DoubleValue(pokemon.isAlpha) }
-        map["size_category"] = { _ -> StringValue(pokemon.getSizeCategory().name) }
+        functions["entity"] = { pokemon.entity?.asMoLangValue() ?: DoubleValue.ZERO }
+        functions["is_alpha"] = { DoubleValue(pokemon.isAlpha) }
+        functions["size_category"] = { StringValue(pokemon.getSizeCategory().name) }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PokemonPropertiesMoLangFunctions.kt

@@ -20,52 +20,50 @@ import com.cobblemon.mod.common.util.getStringOrNull
 object PokemonPropertiesMoLangFunctions : AbstractMoLangFunctionHolder<PokemonProperties>() {
     override fun PokemonProperties.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val props = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["level"] = { DoubleValue(props.level?.toDouble() ?: 0) }
-        map["set_level"] = { params ->
+        functions["level"] = { DoubleValue(props.level?.toDouble() ?: 0) }
+        functions["set_level"] = { params ->
             props.level = params.getIntOrNull(0)
             DoubleValue.ONE
         }
-        map["shiny"] = { DoubleValue(props.shiny) }
-        map["set_shiny"] = { params ->
+        functions["shiny"] = { DoubleValue(props.shiny) }
+        functions["set_shiny"] = { params ->
             props.shiny = params.getBooleanOrNull(0)
             DoubleValue.ONE
         }
-        map["species"] = { props.species?.let { StringValue(it) } ?: DoubleValue.ZERO }
-        map["set_species"] = { params ->
+        functions["species"] = { props.species?.let { StringValue(it) } ?: DoubleValue.ZERO }
+        functions["set_species"] = { params ->
             props.species = params.getStringOrNull(0)
             DoubleValue.ONE
         }
-        map["gender"] = { props.gender?.let { StringValue(it.name) } ?: DoubleValue.ZERO }
-        map["set_gender"] = { params ->
+        functions["gender"] = { props.gender?.let { StringValue(it.name) } ?: DoubleValue.ZERO }
+        functions["set_gender"] = { params ->
             props.gender = params.getStringOrNull(0)?.let { Gender.valueOf(it) }
             DoubleValue.ONE
         }
-        map["form"] = { props.form?.let { StringValue(it) } ?: DoubleValue.ZERO }
-        map["ivs"] = ivs@{
+        functions["form"] = { props.form?.let { StringValue(it) } ?: DoubleValue.ZERO }
+        functions["ivs"] = ivs@{
             val ivs = props.ivs ?: return@ivs DoubleValue.ZERO
 
-            return@ivs ivs.struct
+            ivs.struct
         }
-        map["evs"] = evs@{
+        functions["evs"] = evs@{
             val evs = props.evs ?: return@evs DoubleValue.ZERO
 
-            return@evs evs.struct
+            evs.struct
         }
-        map["friendship"] = { DoubleValue(props.friendship?.toDouble() ?: DoubleValue.ZERO) }
-        map["set_friendship"] = { params ->
+        functions["friendship"] = { DoubleValue(props.friendship?.toDouble() ?: DoubleValue.ZERO) }
+        functions["set_friendship"] = { params ->
             props.friendship = params.getIntOrNull(0)
             DoubleValue.ONE
         }
-        map["create"] = {
-            val pokemon = props.create()
-            pokemon.struct
-        }
-        map["to_string"] = { params ->
+        functions["create"] = { (props.create()).struct }
+        functions["to_string"] = { params ->
             val separator = params.getStringOrNull(0) ?: " "
             StringValue(props.asString(separator = separator))
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/PokemonStoreMoLangFunctions.kt

@@ -22,83 +22,84 @@ import com.cobblemon.mod.common.util.asUUID
 import com.cobblemon.mod.common.util.getPlayer
 import com.cobblemon.mod.common.util.toProperties
 
-object PokemonStoreMoLangFunctions: AbstractMoLangFunctionHolder<PokemonStore<*>>() {
+object PokemonStoreMoLangFunctions : AbstractMoLangFunctionHolder<PokemonStore<*>>() {
     override fun PokemonStore<*>.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val store = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        map["uuid"] = { StringValue(store.uuid.toString()) }
-        map["add"] = { params ->
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["uuid"] = { StringValue(store.uuid.toString()) }
+        functions["add"] = { params ->
             val pokemon = params.get<ObjectValue<Pokemon>>(0)
             DoubleValue(store.add(pokemon.obj))
         }
-        map["add_by_properties"] = { params ->
+        functions["add_by_properties"] = { params ->
             val props = params.getString(0).toProperties()
-            val player = (store as? PlayerPartyStore)?.playerUUID?.getPlayer() // Only really know for sure when it's a player party store
+            val player =
+                (store as? PlayerPartyStore)?.playerUUID?.getPlayer() // Only really know for sure when it's a player party store
             val pokemon = props.create(player = player)
             DoubleValue(store.add(pokemon))
         }
-        map["find_by_properties"] = { params ->
+        functions["find_by_properties"] = { params ->
             val props = params.getString(0).toProperties()
             val pokemon = store.find { props.matches(it) }
             pokemon?.asStruct() ?: DoubleValue.ZERO
         }
-        map["find_all_by_properties"] = { params ->
+        functions["find_all_by_properties"] = { params ->
             val props = params.getString(0).toProperties()
             val pokemon = store.filter { props.matches(it) }
             ArrayStruct(pokemon.mapIndexed { index, value -> "$index" to value.asStruct() }.toMap())
         }
-        map["find_by_id"] = { params ->
+        functions["find_by_id"] = { params ->
             val id = params.getString(0).asUUID
             val pokemon = store.find { it.uuid == id }
             pokemon?.asStruct() ?: DoubleValue.ZERO
         }
-        map["remove_by_id"] = removeById@{ params ->
+        functions["remove_by_id"] = removeById@{ params ->
             val id = params.getString(0).asUUID
             val pokemon = store.find { it.uuid == id } ?: return@removeById DoubleValue.ZERO
-            return@removeById DoubleValue(store.remove(pokemon))
+            DoubleValue(store.remove(pokemon))
         }
-        map["average_level"] = averageLevel@{ _ ->
+        functions["average_level"] = averageLevel@{
             var numberOfPokemon = 0
             var totalLevel = 0
             for (pokemon in store) {
                 totalLevel += pokemon.level
                 numberOfPokemon++
             }
-            if (numberOfPokemon == 0) {
-                return@averageLevel DoubleValue.ZERO
-            }
-            return@averageLevel DoubleValue(totalLevel.toDouble() / numberOfPokemon)
+
+            if (numberOfPokemon == 0) return@averageLevel DoubleValue.ZERO
+
+            DoubleValue(totalLevel.toDouble() / numberOfPokemon)
         }
-        map["count"] = { _ -> DoubleValue(store.count()) }
-        map["count_by_properties"] = { params ->
+        functions["count"] = { DoubleValue(store.count()) }
+        functions["count_by_properties"] = { params ->
             val props = params.getString(0).toProperties()
             DoubleValue(store.count { props.matches(it) })
         }
-        map["highest_level"] = {
+        functions["highest_level"] = {
             val highest = store.maxOfOrNull { it.level } ?: 0
             DoubleValue(highest)
         }
-        map["lowest_level"] = {
+        functions["lowest_level"] = {
             val lowest = store.minOfOrNull { it.level } ?: 0
             DoubleValue(lowest)
         }
-        map["heal"] = {
+        functions["heal"] = {
             for (pokemon in store) {
                 pokemon.heal()
             }
             DoubleValue.ONE
         }
-        map["healing_remainder_percent"] = { _ ->
+        functions["healing_remainder_percent"] = {
             var totalPercent = 0.0f
             for (pokemon in store) {
                 totalPercent += (1.0f - (pokemon.currentHealth.toFloat() / pokemon.maxHealth))
             }
             DoubleValue(totalPercent)
         }
-        map["has_usable_pokemon"] = { _ -> DoubleValue(store.any { !it.isFainted() }) }
-        map["pokemon"] = {
-            store.map { it.asStruct() }.asArrayValue()
-        }
-        return map
+        functions["has_usable_pokemon"] = { DoubleValue(store.any { !it.isFainted() }) }
+        functions["pokemon"] = { store.map { it.asStruct() }.asArrayValue() }
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/ServerMoLangFunctions.kt

@@ -25,62 +25,63 @@ import java.util.*
 object ServerMoLangFunctions : AbstractMoLangFunctionHolder<MinecraftServer>() {
     override fun MinecraftServer.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val server = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["get_world"] = getWorld@{ params ->
-            val world = server.getLevel(
-                ResourceKey.create(
-                    Registries.DIMENSION,
-                    params.getString(0).asIdentifierDefaultingNamespace(namespace = "minecraft")
-                )
-            ) ?: return@getWorld DoubleValue.ZERO
+        functions["get_world"] = getWorld@{ params ->
+            val world =
+                server.getLevel(
+                    ResourceKey.create(
+                        Registries.DIMENSION,
+                        params.getString(0).asIdentifierDefaultingNamespace(namespace = "minecraft"),
+                    ),
+                ) ?: return@getWorld DoubleValue.ZERO
 
-            return@getWorld world
+            world
                 .registryAccess()
                 .registryOrThrow(Registries.DIMENSION)
                 .wrapAsHolder(world)
                 .asWorldMoLangValue()
         }
 
-        map["broadcast"] = { params ->
+        functions["broadcast"] = { params ->
             val message = params.getString(0)
             server.playerList.broadcastSystemMessage(message.text(), params.getBooleanOrNull(1) == true)
             DoubleValue.ONE
         }
 
-        map["get_player_by_uuid"] = getPlayerByUuid@{ params ->
+        functions["get_player_by_uuid"] = getPlayerByUuid@{ params ->
             val uuid = UUID.fromString(params.getString(0))
             val player = server.playerList.getPlayer(uuid) ?: return@getPlayerByUuid DoubleValue.ZERO
-            return@getPlayerByUuid player.asMoLangValue()
+            player.asMoLangValue()
         }
 
-        map["get_player_by_username"] = getPlayerByUsername@{ params ->
+        functions["get_player_by_username"] = getPlayerByUsername@{ params ->
             val username = params.getString(0)
             val player = server.playerList.getPlayerByName(username) ?: return@getPlayerByUsername DoubleValue.ZERO
-            return@getPlayerByUsername player.asMoLangValue()
+            player.asMoLangValue()
         }
 
-        map["data"] = { params ->
+        functions["data"] = { params ->
             Cobblemon.molangData.load(
                 UUID(0L, 0L),
-                params.getStringOrNull(0)
+                params.getStringOrNull(0),
             )
         }
 
-        map["save_data"] = { params ->
+        functions["save_data"] = { params ->
             Cobblemon.molangData.save(
                 UUID(0L, 0L),
-                params.getStringOrNull(index = 0)
+                params.getStringOrNull(index = 0),
             )
             DoubleValue.ONE
         }
 
         // Maybe later...
-//            map.put("stop") { params ->
+//            functions.put("stop") { params ->
 //                Cobblemon.LOGGER.warn("Server is being stopped from a MoLang script.")
 //                server.stopServer()
 //            }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/SpawnablePositionMoLangFunctions.kt

@@ -20,27 +20,34 @@ import net.minecraft.server.level.ServerPlayer
 object SpawnablePositionMoLangFunctions : AbstractMoLangFunctionHolder<SpawnablePosition>() {
     override fun SpawnablePosition.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val spawningContext = this
-        val map = mutableMapOf<String, (MoParams) -> Any>()
-        val worldValue = spawningContext.world.registryAccess().registryOrThrow(Registries.DIMENSION)
-            .wrapAsHolder(spawningContext.world).asWorldMoLangValue()
-        val biomeValue = spawningContext.biomeHolder.asBiomeMoLangValue()
-        map["biome"] = { _ -> biomeValue }
-        map["world"] = { _ -> worldValue }
-        map["light"] = { _ -> DoubleValue(spawningContext.light.toDouble()) }
-        map["x"] = { _ -> DoubleValue(spawningContext.position.x.toDouble()) }
-        map["y"] = { _ -> DoubleValue(spawningContext.position.y.toDouble()) }
-        map["z"] = { _ -> DoubleValue(spawningContext.position.z.toDouble()) }
-        map["moon_phase"] = { _ -> DoubleValue(spawningContext.moonPhase.toDouble()) }
-        map["can_see_sky"] = { _ -> DoubleValue(spawningContext.canSeeSky) }
-        map["sky_light"] = { _ -> DoubleValue(spawningContext.skyLight.toDouble()) }
-        map["player"] = put@{ _ ->
-            val causeEntity = spawningContext.cause.entity ?: return@put DoubleValue.ZERO
-            if (causeEntity is ServerPlayer) {
-                return@put causeEntity.asMoLangValue()
-            } else {
-                return@put DoubleValue.ZERO
-            }
+        val worldValue =
+            spawningContext
+                .world
+                .registryAccess()
+                .registryOrThrow(Registries.DIMENSION)
+                .wrapAsHolder(spawningContext.world)
+                .asWorldMoLangValue()
+        val biomeValue =
+            spawningContext
+                .biomeHolder
+                .asBiomeMoLangValue()
+        val functions = hashMapOf<String, (MoParams) -> Any>()
+
+        functions["biome"] = { biomeValue }
+        functions["world"] = { worldValue }
+        functions["light"] = { DoubleValue(spawningContext.light.toDouble()) }
+        functions["x"] = { DoubleValue(spawningContext.position.x.toDouble()) }
+        functions["y"] = { DoubleValue(spawningContext.position.y.toDouble()) }
+        functions["z"] = { DoubleValue(spawningContext.position.z.toDouble()) }
+        functions["moon_phase"] = { DoubleValue(spawningContext.moonPhase.toDouble()) }
+        functions["can_see_sky"] = { DoubleValue(spawningContext.canSeeSky) }
+        functions["sky_light"] = { DoubleValue(spawningContext.skyLight.toDouble()) }
+        functions["player"] = player@{
+            val causeEntity = spawningContext.cause.entity ?: return@player DoubleValue.ZERO
+            if (causeEntity is ServerPlayer) return@player causeEntity.asMoLangValue()
+            DoubleValue.ZERO
         }
-        return map
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/SpeciesMoLangFunctions.kt

@@ -17,23 +17,23 @@ import com.cobblemon.mod.common.util.asArrayValue
 object SpeciesMoLangFunctions : AbstractMoLangFunctionHolder<Species>() {
     override fun Species.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
         val species = this
-        val map = mutableMapOf<String, (MoParams) -> Any>(
-            "identifier" to { StringValue(species.resourceIdentifier.toString()) },
-            "name" to { StringValue(species.name) },
-            "primary_type" to { StringValue(species.primaryType.showdownId) },
-            "secondary_type" to { StringValue(species.secondaryType?.showdownId ?: "null") },
-            "experience_group" to { StringValue(species.experienceGroup.name) },
-            "height" to { DoubleValue(species.height) },
-            "weight" to { DoubleValue(species.weight) },
-            "base_scale" to { DoubleValue(species.baseScale) },
-            "hitbox_width" to { DoubleValue(species.hitbox.width) },
-            "hitbox_height" to { DoubleValue(species.hitbox.height) },
-            "hitbox_fixed" to { DoubleValue(species.hitbox.fixed) },
-            "catch_rate" to { DoubleValue(species.catchRate) },
-            "labels" to { species.labels.asArrayValue { StringValue(it) } },
-            "has_label" to { params -> DoubleValue(species.labels.contains(params.getString(0))) }
-        )
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        return map
+        functions["identifier"] = { StringValue(species.resourceIdentifier.toString()) }
+        functions["name"] = { StringValue(species.name) }
+        functions["primary_type"] = { StringValue(species.primaryType.showdownId) }
+        functions["secondary_type"] = { StringValue(species.secondaryType?.showdownId ?: "null") }
+        functions["experience_group"] = { StringValue(species.experienceGroup.name) }
+        functions["height"] = { DoubleValue(species.height) }
+        functions["weight"] = { DoubleValue(species.weight) }
+        functions["base_scale"] = { DoubleValue(species.baseScale) }
+        functions["hitbox_width"] = { DoubleValue(species.hitbox.width) }
+        functions["hitbox_height"] = { DoubleValue(species.hitbox.height) }
+        functions["hitbox_fixed"] = { DoubleValue(species.hitbox.fixed) }
+        functions["catch_rate"] = { DoubleValue(species.catchRate) }
+        functions["labels"] = { species.labels.asArrayValue { StringValue(it) } }
+        functions["has_label"] = { params -> DoubleValue(species.labels.contains(params.getString(0))) }
+
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/molang/function/WorldMoLangFunctions.kt

@@ -24,7 +24,6 @@ import com.cobblemon.mod.common.entity.npc.NPCEntity
 import com.cobblemon.mod.common.net.messages.client.effect.SpawnSnowstormParticlePacket
 import com.cobblemon.mod.common.net.messages.client.sound.UnvalidatedPlaySoundS2CPacket
 import com.cobblemon.mod.common.util.*
-import java.util.UUID
 import net.minecraft.core.BlockPos
 import net.minecraft.core.Holder
 import net.minecraft.core.registries.Registries
@@ -46,85 +45,89 @@ import net.minecraft.world.level.storage.loot.parameters.LootContextParamSets
 import net.minecraft.world.level.storage.loot.parameters.LootContextParams
 import net.minecraft.world.phys.AABB
 import net.minecraft.world.phys.Vec3
+import java.util.UUID
 
 object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
     override fun Holder<Level>.moLangFunctions(): MutableMap<String, (MoParams) -> Any> {
-
         val world = this.value()
-        val map = mutableMapOf<String, (MoParams) -> Any>(
-        )
+        val functions = hashMapOf<String, (MoParams) -> Any>()
 
-        map["is_time_of_day"] = put@{ params ->
+        functions["is_time_of_day"] = isTimeOfDay@{ params ->
+            val timeOfDay =
+                TimeRange.timeRanges[params.getString(0).lowercase()]
+                    ?: return@isTimeOfDay DoubleValue.ZERO
+            val time = world.dayTime % 24000
 
-            val timeOfDay = TimeRange.timeRanges[params.getString(0).lowercase()]
-                ?: return@put DoubleValue.ZERO
-            val time = world.dayTime % 24000
-            return@put DoubleValue(timeOfDay.contains(time.toInt()))
+            DoubleValue(timeOfDay.contains(time.toInt()))
         }
-        map["game_time"] = { _ -> DoubleValue(world.gameTime.toDouble()) }
-        map["time_of_day"] = put@{
-            val time = world.dayTime % 24000
-            return@put DoubleValue(time.toDouble())
-        }
-        map["server"] = { _ -> server()?.asMoLangValue() ?: DoubleValue.ZERO }
-        map["is_raining_at"] = put@{ params ->
+        functions["game_time"] = { DoubleValue(world.gameTime.toDouble()) }
+        functions["time_of_day"] = { DoubleValue((world.dayTime % 24000).toDouble()) }
+        functions["server"] = { server()?.asMoLangValue() ?: DoubleValue.ZERO }
+        functions["is_raining_at"] = { params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
-            return@put DoubleValue(world.isRainingAt(BlockPos(x, y, z)))
+            DoubleValue(world.isRainingAt(BlockPos(x, y, z)))
         }
-        map["is_snowing_at"] = put@{ params ->
+        functions["is_snowing_at"] = { params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
             val blockPos = BlockPos(x, y, z)
             when {
-                !world.isRaining -> return@put DoubleValue.ZERO
-                !world.canSeeSky(blockPos) -> return@put DoubleValue.ZERO
+                !world.isRaining -> {
+                    DoubleValue.ZERO
+                }
+
+                !world.canSeeSky(blockPos) -> {
+                    DoubleValue.ZERO
+                }
+
                 (world.getHeightmapPos(Heightmap.Types.MOTION_BLOCKING, blockPos).y > blockPos.y) -> {
-                    return@put DoubleValue.ZERO
+                    DoubleValue.ZERO
                 }
 
                 else -> {
                     val biome = world.getBiome(blockPos).value() as Biome
-                    return@put DoubleValue(biome.getPrecipitationAt(blockPos) == Biome.Precipitation.SNOW)
+                    DoubleValue(biome.getPrecipitationAt(blockPos) == Biome.Precipitation.SNOW)
                 }
             }
         }
-        map["is_chunk_loaded_at"] = put@{ params ->
+        functions["is_chunk_loaded_at"] = { params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
-            return@put DoubleValue(world.isLoaded(BlockPos(x, y, z)))
+            DoubleValue(world.isLoaded(BlockPos(x, y, z)))
         }
-        map["is_thundering"] = { _ -> DoubleValue(world.isThundering) }
-        map["is_raining"] = { _ -> DoubleValue(world.isRaining) }
-        map["set_block"] = put@{ params ->
+        functions["is_thundering"] = { DoubleValue(world.isThundering) }
+        functions["is_raining"] = { DoubleValue(world.isRaining) }
+        functions["set_block"] = setBlock@{ params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
-            val block = world.blockRegistry.get(params.getString(3).asIdentifierDefaultingNamespace())
-                ?: run {
-                    Cobblemon.LOGGER.error("Unknown block: ${params.getString(3)}")
-                    return@put DoubleValue.ZERO
-                }
+            val block =
+                world.blockRegistry.get(params.getString(3).asIdentifierDefaultingNamespace())
+                    ?: run {
+                        Cobblemon.LOGGER.error("Unknown block: ${params.getString(3)}")
+                        return@setBlock DoubleValue.ZERO
+                    }
             world.setBlock(BlockPos(x, y, z), block.defaultBlockState(), Block.UPDATE_ALL)
         }
-        map["is_air"] = put@{ params ->
+        functions["is_air"] = { params ->
             val x = params.getDouble(0).toInt()
             val y = params.getDouble(1).toInt()
             val z = params.getDouble(2).toInt()
             val blockState = world.getBlockState(BlockPos(x, y, z))
-            return@put DoubleValue(blockState.isAir)
+            DoubleValue(blockState.isAir)
         }
-        map["get_block"] = put@{ params ->
+        functions["get_block"] = { params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
             val block = world.getBlockState(BlockPos(x, y, z)).block
-            return@put world.blockRegistry.wrapAsHolder(block).asMoLangValue(Registries.BLOCK)
+            world.blockRegistry.wrapAsHolder(block).asMoLangValue(Registries.BLOCK)
         }
-        map["spawn_explosion"] = { params ->
+        functions["spawn_explosion"] = { params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
@@ -136,32 +139,33 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
                 z,
                 range,
                 ExplosionInteraction.valueOf(
-                    params.getStringOrNull(4)?.uppercase() ?: ExplosionInteraction.TNT.name
-                )
+                    params.getStringOrNull(4)?.uppercase() ?: ExplosionInteraction.TNT.name,
+                ),
             )
         }
-        map["spawn_lightning"] = put@{ params ->
+        functions["spawn_lightning"] = { params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
             val lightning = LightningBolt(EntityType.LIGHTNING_BOLT, world)
             lightning.setPos(x, y, z)
             world.addFreshEntity(lightning)
-            return@put DoubleValue.ONE
+            DoubleValue.ONE
         }
         // q.entity.world.spawn_bedrock_particles(effect, x, y, z, [player]) - sends to everyone nearby or just to the player if they're set.
-        map["spawn_bedrock_particles"] = { params ->
+        functions["spawn_bedrock_particles"] = { params ->
             val particle = params.getString(0).asResource()
             val x = params.getDouble(1)
             val y = params.getDouble(2)
             val z = params.getDouble(3)
-            val player = params.getOrNull<MoValue>(4)?.let {
-                when (it) {
-                    is StringValue -> world.getPlayerByUUID(UUID.fromString(it.value))
-                    is ObjectValue<*> -> it.obj
-                    else -> null
-                }
-            } as? ServerPlayer
+            val player =
+                params.getOrNull<MoValue>(4)?.let {
+                    when (it) {
+                        is StringValue -> world.getPlayerByUUID(UUID.fromString(it.value))
+                        is ObjectValue<*> -> it.obj
+                        else -> null
+                    }
+                } as? ServerPlayer
             val pos = Vec3(x, y, z)
 
             val packet = SpawnSnowstormParticlePacket(particle, pos)
@@ -171,7 +175,7 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
                 packet.sendToPlayersAround(x, y, z, 64.0, world.dimension())
             }
         }
-        map["spawn_pokemon"] = put@{ params ->
+        functions["spawn_pokemon"] = spawnPokemon@{ params ->
             val x = params.getInt(0)
             val y = params.getInt(1)
             val z = params.getInt(2)
@@ -179,49 +183,50 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
 
             val pos = BlockPos(x, y, z)
 
-            if (!Level.isInSpawnableBounds(pos)) {
-                return@put DoubleValue.ZERO
-            }
+            if (!Level.isInSpawnableBounds(pos)) return@spawnPokemon DoubleValue.ZERO
 
             val pokemon = props.createEntity(world)
             pokemon.moveTo(pos, pokemon.yRot, pokemon.xRot)
 
-            if (world.addFreshEntity(pokemon)) {
-                return@put pokemon.struct
-            } else {
-                return@put DoubleValue.ZERO
-            }
+            if (world.addFreshEntity(pokemon)) return@spawnPokemon pokemon.struct
+
+            DoubleValue.ZERO
         }
-        map["spawn_npc"] = put@{ params ->
+        functions["spawn_npc"] = spawnNpc@{ params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
-            val npcClass = params.getStringOrNull(3)
-                ?.let { NPCClasses.getByIdentifier(it.asIdentifierDefaultingNamespace()) }
+            val npcClass =
+                params
+                    .getStringOrNull(3)
+                    ?.let { NPCClasses.getByIdentifier(it.asIdentifierDefaultingNamespace()) }
             val level = params.getInt(4)
-            if (npcClass == null) return@put DoubleValue.ZERO
+
+            if (npcClass == null) return@spawnNpc DoubleValue.ZERO
+
             val npc = NPCEntity(world)
             npc.moveTo(x, y, z, npc.yRot, npc.xRot)
             npc.npc = npcClass
             npc.initialize(level)
-            if (world.addFreshEntity(npc)) {
-                return@put npc.asMoLangValue()
-            }
-            return@put DoubleValue.ZERO
+
+            if (world.addFreshEntity(npc)) return@spawnNpc npc.asMoLangValue()
+
+            DoubleValue.ZERO
         }
-        map["play_sound_on_server"] = { params ->
+        functions["play_sound_on_server"] = { params ->
             val sound = params.getString(0).asResource()
             val soundSource = params.getString(1).uppercase()
             val x = params.getDouble(2)
             val y = params.getDouble(3)
             val z = params.getDouble(4)
-            val player = params.getOrNull<MoValue>(5)?.let {
-                when (it) {
-                    is StringValue -> world.getPlayerByUUID(UUID.fromString(it.value))
-                    is ObjectValue<*> -> it.obj
-                    else -> null
-                }
-            } as? ServerPlayer
+            val player =
+                params.getOrNull<MoValue>(5)?.let {
+                    when (it) {
+                        is StringValue -> world.getPlayerByUUID(UUID.fromString(it.value))
+                        is ObjectValue<*> -> it.obj
+                        else -> null
+                    }
+                } as? ServerPlayer
             val volume = params.getDoubleOrNull(6)?.toFloat() ?: 1.0f
             val pitch = params.getDoubleOrNull(7)?.toFloat() ?: 1.0f
 
@@ -233,29 +238,30 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
                 packet.sendToPlayersAround(x, y, z, 16.0, world.dimension())
             }
         }
-        map["get_entities_around"] = put@{ params ->
+        functions["get_entities_around"] = { params ->
             val x = params.getDouble(0)
             val y = params.getDouble(1)
             val z = params.getDouble(2)
             val range = params.getDouble(3) * 2
             val entities = world.getEntities(null, AABB.ofSize(Vec3(x, y, z), range, range, range))
-            return@put entities
+            entities
                 .filterIsInstance<LivingEntity>()
                 .map { it.asMostSpecificMoLangValue() }
                 .asArrayValue()
         }
-        map["is_healer_in_use"] = put@{ params ->
+        functions["is_healer_in_use"] = isHealerInUse@{ params ->
             val pos = params.get<ArrayStruct>(0).asBlockPos()
-            val healer = world.getBlockEntity(pos, CobblemonBlockEntities.HEALING_MACHINE).orElse(null)
-                ?: return@put DoubleValue.ONE
-            return@put DoubleValue(healer.isInUse)
+            val healer =
+                world.getBlockEntity(pos, CobblemonBlockEntities.HEALING_MACHINE).orElse(null)
+                    ?: return@isHealerInUse DoubleValue.ONE
+            return@isHealerInUse DoubleValue(healer.isInUse)
         }
 
-        map["spawn_loot_table_items"] = put@{ params ->
+        functions["spawn_loot_table_items"] = spawnLootTableItems@{ params ->
             val serverLevel = world as? ServerLevel
             if (serverLevel == null) {
                 Cobblemon.LOGGER.warn("spawn_loot_table_items: world is not a ServerLevel")
-                return@put DoubleValue.ZERO
+                return@spawnLootTableItems DoubleValue.ZERO
             }
             val lootTableId = params.getString(0).asIdentifierDefaultingNamespace()
             val x = params.getDouble(1)
@@ -265,9 +271,11 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
             val lootTableKey = ResourceKey.create(Registries.LOOT_TABLE, lootTableId)
             val lootTable = serverLevel.server.reloadableRegistries().getLootTable(lootTableKey)
 
-            val lootParams = LootParams.Builder(serverLevel)
-                .withParameter(LootContextParams.ORIGIN, Vec3(x, y, z))
-                .create(LootContextParamSets.COMMAND)
+            val lootParams =
+                LootParams
+                    .Builder(serverLevel)
+                    .withParameter(LootContextParams.ORIGIN, Vec3(x, y, z))
+                    .create(LootContextParamSets.COMMAND)
 
             val items = lootTable.getRandomItems(lootParams)
             val spawnedItems = ArrayStruct(hashMapOf())
@@ -285,9 +293,10 @@ object WorldMoLangFunctions : AbstractMoLangFunctionHolder<Holder<Level>>() {
                     }
                 }
             }
-            return@put spawnedItems
+
+            spawnedItems
         }
 
-        return map
+        return functions
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/pokedex/PokedexManager.kt

@@ -42,7 +42,7 @@ class PokedexManager(
     }
 
     // Java interop isn't great lol
-    @Deprecated("Use encounter(PokedexEntityData) instead")
+    @Deprecated("Use obtain(Pokemon) instead")
     fun catch(pokemon: Pokemon) {
         obtain(pokemon)
     }

common/src/main/kotlin/com/cobblemon/mod/common/api/pokemon/moves/Learnset.kt

@@ -109,8 +109,10 @@ open class Learnset {
                 evolutionMoves
     }
 
-    // We only sync level up moves atm
+    // Syncs level up, TM, and egg moves.
     fun shouldSynchronize(other: Learnset) = other.levelUpMoves != this.levelUpMoves
+            || other.tmMoves != this.tmMoves
+            || other.eggMoves != this.eggMoves
 
     fun decode(buffer: RegistryFriendlyByteBuf) {
         this.levelUpMoves.clear()
@@ -122,6 +124,8 @@ open class Learnset {
             }
             levelUpMoves[level] = moves
         }
+        decodeMoveList(buffer, this.tmMoves)
+        decodeMoveList(buffer, this.eggMoves)
     }
 
     fun encode(buffer: RegistryFriendlyByteBuf) {
@@ -133,5 +137,21 @@ open class Learnset {
                 buffer.writeInt(move.num)
             }
         }
+        encodeMoveList(buffer, this.tmMoves)
+        encodeMoveList(buffer, this.eggMoves)
+    }
+
+    private fun decodeMoveList(buffer: RegistryFriendlyByteBuf, list: MutableList<MoveTemplate>) {
+        list.clear()
+        repeat(times = buffer.readSizedInt(IntSize.U_SHORT)) {
+            Moves.getByNumericalId(buffer.readInt())?.let(list::add)
+        }
+    }
+
+    private fun encodeMoveList(buffer: RegistryFriendlyByteBuf, list: List<MoveTemplate>) {
+        buffer.writeSizedInt(IntSize.U_SHORT, list.size)
+        for (move in list) {
+            buffer.writeInt(move.num)
+        }
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/api/pokemon/stats/Stats.kt

@@ -54,8 +54,8 @@ enum class Stats(override val identifier: ResourceLocation, override val display
             "hp" -> HP
             "atk", "attack" -> ATTACK // Hyper Cutter states the full stat name "Attack"
             "def", "defense", "defence" -> DEFENCE // Big Pecks states the full stat name "Defense"
-            "spa" -> SPECIAL_ATTACK
-            "spd" -> SPECIAL_DEFENCE
+            "spa", "special_attack" -> SPECIAL_ATTACK
+            "spd", "special_defence", "special_defense" -> SPECIAL_DEFENCE
             "spe", "speed" -> SPEED
             "evasion" -> EVASION
             else -> ACCURACY

common/src/main/kotlin/com/cobblemon/mod/common/api/spawning/preset/BestSpawnerConfig.kt

@@ -40,11 +40,11 @@ class BestSpawnerConfig {
     )
 
     val worldBuckets = mutableMapOf(
-        "common" to 94F,
+        "common" to 94.05F,
         "uncommon" to 5F,
         "rare" to 0.5F,
         "ultra-rare" to 0.2F,
-        "boss" to 0.3F,
+        "boss" to 0.25F,
     )
 
     val fishingBuckets = mutableMapOf(

common/src/main/kotlin/com/cobblemon/mod/common/api/storage/PokemonStore.kt

@@ -17,10 +17,10 @@ import com.cobblemon.mod.common.api.storage.factory.PokemonStoreFactory
 import com.cobblemon.mod.common.pokemon.Pokemon
 import com.cobblemon.mod.common.util.DataKeys
 import com.google.gson.JsonObject
-import java.util.UUID
 import net.minecraft.core.RegistryAccess
 import net.minecraft.nbt.CompoundTag
 import net.minecraft.server.level.ServerPlayer
+import java.util.UUID
 
 /**
  * The base class for all stores of [Pokemon]. A store specifies the kind of coordinate it needs to be given
@@ -77,7 +77,6 @@ abstract class PokemonStore<T : StorePosition> : Iterable<Pokemon> {
         remove(pokemon)
         val position = getFirstAvailablePosition() ?: return false // Couldn't fit, shrug emoji
         set(position, pokemon)
-        Cobblemon.playerDataManager.getTMData(uuid)?.syncTMsFromPokemon(pokemon)
         return true
     }
 

common/src/main/kotlin/com/cobblemon/mod/common/client/gui/tmmachine/TMMachineScreen.kt

@@ -1267,6 +1267,19 @@ class TMMachineScreen(containerMenu: TMMachineMenu, val inventory: Inventory, ti
         Minecraft.getInstance().soundManager.play(SimpleSoundInstance.forUI(soundEvent, 1.0F))
     }
 
+    override fun hasClickedOutside(
+        mouseX: Double,
+        mouseY: Double,
+        guiLeft: Int,
+        guiTop: Int,
+        mouseButton: Int
+    ): Boolean {
+        partySlotList.forEach {
+            if (it.pokemon != null && it.isMouseOver(mouseX, mouseY)) return false
+        }
+        return super.hasClickedOutside(mouseX, mouseY, guiLeft, guiTop, mouseButton)
+    }
+
     class MoveDescriptionWidget(pX: Int, pY: Int, width: Int, height: Int) : ScrollingWidget<MoveDescriptionWidget.TextSlot>(
         left = pX,
         top = pY - height,

common/src/main/kotlin/com/cobblemon/mod/common/client/net/gui/SetActiveTMPacketHandler.kt

@@ -21,18 +21,22 @@ object SetActiveTMPacketHandler : ServerNetworkPacketHandler<SetActiveTMPacket>
         val menu = player.containerMenu as? TMMachineMenu ?: return
         val tmData = Cobblemon.playerDataManager.getTMData(player)
 
-        if (packet.tm != null && (!packet.tm.isPassivelyObtained() && packet.tm.id !in tmData.learnedTMs)) {
+        if (packet.tm != null
+            && !Cobblemon.config.unlockAllMoveDexMovesByDefault
+            && !packet.tm.isPassivelyObtained()
+            && packet.tm.id !in tmData.learnedTMs) {
             return // Hacker smh
         }
 
         menu.tmMachineEntity?.let { blockEntity ->
             blockEntity.activeMove = packet.tm?.moveName?.name ?: ""
-            blockEntity.setChanged()
-            player.level().sendBlockUpdated(blockEntity.blockPos, blockEntity.blockState, blockEntity.blockState, Block.UPDATE_CLIENTS)
 
             blockEntity.burnActive = false
             blockEntity.burnProgress = 0
 
+            blockEntity.setChanged()
+            player.level().sendBlockUpdated(blockEntity.blockPos, blockEntity.blockState, blockEntity.blockState, Block.UPDATE_CLIENTS)
+
             player.level().players().forEach { thePlayer -> //Update all players with matching menu/blockentity
                 val tmmMenu = thePlayer.containerMenu as? TMMachineMenu ?: return@forEach
                 if (tmmMenu.tmMachineEntity == blockEntity) {

common/src/main/kotlin/com/cobblemon/mod/common/client/net/gui/SetTMMachineContainerDataPacketHandler.kt

@@ -29,6 +29,8 @@ object SetTMMachineContainerDataPacketHandler : ServerNetworkPacketHandler<SetTM
             menu.containerData?.set(TMMachineBlockEntity.BURN_PROGRESS_INDEX, 0)
         }
 
+        menu.tmMachineEntity?.setChanged()
+
         menu.broadcastChanges()
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/events/PokedexHandler.kt

@@ -25,7 +25,8 @@ object PokedexHandler : EventHandler {
     }
 
     fun onPokemonGained(event: PokemonGainedEvent) {
-        Cobblemon.playerDataManager.getPokedexData(event.playerId).catch(event.pokemon)
+        Cobblemon.playerDataManager.getPokedexData(event.playerId).obtain(event.pokemon)
+        Cobblemon.playerDataManager.getTMData(event.playerId).syncTMsFromPokemon(event.pokemon)
     }
 
     fun onPokemonSeen(event: PokemonSeenEvent) {
@@ -34,7 +35,7 @@ object PokedexHandler : EventHandler {
 
     fun onPokemonAspectsChanged(event: PokemonAspectsChangedEvent) {
         if (event.ownerId != null) {
-            Cobblemon.playerDataManager.getPokedexData(event.ownerId).catch(event.pokemon)
+            Cobblemon.playerDataManager.getPokedexData(event.ownerId).obtain(event.pokemon)
         }
     }
 

common/src/main/kotlin/com/cobblemon/mod/common/pokemon/requirements/StatCompareRequirement.kt

@@ -9,6 +9,7 @@
 package com.cobblemon.mod.common.pokemon.requirements
 
 import com.cobblemon.mod.common.api.pokemon.requirement.Requirement
+import com.cobblemon.mod.common.api.pokemon.stats.Stat
 import com.cobblemon.mod.common.api.pokemon.stats.Stats
 import com.cobblemon.mod.common.pokemon.Pokemon
 
@@ -17,10 +18,13 @@ class StatCompareRequirement : Requirement {
         const val ADAPTER_VARIANT = "stat_compare"
     }
 
-    val highStat = Stats.ATTACK.name
-    val lowStat = Stats.DEFENCE.name
+    val highStat = Stats.ATTACK.identifier.path
+    val lowStat = Stats.DEFENCE.identifier.path
 
     override fun check(pokemon: Pokemon): Boolean {
-        return pokemon.getStat(Stats.getStat(highStat)) > pokemon.getStat(Stats.getStat(lowStat))
+        val high = Stats.getStat(highStat)
+        val low = Stats.getStat(lowStat)
+        if (high.type != Stat.Type.PERMANENT || low.type != Stat.Type.PERMANENT) return false
+        return pokemon.getStat(high) > pokemon.getStat(low)
     }
 }

common/src/main/kotlin/com/cobblemon/mod/common/pokemon/requirements/StatEqualRequirement.kt

@@ -9,6 +9,7 @@
 package com.cobblemon.mod.common.pokemon.requirements
 
 import com.cobblemon.mod.common.api.pokemon.requirement.Requirement
+import com.cobblemon.mod.common.api.pokemon.stats.Stat
 import com.cobblemon.mod.common.api.pokemon.stats.Stats
 import com.cobblemon.mod.common.pokemon.Pokemon
 
@@ -17,10 +18,13 @@ class StatEqualRequirement : Requirement {
         const val ADAPTER_VARIANT = "stat_equal"
     }
 
-    val statOne = Stats.ATTACK.name
-    val statTwo = Stats.DEFENCE.name
+    val statOne = Stats.ATTACK.identifier.path
+    val statTwo = Stats.DEFENCE.identifier.path
 
     override fun check(pokemon: Pokemon): Boolean {
-        return pokemon.getStat(Stats.getStat(statOne)) == pokemon.getStat(Stats.getStat(statTwo))
+        val one = Stats.getStat(statOne)
+        val two = Stats.getStat(statTwo)
+        if (one.type != Stat.Type.PERMANENT || two.type != Stat.Type.PERMANENT) return false
+        return pokemon.getStat(one) == pokemon.getStat(two)
     }
 }

common/src/main/resources/assets/cobblemon/bedrock/pokemon/animations/0627_rufflet/rufflet.animation.json

@@ -1155,14 +1155,6 @@
 					"position": [0, 0.5, 0]
 				}
 			},
-			"sound_effects": {
-				"0.0417": {
-					"effect": "animation.plumage_wing_flap_1"
-				},
-				"0.5417": {
-					"effect": "animation.plumage_wing_flap_3"
-				}
-			},
 			"timeline": {
 				"0.0417": "q.has_entity ? { q.sound('animation.plumage.wing_flap.small'); };",
 				"0.5417": "q.has_entity ? { q.sound('animation.plumage.wing_flap.small'); };"

common/src/main/resources/assets/cobblemon/bedrock/pokemon/animations/0628_braviary/braviary.animation.json

@@ -1967,14 +1967,6 @@
 					"position": [0, 0, -1]
 				}
 			},
-			"sound_effects": {
-				"0.0417": {
-					"effect": "animation.plumage_wing_flap_medium_8"
-				},
-				"1.375": {
-					"effect": "animation.plumage_wing_flap_medium_2"
-				}
-			},
 			"timeline": {
 				"0.0417": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };",
 				"1.375": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };"
@@ -2228,20 +2220,6 @@
 					"position": [0, 0, 2]
 				}
 			},
-			"sound_effects": {
-				"0.7083": {
-					"effect": "animation.plumage_wing_flap_medium_2"
-				},
-				"1.6667": {
-					"effect": "animation.plumage_wing_flap_medium_8"
-				},
-				"2.7083": {
-					"effect": "animation.plumage_wing_flap_medium_2"
-				},
-				"3.6667": {
-					"effect": "animation.plumage_wing_flap_medium_8"
-				}
-			},
 			"timeline": {
 				"0.7083": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };",
 				"1.6667": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };",

common/src/main/resources/assets/cobblemon/bedrock/pokemon/animations/0628_braviary/braviary_hisuian.animation.json

@@ -2544,20 +2544,6 @@
 					"rotation": [7.5, 0, "math.sin(q.anim_time*90-90)*3"]
 				}
 			},
-			"sound_effects": {
-				"0.7083": {
-					"effect": "animation.plumage_wing_flap_medium_2"
-				},
-				"1.6667": {
-					"effect": "animation.plumage_wing_flap_medium_8"
-				},
-				"2.7083": {
-					"effect": "animation.plumage_wing_flap_medium_2"
-				},
-				"3.6667": {
-					"effect": "animation.plumage_wing_flap_medium_8"
-				}
-			},
 			"timeline": {
 				"0.7083": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };",
 				"1.6667": "q.has_entity ? { q.sound('animation.plumage.wing_flap.medium'); };",

common/src/main/resources/assets/cobblemon/lang/es_es.json

@@ -9668,5 +9668,11 @@
     "cobblemon.ui.pokedex.info.form.baxcalibur": " ",
     "cobblemon.habitat.birch_wildfire_scar.name": "Abedular calcinado",
     "cobblemon.habitat.oak_wildfire_scar.name": "Robledal calcinado",
-    "cobblemon.habitat.spruce_wildfire_scar.name": "Taiga calcinada"
+    "cobblemon.habitat.spruce_wildfire_scar.name": "Taiga calcinada",
+    "cobblemon.ui.starter.random": "Aleatorio",
+    "cobblemon.ui.starter.random_description": "Se te asignará un Pokémon inicial aleatorio de entre todos los posibles, pero no sabrás cuál hasta que lo pulses.",
+    "cobblemon.config.ui.world_spawning_blocklist": "Lista de mundos sin apariciones",
+    "cobblemon.config.ui.world_spawning_blocklist.tooltip": "Mundos en los que la lógica de aparición de Pokémon estará deshabilitada.",
+    "advancements.cobblemon.obtain_tm": "Muéstrame tus movimientos prohibidos",
+    "advancements.cobblemon.obtain_tm.description": "Encuentra o imprime una MT"
 }

common/src/main/resources/assets/cobblemon/lang/ja_jp.json

@@ -509,7 +509,7 @@
     "cobblemon.ui.starter.alreadyselected": "もう最初の一匹を選んだ！",
     "cobblemon.ui.starter.cannotchoose": "今は最初の一匹を選べない！",
     "cobblemon.ui.starter.hasalreadychosen": "%1$sはもう最初の一匹を選んだ！",
-    "cobblemon.ui.starter.skippedchoosing": "もう ポケモンを 持っています！ パートナーを 選ぶ時は パソコンに てもちの ポケモンを 預けてから \"%1$s\"キーを 押してください",
+    "cobblemon.ui.starter.skippedchoosing": "もう ポケモンを 持っています！ 最初の一匹を 選ぶ時は パソコンに てもちの ポケモンを 預けてから \"%1$s\"キーを 押してください",
     "cobblemon.ui.starter.choose_starter_title": "最初のポケモンを選ぼう！",
     "cobblemon.ui.starter.choose_starter_description": "”%1$s”キーを押す",
     "cobblemon.ui.starter.chooseyourstarter": "%1$sを押して最初の一匹を選んで、旅を始めよう！",
@@ -871,7 +871,7 @@
     "advancements.cobblemon.trade_pokemon.description": "他のトレーナーとポケモンを交換する",
     "advancements.cobblemon.trade_shelmet_karrablast": "盗難届",
     "advancements.cobblemon.trade_shelmet_karrablast.description": "チョボマキとカブルモを交換する",
-    "advancements.cobblemon.max_level_baby": "ダーウィン? なにそれおいしいの?",
+    "advancements.cobblemon.max_level_baby": "ダーウィン？ なにそれおいしいの？",
     "advancements.cobblemon.max_level_baby.description": "進化先があるポケモンを第一形態のままレベル100にする",
     "advancements.cobblemon.use_candy": "甘党",
     "advancements.cobblemon.use_candy.description": "けいけんアメをポケモンにあげる",
@@ -1437,9 +1437,9 @@
     "block.cobblemon.dripstone_moon_stone_ore": "鍾乳つきの鉱石",
     "block.cobblemon.nether_fire_stone_ore": "ネザーほのお鉱石",
     "block.cobblemon.terracotta_sun_stone_ore": "テラコッタたいよう鉱石",
-    "block.cobblemon.pasture": "牧草ブロック",
+    "block.cobblemon.pasture": "ぼくじょうブロック",
     "gamerule.doPokemonSpawning": "ポケモンのスポーン",
-    "gamerule.doShinyStarters": "さいしょのポケモンを色違いにする",
+    "gamerule.doShinyStarters": "最初のポケモンを色違いにする",
     "gamerule.doPokemonLoot": "ポケモンのアイテムのドロップ",
     "cobblemon.command.checkspawns.invalid-bucket": "スポーンバケットが 正しくありません",
     "cobblemon.command.checkspawns.spawns": "スポーン",
@@ -7655,7 +7655,7 @@
     "cobblemon.subtitle.pokemon.owned_shiny_ambient": "周囲の色違いのポケモンが光る",
     "cobblemon.subtitle.pokemon.shiny_ambient": "野生の色違いのポケモンが光った！",
     "cobblemon.subtitle.pokemon.shiny_shine": "捕まえられている色違いのポケモンが光る",
-    "cobblemon.config.ui.starters": "パートナーポケモン",
+    "cobblemon.config.ui.starters": "最初のポケモン",
     "cobblemon.subtitle.pokemon.wild_shiny_shine": "野生の色違いのポケモンが光る！",
     "advancements.cobblemon.resurrect_galar_fossil": "がっちゃんこ！",
     "advancements.cobblemon.resurrect_galar_fossil.description": "頭となるカセキのトリ又はカセキのサカナと、胴となるカセキのリュウ又はカセキのクビナガを組み合わせ、ポケモンを復元する",
@@ -8474,7 +8474,7 @@
     "cobblemon.config.ui.search_configurations": "検索設定",
     "cobblemon.config.ui.reset": "リセット",
     "cobblemon.config.ui.error.int_constraint": "値は %1$s と %2$s の間でなければ いけない ようだ",
-    "cobblemon.config.ui.category.starter": "パートナーポケモン",
+    "cobblemon.config.ui.category.starter": "最初の一匹",
     "cobblemon.config.ui.category.pokedex": "ポケモン図鑑",
     "cobblemon.config.ui.category.pokemon": "ポケモン",
     "cobblemon.config.ui.category.spawning": "スポーン",
@@ -8531,11 +8531,11 @@
     "cobblemon.config.ui.maximum_spawns_per_pass.tooltip": "スポーンシステムの1回のパスで発生可能な最大スポーン数。スポーンゾーンのサイズが小さい場合、このオプションの効果はほとんどありません。",
     "cobblemon.config.ui.export_spawn_config": "スポーン設定のエクスポート",
     "cobblemon.config.ui.save_pokemon_to_world.tooltip": "チャンク/ワールドの再読み込み後もポケモンが存在するよう、ワールドに保存するかどうか。",
-    "cobblemon.config.ui.export_starter_config.tooltip": "パートナーポケモンリストを編集するための starter.json を生成するかどうか。",
+    "cobblemon.config.ui.export_starter_config.tooltip": "最初のポケモンのリストを編集するための starter.json を生成するかどうか。",
     "cobblemon.config.ui.max_nearby_blocks_horizontal_range": "最大近傍ブロック水平範囲",
     "cobblemon.config.ui.export_spawn_config.tooltip": "より具体的なスポーン設定のためにスポーン構成を生成するかどうか。",
     "cobblemon.config.ui.save_pokemon_to_world": "ポケモンをワールドに保存",
-    "cobblemon.config.ui.export_starter_config": "エクスポートパートナーポケモン設定",
+    "cobblemon.config.ui.export_starter_config": "最初のポケモンの設定をエクスポートする",
     "cobblemon.config.ui.max_vertical_space": "最大垂直スペース",
     "cobblemon.config.ui.max_vertical_space.tooltip": "スポーン位置の上方にあるヘッドルームを調査するためにチェックする距離。この値はパフォーマンス上の理由で存在しますが、スポーンファイル内の最大「高さ」/「深さ」条件を下回ってはなりません。",
     "cobblemon.config.ui.max_nearby_blocks_vertical_range": "最大近傍ブロック垂直範囲",
@@ -8589,7 +8589,7 @@
     "cobblemon.config.ui.hide_unimplemented_pokemon_in_the_pokedex.tooltip": "未実装のポケモンをポケモン図鑑から非表示にするかどうか。",
     "cobblemon.config.ui.player_damage_pokemon.tooltip": "プレイヤーが通常のMinecraftエンティティのようにポケモンを攻撃できるかどうか。",
     "cobblemon.config.ui.apple_leftovers_chance": "リンゴからのたべのこし発生チャンス",
-    "cobblemon.config.ui.pasture_max_wander_distance.tooltip": "牧草ブロックからポケモンが移動できるブロックの最大数。",
+    "cobblemon.config.ui.pasture_max_wander_distance.tooltip": "ぼくじょうブロックからポケモンが移動できるブロックの最大数。",
     "cobblemon.config.ui.pasture_max_per_chunk": "牧草地の最大値（チャンク毎）",
     "cobblemon.config.ui.trade_max_distance.tooltip": "ポケモン交換が許可される最大距離。",
     "cobblemon.config.ui.hide_unimplemented_pokemon_in_the_pokedex": "未実装のポケモンをポケモン図鑑に非表示にする",
@@ -8603,7 +8603,7 @@
     "cobblemon.config.ui.pc_profile_animations": "PCプロフィールをアニメーションする",
     "cobblemon.config.ui.display_name_for_unknown_pokemon.tooltip": "まだポケモン図鑑でスキャンされていないポケモンの名前の表示の有無。",
     "cobblemon.config.ui.max_dynamax_level": "最大ダイマックスレベル",
-    "cobblemon.config.ui.pasture_block_update_ticks.tooltip": "牧草ブロックの更新間隔におけるサーバーティックの数。",
+    "cobblemon.config.ui.pasture_block_update_ticks.tooltip": "ぼくじょうブロックの更新間隔におけるサーバーティックの数。",
     "cobblemon.config.ui.summary_profile_animations": "概要プロフィールをアニメーションする",
     "cobblemon.config.ui.shiny_rate.tooltip": "出現したポケモンの色違い率。\"[入力した数値]分の1\"となる。0の場合、出現するポケモンは全て通常色になる。",
     "cobblemon.config.ui.max_pokedex_scanning_detection_range.tooltip": "ポケモン図鑑がポケモンを検知・スキャンできる最大距離。",
@@ -8623,8 +8623,8 @@
     "cobblemon.config.ui.tera_type_rate": "テラスタイプ率",
     "cobblemon.config.ui.tera_type_rate.tooltip": "スポーンしたポケモンのタイプと異なったテラタイプの出現確率。\"[入力した数値]分の1\"となる。",
     "cobblemon.config.ui.default_pastured_pokemon_limit": "デフォルトの牧草地ポケモン制限",
-    "cobblemon.config.ui.default_pastured_pokemon_limit.tooltip": "牧草ブロックに配置できるポケモンの最大数。",
-    "cobblemon.config.ui.pasture_block_update_ticks": "牧草ブロックの更新ティック",
+    "cobblemon.config.ui.default_pastured_pokemon_limit.tooltip": "ぼくじょうブロックに配置できるポケモンの最大数。",
+    "cobblemon.config.ui.pasture_block_update_ticks": "ぼくじょうブロックの更新ティック",
     "cobblemon.config.ui.pasture_max_wander_distance": "牧草地最大移動距離",
     "cobblemon.config.ui.pasture_max_per_chunk.tooltip": "1チャンクで送り出せる牧草地ポケモンの上限数。",
     "cobblemon.config.ui.max_inserted_fossil_items": "挿入された化石アイテムの最大数",
@@ -8670,7 +8670,7 @@
     "cobblemon.config.ui.disable_roll": "ロールを無効にする",
     "cobblemon.config.ui.despawner_near_distance": "近距離",
     "cobblemon.config.ui.remember_riding_camera.tooltip": "ライドできるポケモンをマウントした際、カメラモードが最後に使用したカメラモードに自動で切り替わるかどうか。",
-    "cobblemon.config.ui.allow_starter_on_join": "参加時にパートナーポケモンを許可する",
+    "cobblemon.config.ui.allow_starter_on_join": "参加時に最初のポケモンを許可する",
     "cobblemon.battle.clearboost": "%1$sの 能力変化が 元に戻った！",
     "cobblemon.battle.damage.ironbarbs": "%1$sは 傷ついた！",
     "cobblemon.battle.activate.allyswitch": "%1$sと %2$sは 場所を 入れ替えた！",
@@ -9522,8 +9522,8 @@
     "advancements.cobblemon.catch_alpha_wailord.description": "オヤブンホエルオーを釣り上げる",
     "advancements.cobblemon.catch_alpha_wailord": "うそです♪",
     "advancements.cobblemon.collect_all_vivillon.description": "ビビヨンの全ての模様を集める...",
-    "advancements.cobblemon.collect_all_vivillon": "将来有望ビビヨネア",
-    "advancements.cobblemon.collect_all_vivillon_full": "真の「ビビヨネア」",
+    "advancements.cobblemon.collect_all_vivillon": "貴方が噂のビビヨネア？",
+    "advancements.cobblemon.collect_all_vivillon_full": "真なる「ビビヨネア」ここに",
     "advancements.cobblemon.collect_all_vivillon_full.description": "…そして残りも手に入れる",
     "advancements.cobblemon.root_geological.description": "地下には、ありとあらゆるものが埋まっているものです",
     "advancements.cobblemon.root_geological": "興味深い石",
@@ -9590,5 +9590,11 @@
     "cobblemon.habitat.birch_wildfire_scar.name": "シラカバの山火事跡",
     "cobblemon.habitat.oak_wildfire_scar.name": "オークの山火事跡",
     "cobblemon.habitat.spruce_wildfire_scar.name": "トウヒの山火事跡",
-    "cobblemon.ui.pokedex.info.form.kyurem": " "
+    "cobblemon.ui.pokedex.info.form.kyurem": " ",
+    "cobblemon.ui.starter.random": "ランダム",
+    "cobblemon.ui.starter.random_description": "最初の一匹を選択プールの中からランダムで決定します。 選ばれるまでは誰になるか分かりません。",
+    "cobblemon.config.ui.world_spawning_blocklist": "ワールドごとのスポーンブロックリスト",
+    "cobblemon.config.ui.world_spawning_blocklist.tooltip": "ポケモンの出現ロジックを無効にするワールド。",
+    "advancements.cobblemon.obtain_tm": "Show Me Your Moves!",
+    "advancements.cobblemon.obtain_tm.description": "わざマシンを見つけるか、印刷する"
 }

common/src/main/resources/assets/cobblemon/lang/ko_kr.json

@@ -9543,5 +9543,11 @@
     "cobblemon.species.scovillain-mega.desc": "메가진화에 의해 매운 성분이 더욱 강해졌다. 넥타이처럼 변한 부분을 휘둘러 상대를 사정없이 때린다.",
     "cobblemon.species.glimmora-mega.desc": "거대해진 꽃잎이 분리되었다. 본체를 방어하면서 회전하며 독 파편을 흩뿌린다.",
     "cobblemon.species.tatsugiri-mega.desc": "메가진화에 의해 뇌가 활성화되어 한층 더 교활해졌다. 분신을 만들어 내어 능숙하게 활용한다.",
-    "cobblemon.species.tatsugiri-droopymega.desc": "메가진화의 에너지를 굳혀서 과잉 에너지의 형태로 발사한다. 무언가에 닿으면 크게 폭발한다."
+    "cobblemon.species.tatsugiri-droopymega.desc": "메가진화의 에너지를 굳혀서 과잉 에너지의 형태로 발사한다. 무언가에 닿으면 크게 폭발한다.",
+    "cobblemon.ui.starter.random": "무작위",
+    "cobblemon.ui.starter.random_description": "선택 가능한 포켓몬 목록에서 무작위로 선택되는 스타터 포켓몬입니다. 선택되기 전까지는 어떤 포켓몬이 나올지 알 수 없습니다.",
+    "cobblemon.config.ui.world_spawning_blocklist": "월드별 스폰 차단 목록",
+    "cobblemon.config.ui.world_spawning_blocklist.tooltip": "포켓몬 생성 로직을 비활성화하는 월드입니다.",
+    "advancements.cobblemon.obtain_tm": "기술을 보여줘!",
+    "advancements.cobblemon.obtain_tm.description": "TM을 찾거나 제작하세요"
 }

common/src/main/resources/assets/cobblemon/lang/pt_br.json

@@ -9325,5 +9325,11 @@
     "cobblemon.ability.dragonize": "Pele Dracônica",
     "cobblemon.ability.dragonize.desc": "Os movimentos do tipo Normal do Pokémon se tornam movimentos do tipo Dragão e sua força é aumentada em 20%.",
     "cobblemon.ability.megasol": "Mega Sol",
-    "cobblemon.ability.megasol.desc": "Mesmo quando a luz solar não está intensa, o Pokémon pode usar seus movimentos como se o clima fosse de luz solar intensa."
+    "cobblemon.ability.megasol.desc": "Mesmo quando a luz solar não está intensa, o Pokémon pode usar seus movimentos como se o clima fosse de luz solar intensa.",
+    "cobblemon.ui.starter.random": "Aleatório",
+    "cobblemon.ui.starter.random_description": "Um Pokémon inicial aleatório escolhido da lista de opções. É impossível saber qual será a não ser que seja escolhido.",
+    "cobblemon.config.ui.world_spawning_blocklist": "Permissões de Geração em Mundos",
+    "cobblemon.config.ui.world_spawning_blocklist.tooltip": "Mundos nos quais desabilitar a geração de Pokémon.",
+    "advancements.cobblemon.obtain_tm.description": "Encontrar ou gravar um TM",
+    "advancements.cobblemon.obtain_tm": "Olha esses movimentos!"
 }

common/src/main/resources/assets/cobblemon/lang/uk_ua.json

@@ -67,7 +67,7 @@
     "item.cobblemon.apricorn_chest_boat": "Абрикорновий човен зі скринею",
     "item.cobblemon.link_cable": "Кабель з'єднання",
     "item.cobblemon.dragon_scale": "Драконяча луска",
-    "item.cobblemon.kings_rock": "Королівське каміння",
+    "item.cobblemon.kings_rock": "Королівський камінь",
     "item.cobblemon.metal_coat": "Металеве покриття",
     "item.cobblemon.upgrade": "Покращення",
     "item.cobblemon.dubious_disc": "Сумнівний диск",
@@ -5933,7 +5933,7 @@
     "cobblemon.pokedex.variation.season": "Сезон",
     "cobblemon.pokedex.variation.snake_pattern": "Зміїний візерунок",
     "cobblemon.subtitle.pokemon.shiny_ambient": "Дикий сяйний Покемон іскрить!",
-    "cobblemon.subtitle.pokemon.shiny_shine": "Ваш сяйний Покемон сяє",
+    "cobblemon.subtitle.pokemon.shiny_shine": "Ваш сяйний Покемон мерехтить",
     "cobblemon.subtitle.wallpaper.unlock": "PC box wallpaper unlocked",
     "cobblemon.challenge.accept.receiver": "Ви прийняли виклик від %1$s!",
     "cobblemon.ui.challenge.challenge": "Виклик",
@@ -6193,21 +6193,21 @@
     "item.cobblemon.pokedex_red": "Покедекс",
     "item.cobblemon.pokedex_white": "Покедекс",
     "item.cobblemon.pokedex_yellow": "Покедекс",
-    "item.cobblemon.link_cable.tooltip": "Еволюціонує Покемонів при обміні",
+    "item.cobblemon.link_cable.tooltip": "Дозволяє еволюціонувати Покемону при обміні",
     "item.cobblemon.dragon_scale.tooltip": "Еволюціонує Сідра в Кінґдра, якщо тримає під час обміну",
     "item.cobblemon.kings_rock.tooltip_1": "Якщо власник наносить шкоду, ціль може зомліти",
     "item.cobblemon.kings_rock.tooltip_2": "Еволюціонує Полівірл в Політод та Слоупок в Слоукінґ, якщо тримає під час обміну",
     "item.cobblemon.metal_coat.tooltip_1": "Підвищує потужність дій Сталевого типу Покемону",
     "item.cobblemon.metal_coat.tooltip_2": "Еволюціонує Онікс в Стілікс та Скайзер в Сизор, якщо тримає під час обміну",
     "item.cobblemon.upgrade.tooltip": "Еволюціонує Поригон в Поригон2, якщо тримає під час обміну",
-    "item.cobblemon.dubious_disc.tooltip": "Еволюціонує Поригон2 в Поригон-Z, якщо тримає під час обміну",
+    "item.cobblemon.dubious_disc.tooltip": "Еволюціонує Поригон2 у Поригон-Z, якщо тримає під час обміну",
     "item.cobblemon.deep_sea_scale.tooltip_1": "Підвищує Сп.Захист Кламперла",
-    "item.cobblemon.deep_sea_scale.tooltip_2": "Еволюціонує Кламперл в Ґоребіс, якщо тримає під час обміну",
+    "item.cobblemon.deep_sea_scale.tooltip_2": "Еволюціонує Кламперл у Ґоребіс, якщо тримає під час обміну",
     "item.cobblemon.deep_sea_tooth.tooltip_1": "Підвищує Сп.Атаку Кламперла",
-    "item.cobblemon.deep_sea_tooth.tooltip_2": "Еволюціонує Кламперл в Хантейл, якщо тримає під час обміну",
+    "item.cobblemon.deep_sea_tooth.tooltip_2": "Еволюціонує Кламперл у Хантейл, якщо тримає під час обміну",
     "item.cobblemon.electirizer.tooltip": "Еволюціонує Електабазз в Електівайр, якщо тримає під час обміну",
-    "item.cobblemon.magmarizer.tooltip": "Еволюціонує Магмар в Магмортар, якщо тримає під час обміну",
-    "item.cobblemon.oval_stone.tooltip": "Еволюціонує Геппіні в Ченсі, якщо тримає вдень",
+    "item.cobblemon.magmarizer.tooltip": "Еволюціонує Магмар у Магмортар, якщо тримає під час обміну",
+    "item.cobblemon.oval_stone.tooltip": "Еволюціонує Геппіні у Ченсі, якщо тримає вдень",
     "item.cobblemon.protector.tooltip": "Еволюціонує Райдон в Райперіор, якщо тримає під час обміну",
     "item.cobblemon.reaper_cloth.tooltip": "Еволюціонує Дасклопс в Даскноїр, якщо тримає під час обміну",
     "item.cobblemon.sachet.tooltip": "Еволюціонує Спритзі в Ароматісс, якщо тримає під час обміну",
@@ -6976,7 +6976,7 @@
     "item.cobblemon.tough_candy": "Цукерка міцності",
     "cobblemon.ui.pokenav.narrator.backbutton": "Натиснута кнопка Покенавігатора",
     "cobblemon.ui.pokedex.info.form.vivillon-wings-archipelago": "Архіпелаг",
-    "cobblemon.subtitle.pokemon.owned_shiny_ambient": "Ваш сяйний Покемон іскрить",
+    "cobblemon.subtitle.pokemon.owned_shiny_ambient": "Сяйний Покемон мерехтить поряд",
     "cobblemon.challenge.accept.sender": "%1$s прийняв виклик!",
     "cobblemon.team.accept.sender": "%1$s прийняв ваше запрошення до команди!",
     "cobblemon.team.expired.receiver": "Час на запрошення від %1$s до команди сплив!",
@@ -7035,5 +7035,317 @@
     "cobblemon.config.ui.category.pokedex": "Покедекс",
     "cobblemon.config.ui.category.pokemon": "Покемон",
     "cobblemon.config.ui.category.spawning": "Поява",
-    "cobblemon.config.ui.category.battles": "Битви"
+    "cobblemon.config.ui.category.battles": "Битви",
+    "item.cobblemon.sweet_heart": "Солодке серце",
+    "item.cobblemon.sweet_heart.tooltip": "Солодкий шоколадний смаколик",
+    "item.cobblemon.technical_machine": "Технічна машина",
+    "item.cobblemon.blank_tm": "Пуста ТМ",
+    "block.cobblemon.deepslate_crystal_core": "Глибосланець з кристальним ядром",
+    "block.cobblemon.normal_gem_block": "Блок звичайного самоцвіту",
+    "block.cobblemon.normal_gem_cluster": "Друза звичайного самоцвіту",
+    "block.cobblemon.fire_gem_block": "Блок вогняного самоцвіту",
+    "block.cobblemon.water_gem_block": "Блок водяного самоцвіту",
+    "block.cobblemon.electric_gem_block": "Блок електричного самоцвіту",
+    "block.cobblemon.grass_gem_block": "Блок трав'яного самоцвіту",
+    "block.cobblemon.ice_gem_block": "Блок крижаного самоцвіту",
+    "block.cobblemon.fighting_gem_block": "Блок бойового самоцвіту",
+    "block.cobblemon.poison_gem_block": "Блок отруйного самоцвіту",
+    "block.cobblemon.ground_gem_block": "Блок земляного самоцвіту",
+    "block.cobblemon.flying_gem_block": "Блок літаючого самоцвіту",
+    "block.cobblemon.psychic_gem_block": "Блок психічного самоцвіту",
+    "block.cobblemon.bug_gem_block": "Блок комашиного самоцвіту",
+    "block.cobblemon.rock_gem_block": "Блок кам'яного самоцвіту",
+    "block.cobblemon.ghost_gem_block": "Блок примарного самоцвіту",
+    "block.cobblemon.dragon_gem_block": "Блок драконячого самоцвіту",
+    "block.cobblemon.dark_gem_block": "Блок темного самоцвіту",
+    "block.cobblemon.steel_gem_block": "Блок сталевого самоцвіту",
+    "block.cobblemon.fairy_gem_block": "Блок чарівного самоцвіту",
+    "block.cobblemon.fire_gem_cluster": "Друза вогняного самоцвіту",
+    "block.cobblemon.water_gem_cluster": "Друза водяного самоцвіту",
+    "block.cobblemon.electric_gem_cluster": "Друза електричного самоцвіту",
+    "block.cobblemon.grass_gem_cluster": "Друза трав'яного самоцвіту",
+    "block.cobblemon.ice_gem_cluster": "Друза крижаного самоцвіту",
+    "block.cobblemon.fighting_gem_cluster": "Друза бойового самоцвіту",
+    "block.cobblemon.poison_gem_cluster": "Друза отруйного самоцвіту",
+    "block.cobblemon.ground_gem_cluster": "Друза земляного самоцвіту",
+    "block.cobblemon.flying_gem_cluster": "Друза літаючого самоцвіту",
+    "block.cobblemon.psychic_gem_cluster": "Друза психічного самоцвіту",
+    "block.cobblemon.bug_gem_cluster": "Друза комашиного самоцвіту",
+    "block.cobblemon.rock_gem_cluster": "Друза кам'яного самоцвіту",
+    "block.cobblemon.ghost_gem_cluster": "Друза примарного самоцвіту",
+    "block.cobblemon.dragon_gem_cluster": "Друза драконячого самоцвіту",
+    "block.cobblemon.dark_gem_cluster": "Друза темного самоцвіту",
+    "block.cobblemon.steel_gem_cluster": "Друза сталевого самоцвіту",
+    "block.cobblemon.fairy_gem_cluster": "Друза чарівного самоцвіту",
+    "cobblemon.item_class.technical_machine": "Технічна машина",
+    "block.cobblemon.damaged_monitor": "Пошкоджений монітор даних",
+    "block.cobblemon.tm_machine": "ТМ прилад",
+    "block.cobblemon.disc_shelf": "Дискова поличка",
+    "cobblemon.fishing_bait_effects.mark_chance.tooltip": "%1$s%% - +%3$s%% шанс мітки",
+    "cobblemon.fishing_bait_effects.alpha_chance.tooltip": "%1$s%% - приваблює Альфа Покемонів",
+    "cobblemon.fishing_bait_effects.size.tooltip": "%1$s%% - змінює розмір на %3$s%%",
+    "cobblemon.technical_machine_effect_header": "Про технічну машину:",
+    "cobblemon.ui.edit.habitat.spawn.time_of_day.any": "Будь-яке",
+    "cobblemon.ui.edit.habitat.spawn.min_light": "Мін. світло (0-15, за бажанням)",
+    "cobblemon.ui.edit.habitat.spawn.max_light": "Макс. світло (0-15, за бажанням)",
+    "cobblemon.ui.edit.habitat.spawn.back": "Назад",
+    "cobblemon.ui.edit.habitat.validation.mimic": "Імітатор блока повинен бути дійсним (перевірте habitat_mimics.json).",
+    "cobblemon.ui.edit.habitat.validation.phases": "Кількість фаз повинна бути більше 0.",
+    "cobblemon.ui.edit.habitat.validation.level_range": "Діапазон рівнів повинен бути в межах від 1 до 100, а мін. значення не може перевищувати макс.",
+    "cobblemon.ui.edit.habitat.validation.spawn_range": "Діапазон появи повинен дорівнювати 0 або більшим.",
+    "cobblemon.ui.edit.habitat.validation.cancelled_range": "Діапазон забороненої природної появи має дорівнювати -1 (скасування недоступне) або ж від 0 до 64.",
+    "cobblemon.ui.edit.habitat.validation.max_spawns": "Макс. поява має бути -1 або більше.",
+    "cobblemon.ui.edit.habitat.validation.influence_range": "Діапазон впливу повинен бути 0 або більшим.",
+    "cobblemon.ui.edit.habitat.validation.species": "Вид повинен мати дійсну назву Покемона.",
+    "cobblemon.ui.edit.habitat.validation.weight": "Вага має бути більшою за 0.",
+    "cobblemon.ui.edit.habitat.validation.modifiers": "Формат модифікатора недійсний.",
+    "cobblemon.ui.edit.habitat.validation.phases_list": "У фазах слід використовувати правильний формат для діапазонів, наприклад 1–3 або 1, 3–5, 6.",
+    "cobblemon.ui.edit.habitat.validation.min_light": "Мін. світло має бути між 0 та 15.",
+    "cobblemon.ui.edit.habitat.validation.max_light": "Макс. світло має бути між 0 та 15.",
+    "cobblemon.ui.starter.random": "Випадково",
+    "cobblemon.ui.starter.random_description": "Випадковий початковий Покемон із доступних. Хто це буде – дізнаєшся лише після вибору!",
+    "cobblemon.ui.moves.learnset.tm.discovered": "Виявлено",
+    "cobblemon.ui.moves.level": "Підвищення рівня",
+    "cobblemon.ui.moves.egg": "Яйце",
+    "cobblemon.ui.moves.tm": "ТМ",
+    "cobblemon.ui.tm_machine.can_learn": "Може навчитися",
+    "cobblemon.ui.tm_machine.cannot_learn": "Не може навчитися",
+    "cobblemon.ui.tm_machine.learned": "Навчений",
+    "cobblemon.tms.unknown_move": "Невідома дія",
+    "cobblemon.tms.already_known": "%1$s вже знає %2$s!",
+    "cobblemon.tms.teach_move": "%1$s навчився %2$s!",
+    "cobblemon.tms.cannot_learn": "%1$s не може вивчити %2$s!",
+    "cobblemon.tms.unlock_tm": "Ви розблокували ТМ для %1$s!",
+    "cobblemon.tms.new_tms_learned": "Вивчено нові ТМ!",
+    "cobblemon.tms.check_tmm": "Перевірте ТМ прилад",
+    "cobblemon.ui.party.party_select_title": "Змінити вибір Покегрупи",
+    "cobblemon.ui.party.party_select_description": "Натисніть %1$s/%2$s або утримуйте %3$s і прокрутіть.",
+    "cobblemon.ui.category": "Категорія",
+    "cobblemon.ui.pp": "ОП",
+    "cobblemon.ui.pokemon.alpha": "Альфа",
+    "cobblemon.ui.sort.discovered": "Сортувати за статусом виявлення",
+    "cobblemon.ui.pokedex.search.type.moves": "Назва дії",
+    "cobblemon.ui.pokedex.filter.all": "Усі",
+    "cobblemon.mark.ribbon_battler_skillful.title": "Ветеран %1$s",
+    "cobblemon.mark.ribbon_battler_skillful.desc": "Стрічка, яку можна вручити Покемону, що здобув перемогу у складних боях.",
+    "cobblemon.mark.ribbon_best_friends": "Стрічка кращого друга",
+    "cobblemon.mark.ribbon_best_friends.title": "Найкращий друг %1$s",
+    "cobblemon.mark.ribbon_champion": "Чемпіонська стрічка",
+    "cobblemon.mark.ribbon_champion.title": "Чемпіон %1$s",
+    "cobblemon.requires_debug_keys": "Щоб скористатися цією функцією, на сервері мають бути увімкнені клавіші налагодження.",
+    "cobblemon.requires_permission": "У вас немає необхідних прав для виконання цієї дії.",
+    "cobblemon.command.technicalmachine.invalid-tm": "Недійсна ТМ",
+    "cobblemon.ui.generic.question_marks": "???",
+    "cobblemon.container.tm_machine": "ТМ прилад",
+    "cobblemon.ui.edit.habitat": "Редактор оселищ",
+    "cobblemon.ui.edit.habitat.mimic_id": "Ідентифікатор блока-імітації",
+    "cobblemon.ui.edit.habitat.phase_order": "Фаза порядку: %s",
+    "cobblemon.ui.edit.habitat.level_range": "Діапазон рівнів (Мін. - Макс.)",
+    "cobblemon.ui.edit.habitat.mode": "Режим: %s",
+    "cobblemon.ui.edit.habitat.mode.activated": "Активований",
+    "cobblemon.ui.edit.habitat.mode.natural": "Натуральний",
+    "cobblemon.ui.edit.habitat.trigger": "Подразник: %s",
+    "cobblemon.ui.edit.habitat.spawn_range": "Діапазон появи (в блоках)",
+    "cobblemon.ui.edit.habitat.cancelled_range": "Діапазон заборони природної появи (в блоках)",
+    "cobblemon.ui.edit.habitat.max_spawns": "Макс. поява (-1 для нескінченних)",
+    "cobblemon.ui.edit.habitat.replace_spawns": "Заміна появи: %s",
+    "cobblemon.ui.edit.habitat.influence_range": "Діапазон впливу (в блоках)",
+    "cobblemon.ui.edit.habitat.pool": "Група: %s",
+    "cobblemon.ui.edit.habitat.pool.custom": "Власна",
+    "cobblemon.ui.edit.habitat.view_pool": "Перегляд групи",
+    "cobblemon.ui.edit.habitat.edit_pool": "Налаштування групи появи",
+    "cobblemon.ui.edit.habitat.pool.title": "Редактор групи появи",
+    "cobblemon.ui.edit.habitat.pool.species": "Вид",
+    "cobblemon.ui.edit.habitat.pool.levels": "Рівні",
+    "cobblemon.ui.edit.habitat.pool.phases": "Фази",
+    "cobblemon.ui.edit.habitat.pool.position": "Позиція",
+    "cobblemon.ui.edit.habitat.pool.weight": "Вага",
+    "cobblemon.ui.edit.habitat.pool.bucket": "Категорія",
+    "cobblemon.ui.edit.habitat.pool.add_spawn": "Додати появу",
+    "cobblemon.ui.edit.habitat.pool.back": "Назад",
+    "cobblemon.ui.edit.habitat.pool.select": "Обрати групу появи",
+    "cobblemon.ui.edit.habitat.spawn": "Редактор появи",
+    "cobblemon.ui.edit.habitat.spawn.species_name": "Назва виду",
+    "cobblemon.ui.edit.habitat.spawn.position_type": "Тип позиції: %s",
+    "cobblemon.ui.edit.habitat.spawn.bucket": "Категорія: %s",
+    "cobblemon.ui.edit.habitat.spawn.weight": "Вага",
+    "cobblemon.ui.edit.habitat.spawn.level_range": "Діапазон рівнів (Мін. - Макс.)",
+    "cobblemon.ui.edit.habitat.spawn.modifiers": "Модифікатори (наприклад, стать сяйних Покемонів=чоловіча)",
+    "cobblemon.ui.edit.habitat.spawn.phases": "Фази (наприклад, 1-3, 5)",
+    "cobblemon.ui.edit.habitat.spawn.time_of_day": "Час доби",
+    "cobblemon.ui.edit.habitat.spawn.time_of_day.value": "Час доби: %s",
+    "cobblemon.ui.pokedex.info.form.zacian-crowned": "Коронований меч",
+    "cobblemon.ui.pokedex.info.form.zamazenta-crowned": "Коронований щит",
+    "cobblemon.ui.pokedex.filter.owned": "У власності",
+    "cobblemon.ui.pokedex.filter.seen": "Переглянуто",
+    "cobblemon.ui.pokedex.filter.unregistered": "Незареєстрований",
+    "cobblemon.ui.pokedex.filter.rideable": "Їздовий",
+    "cobblemon.ui.pokedex.filter.undiscovered_tm_move": "Невідкрита ТМ дія",
+    "cobblemon.ui.pokedex.info.form.noice-face": "Крижано",
+    "cobblemon.mark.ribbon_ability": "Стрічка здібності",
+    "cobblemon.mark.ribbon_ability.desc": "Стрічка, що вручається за перемогу над Господарем вежі у Бойовій вежі.",
+    "cobblemon.mark.ribbon_ability_double": "Стрічка подвійної здібності",
+    "cobblemon.mark.ribbon_ability_double.desc": "Стрічка, що вручається за завершення Подвійного випробування у Бойовій вежі.",
+    "cobblemon.mark.ribbon_ability_great": "Стрічка великої здібності",
+    "cobblemon.mark.ribbon_ability_great.desc": "Стрічка, що вручається за перемогу над Господарем вежі у Бойовій вежі.",
+    "cobblemon.mark.ribbon_ability_multi": "Стрічка мультиздібності",
+    "cobblemon.mark.ribbon_ability_multi.desc": "Стрічка, що вручається за завершення Мульти-випробування у Бойовій вежі.",
+    "cobblemon.mark.ribbon_ability_pair": "Стрічка парної здібності",
+    "cobblemon.mark.ribbon_ability_pair.desc": "Стрічка, що вручається за завершення Командного мульти-випробування у Бойовій вежі.",
+    "cobblemon.mark.ribbon_ability_world": "Стрічка світової здібності",
+    "cobblemon.mark.ribbon_ability_world.desc": "Стрічка, що вручається за завершення Wi-Fi випробування у Бойовій вежі.",
+    "cobblemon.mark.ribbon_artist": "Стрічка митця",
+    "cobblemon.mark.ribbon_artist.title": "Модель для картин %1$s",
+    "cobblemon.mark.ribbon_artist.desc": "Стрічка, що вручається за обрання в якості найкращої моделі для супер нарису.",
+    "cobblemon.mark.ribbon_battle_royal_master": "Стрічка майстра Королівської битви",
+    "cobblemon.mark.ribbon_battle_royal_master.title": "Королівський майстер %1$s",
+    "cobblemon.mark.ribbon_battle_royal_master.desc": "Стрічка, що вручається Покемону за перемогу в Королівській битві.",
+    "cobblemon.mark.ribbon_battle_tree_great": "Велика стрічка Бойового дерева",
+    "cobblemon.mark.ribbon_battle_tree_great.title": "Переможець Бойового дерева %1$s",
+    "cobblemon.mark.ribbon_battle_tree_great.desc": "Стрічка, що вручається за перемогу над Бойовою легендою у Бойовому дереві.",
+    "cobblemon.mark.ribbon_battle_tree_master": "Стрічка майстра Бойового дерева",
+    "cobblemon.mark.ribbon_battle_tree_master.title": "Майстер Бойового дерева %1$s",
+    "cobblemon.mark.ribbon_battle_tree_master.desc": "Стрічка, що вручається за перемогу над Бойовою легендою у супер битві у Бойовому дереві.",
+    "cobblemon.mark.ribbon_battle_tower_master": "Стрічка майстра вежі",
+    "cobblemon.mark.ribbon_battle_tower_master.title": "Майстер вежі %1$s",
+    "cobblemon.mark.ribbon_battle_tower_master.desc": "Стрічка, що вручається за перемогу над чемпіоном у Бойовій вежі.",
+    "cobblemon.mark.ribbon_battle_victory": "Стрічка перемоги",
+    "cobblemon.mark.ribbon_battle_victory.desc": "Стрічка, що вручається за зачистку 100 рв. у випробуванні у Бойовій вежі.",
+    "cobblemon.mark.ribbon_battle_winning": "Переможна стрічка",
+    "cobblemon.mark.ribbon_battle_winning.desc": "Стрічка, що вручається за зачистку 50 рв. у випробуванні у Бойовій вежі.",
+    "cobblemon.mark.ribbon_battler_expert": "Стрічка експертного бійця",
+    "cobblemon.mark.ribbon_battler_expert.title": "Майстер %1$s",
+    "cobblemon.mark.ribbon_battler_expert.desc": "Стрічка, що вручається відважному Покемону, що довів свою бойову майстерність до рівня мистецтва.",
+    "cobblemon.mark.ribbon_battler_skillful": "Стрічка досвідченого бійця",
+    "cobblemon.mark.ribbon_best_friends.desc": "Стрічка, що вручається Покемону, з яким вас єднає особливий та міцний зв’язок.",
+    "cobblemon.mark.ribbon_champion.desc": "Стрічка, що вручається за перемогу у Лізі Покемонів.",
+    "cobblemon.mark.ribbon_champion_alola": "Стрічка Чемпіона Алоли",
+    "cobblemon.mark.ribbon_champion_alola.title": "Чемпіон Алоли %1$s",
+    "cobblemon.mark.ribbon_champion_alola.desc": "Стрічка, що вручається за здобуття звання Чемпіона Алоли.",
+    "cobblemon.mark.ribbon_champion_galar": "Стрічка Чемпіона Ґалари",
+    "cobblemon.mark.ribbon_champion_galar.title": "Чемпіон Ґалари %1$s",
+    "cobblemon.mark.ribbon_champion_galar.desc": "Стрічка, що вручається за здобуття звання Чемпіона Ґалари.",
+    "cobblemon.mark.ribbon_champion_hoenn": "Стрічка Чемпіона Гоенн",
+    "cobblemon.mark.ribbon_champion_hoenn.title": "Чемпіон Гоенн %1$s",
+    "cobblemon.mark.ribbon_champion_hoenn.desc": "Стрічка, що вручається за перемогу над Чемпіоном Гоенн.",
+    "cobblemon.mark.ribbon_champion_kalos": "Стрічка Чемпіона Калоса",
+    "cobblemon.mark.ribbon_champion_kalos.title": "Чемпіон Калоса %1$s",
+    "cobblemon.mark.ribbon_champion_kalos.desc": "Стрічка, що вручається за перемогу над Чемпіоном Калоса.",
+    "cobblemon.mark.ribbon_champion_paldea": "Стрічка Чемпіона Палдеї",
+    "cobblemon.mark.ribbon_champion_paldea.title": "Чемпіон Палдеї %1$s",
+    "cobblemon.mark.ribbon_champion_paldea.desc": "Стрічка, що вручається за здобуття звання Чемпіона Палдеї.",
+    "cobblemon.mark.ribbon_champion_sinnoh": "Стрічка Чемпіона Сінно",
+    "cobblemon.mark.ribbon_champion_sinnoh.title": "Чемпіон Сінно %1$s",
+    "cobblemon.mark.ribbon_champion_sinnoh.desc": "Стрічка, що вручається за перемогу над Чемпіоном Сінно.",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_1": "Стрічка краси",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_1.desc": "Переможець конкурсу краси в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_2": "Супер стрічка краси",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_2.desc": "Переможець конкурсу краси в \"Супер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_3": "Гіпер стрічка краси",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_3.desc": "Переможець конкурсу краси в \"Гіпер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_4": "Майстерна стрічка краси",
+    "cobblemon.mark.ribbon_contest_hoenn_beauty_4.desc": "Переможець конкурсу краси в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_1": "Стрічка крутості",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_2.desc": "Переможець конкурсу крутості в \"Супер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_1.desc": "Переможець конкурсу крутості в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_2": "Супер стрічка крутості",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_3": "Гіпер стрічка крутості",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_3.desc": "Переможець конкурсу крутості в \"Гіпер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_4": "Майстер стрічка крутості",
+    "cobblemon.mark.ribbon_contest_hoenn_cool_4.desc": "Переможець конкурсу крутості в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_1": "Стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_1.desc": "Переможець конкурсу чарівності в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_2": "Супер стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_2.desc": "Переможець конкурсу чарівності в \"Супер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_3": "Гіпер стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_3.desc": "Переможець конкурсу чарівності в \"Гіпер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_4": "Майстер стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_hoenn_cute_4.desc": "Переможець конкурсу чарівності в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_1": "Стрічка розуму",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_1.desc": "Переможець конкурсу розуму в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_2": "Супер стрічка розуму",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_2.desc": "Переможець конкурсу розуму в \"Супер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_3": "Гіпер стрічка розуму",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_3.desc": "Переможець конкурсу розуму в \"Гіпер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_4": "Майстер стрічка розуму",
+    "cobblemon.mark.ribbon_contest_hoenn_smart_4.desc": "Переможець конкурсу розуму в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_1": "Стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_1.desc": "Переможець конкурсу витривалості в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_2": "Супер стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_2.desc": "Переможець конкурсу витривалості в \"Супер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_3": "Гіпер стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_3.desc": "Переможець конкурсу витривалості в \"Гіпер\" номінації!",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_4": "Майстер стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_hoenn_tough_4.desc": "Переможець конкурсу витривалості в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_1": "Стрічка краси",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_1.desc": "Переможець супер конкурсу краси в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_2": "Чудова стрічка краси",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_2.desc": "Переможець супер конкурсу краси в \"Чудовій\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_3": "Ультра стрічка краси",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_3.desc": "Переможець супер конкурсу краси в \"Ультра\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_4": "Майстер стрічка краси",
+    "cobblemon.mark.ribbon_contest_sinnoh_beauty_4.desc": "Переможець супер конкурсу краси в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_1": "Стрічка крутості",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_1.desc": "Переможець супер конкурсу крутості в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_2": "Чудова стрічка крутості",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_2.desc": "Переможець супер конкурсу крутості в \"Чудовій\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_3": "Ультра стрічка крутості",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_3.desc": "Переможець супер конкурсу крутості в \"Ультра\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_4": "Майстер стрічка крутості",
+    "cobblemon.mark.ribbon_contest_sinnoh_cool_4.desc": "Переможець супер конкурсу крутості в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_1": "Стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_1.desc": "Переможець супер конкурсу чарівності в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_2": "Чудова стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_2.desc": "Переможець супер конкурсу чарівності в \"Чудовій\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_3": "Ультра стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_3.desc": "Переможець супер конкурсу чарівності в \"Ультра\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_4": "Майстер стрічка чарівності",
+    "cobblemon.mark.ribbon_contest_sinnoh_cute_4.desc": "Переможець супер конкурсу чарівності в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_1": "Стрічка розуму",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_1.desc": "Переможець супер конкурсу розуму в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_2": "Чудова стрічка розуму",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_2.desc": "Переможець супер конкурсу розуму в \"Чудовій\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_3": "Ультра стрічка розуму",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_3.desc": "Переможець супер конкурсу розуму в \"Ультра\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_4": "Майстер стрічка розуму",
+    "cobblemon.mark.ribbon_contest_sinnoh_smart_4.desc": "Переможець супер конкурсу розуму в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_1": "Стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_1.desc": "Переможець супер конкурсу витривалості в \"Звичайній\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_2": "Чудова стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_2.desc": "Переможець супер конкурсу витривалості в \"Чудовій\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_3": "Ультра стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_3.desc": "Переможець супер конкурсу витривалості в \"Ультра\" номінації!",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_4": "Майстер стрічка витривалості",
+    "cobblemon.mark.ribbon_contest_sinnoh_tough_4.desc": "Переможець супер конкурсу витривалості в \"Майстер\" номінації!",
+    "cobblemon.mark.ribbon_contest_super_master_beauty": "Стрічка майстра краси",
+    "cobblemon.mark.ribbon_contest_super_master_beauty.title": "Вінтажна краса %1$s",
+    "cobblemon.mark.ribbon_contest_super_master_beauty.desc": "Стрічка, що вручається Покемону, який досконало проявив свою красу в конкурсах Покемонів.",
+    "cobblemon.mark.ribbon_contest_super_master_cleverness": "Стрічка майстра кмітливості",
+    "cobblemon.mark.ribbon_contest_super_master_cleverness.title": "Історичний геній %1$s",
+    "cobblemon.mark.ribbon_contest_super_master_cleverness.desc": "Стрічка, що вручається Покемону, який досконало проявив свою кмітливість в конкурсах Покемонів.",
+    "cobblemon.mark.ribbon_contest_super_master_coolness": "Стрічка майстра крутості",
+    "cobblemon.mark.ribbon_contest_super_master_coolness.title": "Зірка %1$s",
+    "cobblemon.mark.ribbon_contest_super_master_coolness.desc": "Стрічка, що вручається Покемону, який досконало проявив свою крутість в конкурсах Покемонів.",
+    "cobblemon.mark.ribbon_contest_super_master_cuteness": "Стрічка майстра чарівності",
+    "cobblemon.mark.ribbon_contest_super_master_cuteness.title": "Ідол %1$s",
+    "cobblemon.mark.ribbon_contest_super_master_cuteness.desc": "Стрічка, що вручається Покемону, який досконало проявив свою чарівність в конкурсах Покемонів.",
+    "cobblemon.mark.ribbon_contest_super_master_toughness": "Стрічка майстра витривалості",
+    "cobblemon.mark.ribbon_contest_super_master_toughness.title": "Здоровило %1$s",
+    "cobblemon.mark.ribbon_contest_super_master_toughness.desc": "Стрічка, що вручається Покемону, який досконало проявив свою витривалість в конкурсах Покемонів.",
+    "cobblemon.mark.ribbon_contest_super_star": "Стрічка зірки конкурсів",
+    "cobblemon.mark.ribbon_contest_super_star.title": "Яскрава зірка %1$s",
+    "cobblemon.mark.ribbon_contest_super_star.desc": "Стрічка, що вручається Покемону, який блискуче проявив себе у всіх видах конкурсів.",
+    "cobblemon.mark.ribbon_contest_super_star_twinkling": "Стрічка мерехтливої зірки",
+    "cobblemon.mark.ribbon_contest_super_star_twinkling.title": "Мерехтлива зірка %1$s",
+    "cobblemon.mark.ribbon_contest_super_star_twinkling.desc": "Стрічка, що вручається Покемону, який блискуче проявив себе у всіх видах Супер конкурсів.",
+    "cobblemon.mark.ribbon_day_alert": "Стрічка пильності",
+    "cobblemon.mark.ribbon_day_alert.title": "Пильний %1$s",
+    "cobblemon.mark.ribbon_day_alert.desc": "Стрічка на згадку про сповнену життєвої енергії подію.",
+    "cobblemon.mark.ribbon_day_careless": "Стрічка незграбності",
+    "cobblemon.mark.ribbon_day_careless.title": "Недосконалий %1$s",
+    "cobblemon.mark.ribbon_day_careless.desc": "Стрічка на згадку про необачну помилку, яка допомогла визначити життєвий шлях.",
+    "cobblemon.mark.ribbon_day_downcast": "Стрічка смутку",
+    "cobblemon.mark.ribbon_day_downcast.desc": "Стрічка на згадку про почуття смутку, що додали життю барв.",
+    "cobblemon.mark.ribbon_day_downcast.title": "Приголомшений %1$s",
+    "cobblemon.mark.ribbon_day_relax": "Стрічка відпочинку"
 }

common/src/main/resources/assets/cobblemon/lang/zh_cn.json

@@ -9671,5 +9671,11 @@
     "cobblemon.size_category.s": "S",
     "cobblemon.size_category.m": "M",
     "cobblemon.size_category.l": "L",
-    "cobblemon.size_category.xl": "XL"
+    "cobblemon.size_category.xl": "XL",
+    "cobblemon.ui.starter.random": "随机",
+    "cobblemon.ui.starter.random_description": "在可选择的初始宝可梦池中随机。在被选中之前将无法得知为谁。",
+    "cobblemon.config.ui.world_spawning_blocklist": "维度生成黑名单",
+    "cobblemon.config.ui.world_spawning_blocklist.tooltip": "禁用宝可梦生成逻辑的维度。",
+    "advancements.cobblemon.obtain_tm": "让我看看你的招式",
+    "advancements.cobblemon.obtain_tm.description": "发现或刻写一个招式学习器"
 }

common/src/main/resources/assets/cobblemon/models/block/display_case.json

@@ -16,9 +16,9 @@
 			"to": [16, 4, 16],
 			"faces": {
 				"north": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "north"},
-				"east": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "north"},
-				"south": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "north"},
-				"west": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "north"},
+				"east": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "east"},
+				"south": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "south"},
+				"west": {"uv": [0, 12, 16, 16], "texture": "#1", "cullface": "west"},
 				"up": {"uv": [0, 0, 16, 16], "texture": "#3"},
 				"down": {"uv": [0, 0, 16, 16], "texture": "#0", "cullface": "down"}
 			}

common/src/main/resources/assets/cobblemon/sounds.json

@@ -1346,7 +1346,7 @@
     "sounds": [ { "name": "cobblemon:move/icebeam/icebeam_target_1", "volume": 0.8 } ]
   },
   "move.icebeam.target_2": {
-    "sounds": [ { "name": "cobblemon:move/icebeam/icebeam_target_2", "volume": 0.8 } ]
+    "sounds": [ { "name": "cobblemon:move/icebeam/icebeam_target_2", "volume": 0.5 } ]
   },
   "move.infestation.actor": {
     "sounds": [ { "name": "cobblemon:move/infestation/infestation_actor", "volume": 0.8 } ]
@@ -1453,6 +1453,36 @@
   "move.waterpulse.target": {
     "sounds": [ { "name": "cobblemon:move/waterpulse/waterpulse_target", "volume": 0.8 } ]
   },
+  "move.leafstorm.actor": {
+    "sounds": [ { "name": "cobblemon:move/leafstorm/leafstorm_actor", "volume": 1.0 } ]
+  },
+  "move.leafstorm.target": {
+    "sounds": [ { "name": "cobblemon:move/leafstorm/leafstorm_target", "volume": 1.0 } ]
+  },
+  "move.suckerpunch.target": {
+    "sounds": [ { "name": "cobblemon:move/suckerpunch/suckerpunch_target", "volume": 1.0 } ]
+  },
+  "move.blizzard.actor": {
+    "sounds": [ { "name": "cobblemon:move/blizzard/blizzard_actor", "volume": 1.0 } ]
+  },
+  "move.blizzard.target": {
+    "sounds": [ { "name": "cobblemon:move/blizzard/blizzard_target", "volume": 1.0 } ]
+  },
+  "move.hydropump.actor": {
+    "sounds": [ { "name": "cobblemon:move/hydropump/hydropump_actor", "volume": 1.0 } ]
+  },
+  "move.hydropump.target": {
+    "sounds": [ { "name": "cobblemon:move/hydropump/hydropump_target", "volume": 1.0 } ]
+  },
+  "move.lightscreen.actor": {
+    "sounds": [ { "name": "cobblemon:move/lightscreen/lightscreen_actor", "volume": 1.0 } ]
+  },
+  "move.horndrill.target_1": {
+    "sounds": [ { "name": "cobblemon:move/horndrill/horndrill_target_1", "volume": 0.8 } ]
+  },
+  "move.horndrill.target_2": {
+    "sounds": [ { "name": "cobblemon:move/horndrill/horndrill_target_2", "volume": 1.0 } ]
+  },
   "impact.normal": {
     "sounds": [
       { "name": "cobblemon:move/impact_generic/impact_generic_fighting_1", "volume": 0.8 },

common/src/main/resources/data/cobblemon/action_effects/moves/blizzard.json

@@ -15,6 +15,11 @@
       "locators": ["root"],
       "targetLocators": ["middle"]
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == true",
+      "expressions": ["q.sound('move.blizzard.actor');"]
+    },
     {
       "type": "pause",
       "pause": 0.3
@@ -27,7 +32,16 @@
     },
     {
       "type": "pause",
-      "pause": 0.85
+      "pause": 0.2
+    },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false",
+      "expressions": ["q.sound('move.blizzard.target');"]
+    },
+    {
+      "type": "pause",
+      "pause": 0.65
     },
     {
       "type": "entity_particles",

common/src/main/resources/data/cobblemon/action_effects/moves/horndrill.json

@@ -15,6 +15,11 @@
       "effect": "cobblemon:horndrill_target",
       "locators": ["target"]
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false",
+      "expressions": ["q.sound('move.horndrill.target_1');"]
+    },
     {
       "type": "pause",
       "pause": 0.2
@@ -40,11 +45,6 @@
     {
         "type": "sequence",
         "keyframes": [
-            {
-                "type": "entity_sound",
-                "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false && q.failed(q.entity.uuid) == false",
-                "sound": "cobblemon:impact.normal"
-            },
             {
                 "type": "entity_particles",
                 "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false && q.failed(q.entity.uuid) == false",
@@ -56,6 +56,11 @@
                 "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false && q.failed(q.entity.uuid) == false",
                 "effect": "cobblemon:quickattack_targetsparks",
                 "locators": ["target"]
+            },
+            {
+              "type": "entity_molang",
+              "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false && q.failed(q.entity.uuid) == false",
+              "expressions": ["q.sound('move.horndrill.target_2');"]
             }
         ]
     },

common/src/main/resources/data/cobblemon/action_effects/moves/hydropump.json

@@ -21,6 +21,11 @@
       "locators": ["special", "target"],
       "targetLocators": ["target"]
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == true",
+      "expressions": ["q.sound('move.hydropump.actor');"]
+    },
     {
       "type": "pause",
       "pause": 0.03
@@ -46,6 +51,11 @@
       "animation": ["recoil"],
       "entityCondition": "q.entity.is_user == false && q.hurt(q.entity.uuid) == true && q.missed(q.entity.uuid) == false"
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false",
+      "expressions": ["q.sound('move.hydropump.target');"]
+    },
     {
       "type": "pause",
       "pause": 0.55

common/src/main/resources/data/cobblemon/action_effects/moves/leafstorm.json

@@ -15,6 +15,11 @@
       "locators": ["special", "target"],
       "targetLocators": ["middle"]
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == true",
+      "expressions": ["q.sound('move.leafstorm.actor');"]
+    },
     {
       "type": "pause",
       "pause": 0.1
@@ -35,6 +40,11 @@
       "effect": "cobblemon:leafstorm_target",
       "locators": ["target"]
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false",
+      "expressions": ["q.sound('move.leafstorm.target');"]
+    },
     {
       "type": "animation",
       "animation": ["recoil"],

common/src/main/resources/data/cobblemon/action_effects/moves/lightscreen.json

@@ -15,6 +15,11 @@
         "effect": "cobblemon:lightscreen_actor",
         "locators": ["target"]
       },
+      {
+        "type": "entity_molang",
+        "entityCondition": "q.entity.is_user == true && q.failed == false",
+        "expressions": ["q.sound('move.lightscreen.actor');"]
+      },
       {
         "type": "pause",
         "pause": 0.07

common/src/main/resources/data/cobblemon/action_effects/moves/suckerpunch.json

@@ -27,6 +27,11 @@
       "effect": "cobblemon:suckerpunch_target1",
       "locator": "target"
     },
+    {
+      "type": "entity_molang",
+      "entityCondition": "q.entity.is_user == false && q.missed(q.entity.uuid) == false",
+      "expressions": ["q.sound('move.suckerpunch.target');"]
+    },
     {
       "type": "pause",
       "pause": 0.2

common/src/main/resources/data/cobblemon/moveset_builders/alpha.json

@@ -2,6 +2,6 @@
   "type": "cobblemon:default",
   "slot1": ["last_suitable_offensive", "last_offensive", "last_levelup"],
   "slot2": ["last_offensive", "last_levelup"],
-  "slot3": ["last_levelup"],
+  "slot3": ["tm", "last_levelup"],
   "slot4": ["tm", "last_levelup"]
 }

common/src/main/resources/data/cobblemon/worldgen/processor_list/habitats/rocky_tidepool.json

@@ -5,15 +5,15 @@
             "rules": [
                 {
                     "input_predicate": {
-                        "block": "minecraft:short_grass",
+                        "block": "minecraft:seagrass",
                         "predicate_type": "minecraft:random_block_match",
-                        "probability": 0.9
+                        "probability": 0.4
                     },
                     "location_predicate": {
                         "predicate_type": "minecraft:always_true"
                     },
                     "output_state": {
-                        "Name": "minecraft:air"
+                        "Name": "minecraft:water"
                     }
                 },
                 {
@@ -28,6 +28,19 @@
                     "output_state": {
                         "Name": "minecraft:air"
                     }
+                },
+                {
+                    "input_predicate": {
+                        "block": "minecraft:iron_block",
+                        "predicate_type": "minecraft:random_block_match",
+                        "probability": 1.0
+                    },
+                    "location_predicate": {
+                        "predicate_type": "minecraft:always_true"
+                    },
+                    "output_state": {
+                        "Name": "minecraft:water"
+                    }
                 }
             ]
         },

gradle.properties

@@ -13,7 +13,7 @@ parchment_version = 2024.07.28@zip
 java_version = 21
 
 mod_id=cobblemon
-mod_version=1.8.0
+mod_version=1.8.1
 snapshot=true
 
 fabric.loom.multiProjectOptimisation=false